Re: [PATCH 0/3] perf fix test case 14

[Thomas-Mich Richter <tmricht@linux.vnet.ibm.com>]

On 06/07/2017 01:17 PM, Jiri Olsa wrote:
> On Tue, Jun 06, 2017 at 04:31:53PM +0200, Thomas Richter wrote:
>> I have taken the following commits from Jiri Olsa's
>> branch perf/attr_test to work on a fix.
>>
>> Commit-id
>> 070b9644981e perf tests attr: Do not store failed events
>> c9666c26ead0 perf tests attr: Make compare_data global
>> 10eb9496d1c3 perf tests attr: Fix compare logic
>> 4ba31b633fab perf tests attr: Add 1s for exclude_kernel ..
>> ede0b0a2e007 perf tests attr: Fix no-delay test
>>
>> I have then added 3 new fixes
>>
>> Thomas Richter (3):
>>   perf: fix incorrect sample_type value for perf stat tests
>>   perf: fix exit code check in test case execution
>>   perf: fix perf test case 14
> 
> those looks fine.. any chance you could take over
> those other 5 from me and post all together?

I would prefer that you post your 5 patches yourself.
I have tested them as well, so you can add me
as Tested-by.

Then I post my 3 patches on top and Arnaldo can
collect them and bundle them together.

> 
>>
>> I can test these changes only on s390.
>> With these changes some test-stat-xxx tests run fine.
>>
>> How to handle test cases currently unsupported on a platform?
>> For example  test-stat-default issues a setup for 
>> PERF_TYPE_HARDWARE / PERF_COUNT_HW_STALLED_CYCLES_BACKEND
>> which is not supported on s390. The perf_event_open()
>> system call fails and no event-00-07--1 file is created.
>>
>> The compare of the test result then fails because attr.py
>> has nothing to check against.
>> We could test if an event file exists and if not report an
>> unsupported test. Is this a good idea?
>> Any other proposals?
> 
> or maybe add list of supported or not supported archs
> to test's [config] section?

Good idea, I will think of something and come back to you.

-- 
Thomas Richter, Dept 3303, IBM LTC Boeblingen Germany
--
Vorsitzende des Aufsichtsrats: Martina Koederitz 
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294