Linux Perf Users
 help / color / mirror / Atom feed
From: James Clark <james.clark@arm.com>
To: "Uwe Kleine-König" <uwe@kleine-koenig.org>,
	"Branislav Rankov" <branislav.rankov@arm.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	linux-perf-users@vger.kernel.org,
	Diederik de Haas <didi.debian@cknow.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>
Subject: Re: [PATCH] perf: Drop -lstdc++ from OPENCSDLIBS
Date: Fri, 3 Dec 2021 09:22:06 +0000	[thread overview]
Message-ID: <4d9761e7-083c-0d94-526b-1513d0eb1576@arm.com> (raw)
In-Reply-To: <f4518dad-b02a-368b-99d7-7a57b57f36eb@kleine-koenig.org>



On 02/12/2021 16:07, Uwe Kleine-König wrote:
> On 12/2/21 17:00, Branislav Rankov wrote:
>> I did not have problems when trying crosscompile in both dynamic and static case.
>> But maybe you have a case where this is a problem. I would like to understand what
>> your case is.
>> Does your libOpenCSD.so have a dependency on libstdc++.so?
>> If so, where is the libstdc++.so?
> 
> As noted in an other thread branch: I have libstdc++.so.6.0.29 but not libstdc++.so. For linking this is enough as the binary that is linked doesn't need any symbols from libstdc++.so.
> 
>> If this is a genuine problem, we could add -lstdc++ conditionally only for the
>> static build.
> 
> That seems to be the path to go then.

Hi Uwe,

Yes I think so. There are also quite a few similar cases in the makefiles like:

  ifeq ($(findstring -static,${LDFLAGS}),-static)
    DWARFLIBS += -lelf -lebl -ldl -lz -llzma -lbz2
  endif

With the conditional added to this patch:

Reviewed-by: James Clark <james.clark@arm.com>


Thanks
James

> 
> Best regards
> Uwe

  reply	other threads:[~2021-12-03  9:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-02 13:43 [PATCH] perf: Drop -lstdc++ from OPENCSDLIBS Uwe Kleine-König
2021-12-02 15:23 ` Uwe Kleine-König
2021-12-02 15:36 ` James Clark
2021-12-02 16:00   ` Branislav Rankov
2021-12-02 16:07     ` Uwe Kleine-König
2021-12-03  9:22       ` James Clark [this message]
2021-12-02 16:03   ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d9761e7-083c-0d94-526b-1513d0eb1576@arm.com \
    --to=james.clark@arm.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=branislav.rankov@arm.com \
    --cc=didi.debian@cknow.org \
    --cc=jolsa@redhat.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=uwe@kleine-koenig.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox