From: kajoljain <kjain@linux.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: cgel.zte@gmail.com, mingo@redhat.com, acme@kernel.org,
mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
jolsa@redhat.com, namhyung@kernel.org, chi.minghao@zte.com.cn,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Zeal Robot <zealci@zte.com.cm>
Subject: Re: [PATCH] tools/perf: remove unneeded variable make code cleaner
Date: Fri, 10 Dec 2021 18:14:46 +0530 [thread overview]
Message-ID: <500a4cce-1e71-fd8a-8fa3-39eb09964e97@linux.ibm.com> (raw)
In-Reply-To: <20211210104203.GT16608@worktop.programming.kicks-ass.net>
On 12/10/21 4:12 PM, Peter Zijlstra wrote:
> On Fri, Dec 10, 2021 at 02:41:55PM +0530, kajoljain wrote:
>>
>>
>> On 12/10/21 7:59 AM, cgel.zte@gmail.com wrote:
>>> From: Minghao Chi <chi.minghao@zte.com.cn>
>>>
>>> return value form directly instead of
>>> taking this in another redundant variable.
>>
>> Can we reword the commit message stating what and
>> from where we are removing it. Its not too clear.
>> Other than that patch looks good to me.
>>
>> Reviewed-By: Kajol Jain<kjain@linux.ibm.com>
>
> Never reply or accept email from cgel.zte@gmail.com, there's multiple
> people using it to send email, this cannot be right.
>
Sure peter, Thanks for pointing it. Will take care next time.
Thanks,
Kajol Jain
prev parent reply other threads:[~2021-12-10 12:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 2:29 [PATCH] tools/perf: remove unneeded variable make code cleaner cgel.zte
2021-12-10 9:11 ` kajoljain
2021-12-10 10:42 ` Peter Zijlstra
2021-12-10 12:44 ` kajoljain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500a4cce-1e71-fd8a-8fa3-39eb09964e97@linux.ibm.com \
--to=kjain@linux.ibm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=cgel.zte@gmail.com \
--cc=chi.minghao@zte.com.cn \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=zealci@zte.com.cm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).