linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	linux-perf-users@vger.kernel.org, ak <ak@linux.intel.com>
Subject: Re: Perf record premature termination
Date: Mon, 11 Feb 2013 15:30:56 -0700	[thread overview]
Message-ID: <51197120.7030207@gmail.com> (raw)
In-Reply-To: <1360620940.17632.194.camel@schen9-DESK>

On 2/11/13 3:15 PM, Tim Chen wrote:
> On Mon, 2013-02-11 at 12:34 -0700, David Ahern wrote:
>> On 2/11/13 11:50 AM, Tim Chen wrote:
>>> David,
>>>
>>> When I am doing a profiling of kernel compile with 32 threads on a 4
>>> socket westmere machine, I found that perf record terminated right away
>>> for the version of perf in 3.7 kernel source tree.
>>> There's no profile data recroded and the compile is running in
>>> background.
>>>
>>> $ make -j32 &
>>> then
>>> $ sudo /test/perf record -a -g -f sleep 5
>>> sleep: Terminated

This is the more appropriate fix. Make mmap consistent with comm. Revert 
the other one.

diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
index 3cf2c3e..ba74a81 100644
--- a/tools/perf/util/event.c
+++ b/tools/perf/util/event.c
@@ -183,7 +183,7 @@ static int perf_event__synthesize_mmap_events(struct 
perf_tool *tool,
          * We raced with a task exiting - just return:
          */
         pr_debug("couldn't open %s\n", filename);
-       return -1;
+       return 0;
     }

     event->header.type = PERF_RECORD_MMAP;

  reply	other threads:[~2013-02-11 22:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-11 18:50 Perf record premature termination Tim Chen
2013-02-11 19:05 ` David Ahern
2013-02-11 19:34 ` David Ahern
2013-02-11 22:15   ` Tim Chen
2013-02-11 22:30     ` David Ahern [this message]
2013-02-12 17:07       ` Tim Chen
2013-02-12 17:16         ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51197120.7030207@gmail.com \
    --to=dsahern@gmail.com \
    --cc=acme@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tim.c.chen@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).