Linux Perf Users
 help / color / mirror / Atom feed
From: "Mi, Dapeng" <dapeng1.mi@linux.intel.com>
To: bot+bpf-ci@kernel.org, peterz@infradead.org, mingo@redhat.com,
	acme@kernel.org, namhyung@kernel.org, irogers@google.com,
	adrian.hunter@intel.com, alexander.shishkin@linux.intel.com,
	ak@linux.intel.com, eranian@google.com, andrii@kernel.org,
	song@kernel.org, ravi.bangoria@amd.com, ananth.narayan@amd.com
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	bpf@vger.kernel.org, dapeng1.mi@intel.com, zide.chen@intel.com,
	thomas.falcon@intel.com, xudong.hao@intel.com,
	sashiko-bot@kernel.org, ast@kernel.org, daniel@iogearbox.net,
	martin.lau@kernel.org, eddyz87@gmail.com,
	yonghong.song@linux.dev, mason@kernel.org,
	ihor.solodrai@linux.dev
Subject: Re: [Patch v7 14/24] perf/x86/intel: Account lbr_pebs_users for arch-PEBS events
Date: Wed, 18 Nov 2026 14:28:32 +0800	[thread overview]
Message-ID: <51f9a700-bd38-4187-87b6-f0fa3534bdb5@linux.intel.com> (raw)
In-Reply-To: <913204cab6fa4a1068980a05e1f85a400d7cadc0d2f60a818cd61f227cdb2e15@mail.kernel.org>


On 11/18/2026 12:10 PM, bot+bpf-ci@kernel.org wrote:
>> perf/x86/intel: Account lbr_pebs_users for arch-PEBS events
> TL;DR:
> - On arch-PEBS, a non-PEBS branch-counter sibling event may report a stale
>   branch stack with zero counters until a later patch fixes it; consider
>   reordering
> - Fixes tag may point to the wrong commit
>
>>     perf/x86/intel: Account lbr_pebs_users for arch-PEBS events
>>
>>     lbr_pebs_users tracks how many PEBS events are currently using LBR.
>>     It is updated for legacy PEBS events, but arch-PEBS events were missing
>>     from that accounting.
>>
>>     Add the missing lbr_pebs_users accounting for arch-PEBS as well.
>>
>>     Fixes: d243d0bb64af ("perf/x86/intel: Initialize architectural PEBS")
>>     [ ... ]
>>     Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
> d243d0bb64af only parses the arch-PEBS CPUID leaves and adds the
> enable/disable callbacks, it does not make arch-PEBS use LBR.  The
> ARCH_PEBS_LBR handling and PERF_SAMPLE_BRANCH_STACK in large_pebs_flags
> came with 52448a0a7390, which predates this series.
>
> Should the tag point there instead:
>
>   Fixes: 52448a0a7390 ("perf/x86/intel: Setup PEBS data configuration and enable legacy groups")

Not exactly. The arch-PEBS feature including the arch-PEBS assisted LBR
snapshotting is supported by a bunch of patches instead of a single patch,
e.g., the commit d243d0bb64af enumerates if the arch-PEBS has the
capability to support LBR snapshot, it's a more appropriate and accurate
commit comparing with 52448a0a7390.


>
>> diff --git a/arch/x86/events/intel/lbr.c b/arch/x86/events/intel/lbr.c
>> --- a/arch/x86/events/intel/lbr.c
>> +++ b/arch/x86/events/intel/lbr.c
> [ ... ]
>
>> @@ -616,7 +616,7 @@ void intel_pmu_lbr_add(struct perf_event *event)
>>  	 * be 'new'. Conversely, a new event can get installed through the
>>  	 * context switch path for the first time.
>>  	 */
>> -	if (x86_pmu.intel_cap.pebs_baseline && event->attr.precise_ip > 0)
>> +	if (intel_pmu_has_pebs_lbr(event->pmu) && event->attr.precise_ip > 0)
>>  		cpuc->lbr_pebs_users++;
>>  	perf_sched_cb_inc(event->pmu);
>>  	if (!cpuc->lbr_users++ && !event->total_time_running)
> Can this make a non-PEBS branch counter event report a stale branch stack
> on arch-PEBS platforms?
>
> With lbr_pebs_users now non-zero on arch-PEBS, the existing shortcut in
> intel_pmu_handle_irq() is taken:
>
>     if (cpuc->lbr_users != cpuc->lbr_pebs_users)
>         intel_pmu_lbr_read(cpu_lbr_stack(cpuc), cpuc->lbr_counters);
>
> That shortcut assumes every consumer of the LBR stack is counted in
> lbr_users.  An event whose branch_sample_type is only
> PERF_SAMPLE_BRANCH_COUNTERS plus PLM bits has
> PERF_X86_EVENT_NEEDS_BRANCH_STACK cleared in intel_pmu_hw_config(), so
> intel_pmu_add_event() never calls intel_pmu_lbr_add() for it and it is not
> counted in lbr_users.  It still has has_branch_stack() set and samples
> through the non-PEBS path in handle_pmi_common():
>
>     if (has_branch_stack(event))
>         intel_pmu_lbr_save_brstack(&data, cpuc, event);
>
> Consider a group on an arch-PEBS CPU with ARCH_PEBS_LBR and PMU_FL_BR_CNTR,
> with a precise leader using branch_type=any,counter and a non-precise
> sampling sibling using only branch_type=counter.  After this patch
> lbr_users == 1 and lbr_pebs_users == 1.  If only the sibling overflows,
> intel_pmu_lbr_read() is skipped, and intel_pmu_lbr_save_brstack() ->
> intel_pmu_lbr_counters_reorder() works on whatever cpu_lbr_stack(cpuc)
> last held.  That is either nr == 0 after intel_pmu_lbr_reset(), or the
> leader's last PEBS-record snapshot from intel_pmu_store_pebs_lbrs(),
> whose raw counters in entries[i].reserved were already zeroed when the
> leader's sample was saved.
>
> So the sibling would report a stale branch stack with all branch counters
> zero, where before this patch it got the live LBR state.  The same
> problem already exists for legacy adaptive PEBS (pebs_baseline), and this
> patch extends it to arch-PEBS.
>
> This looks to be addressed later in the series by 0479605ddd39
> ("perf/x86/intel: Account LBR user counts for pure branch counter
> events"), and 9edb70d448eb ("perf/x86/intel: Refresh LBR stack for
> non-PEBS LBR events when needed") replaces the lbr_users != lbr_pebs_users
> check at PMI entry with an on-demand re-read.  Would it make sense to
> order 0479605ddd39 before this patch so the intermediate state does not
> regress?

Hmm, I don't think the patch order matters. If we put the commit
9edb70d448eb ahead before this patch, the whole arch-PEBS assisted LBR
snapshot won't be counted without this patch regardless of it's a pure
branch counter event. It seems worse. 

Thanks.



>
>
> ---
> AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
> See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
>
> CI run summary: https://github.com/kernel-patches/bpf/actions/runs/44231525404

  reply	other threads:[~2026-11-18  6:28 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  3:14 [Patch v7 00/24] perf/x86: Fix multiple LBR sampling issues Dapeng Mi
2026-11-18  3:14 ` [Patch v7 01/24] perf/x86: Disable LBR if x86_pmu.lbr_nr exceeds MAX_LBR_ENTRIES Dapeng Mi
2026-11-18  3:50   ` sashiko-bot
2026-11-18  3:14 ` [Patch v7 02/24] perf/x86/intel: Validate LBR XSAVE state before updating LBR stack Dapeng Mi
2026-11-18  3:48   ` sashiko-bot
2026-11-18  3:14 ` [Patch v7 03/24] perf/x86/amd/lbr: Limit branch snapshots to valid entries Dapeng Mi
2026-11-18  3:34   ` sashiko-bot
2026-11-18  3:14 ` [Patch v7 04/24] perf/x86/intel: " Dapeng Mi
2026-11-18  3:37   ` sashiko-bot
2026-11-18  4:10   ` bot+bpf-ci
2026-11-18  6:01     ` Mi, Dapeng
2026-11-18  3:14 ` [Patch v7 05/24] perf/x86: Add lbr_enabled to track LBR state Dapeng Mi
2026-11-18  3:58   ` sashiko-bot
2026-11-18  3:14 ` [Patch v7 06/24] perf/x86/amd: Avoid re-enabling PMU and LBR for BPF when disabled Dapeng Mi
2026-11-18  3:43   ` sashiko-bot
2026-11-18  3:14 ` [Patch v7 07/24] perf/x86/intel: Add helper to enable PMU without LBR Dapeng Mi
2026-11-18  3:28   ` sashiko-bot
2026-11-18  3:14 ` [Patch v7 08/24] perf/x86/intel: Avoid re-enabling PMU and LBR for BPF when disabled Dapeng Mi
2026-11-18  3:39   ` sashiko-bot
2026-11-18  3:14 ` [Patch v7 09/24] perf/x86/intel: Keep LBR frozen throughout PMI handling Dapeng Mi
2026-11-18  3:42   ` sashiko-bot
2026-11-18  3:14 ` [Patch v7 10/24] perf: Add counted-bounds tracking for perf_branch_stack Dapeng Mi
2026-11-18  3:35   ` sashiko-bot
2026-11-18  3:14 ` [Patch v7 11/24] perf/x86/intel: Allow LBR read helpers to operate on explicit stacks Dapeng Mi
2026-11-18  3:32   ` sashiko-bot
2026-11-18  3:14 ` [Patch v7 12/24] perf/x86/intel: Use a dedicated LBR stack for BPF snapshotting Dapeng Mi
2026-11-18  3:43   ` sashiko-bot
2026-11-18  3:14 ` [Patch v7 13/24] perf/x86/intel: Always snapshot live hardware LBR state for BPF Dapeng Mi
2026-11-18  3:46   ` sashiko-bot
2026-11-18  3:14 ` [Patch v7 14/24] perf/x86/intel: Account lbr_pebs_users for arch-PEBS events Dapeng Mi
2026-11-18  3:34   ` sashiko-bot
2026-11-18  4:10   ` bot+bpf-ci
2026-11-18  6:28     ` Mi, Dapeng [this message]
2026-11-18  3:14 ` [Patch v7 15/24] perf/x86/intel: Set PERF_EV_CAP_SIBLING for pure branch counter events Dapeng Mi
2026-11-18  4:05   ` sashiko-bot
2026-11-18  6:32     ` Mi, Dapeng
2026-11-18  3:14 ` [Patch v7 16/24] perf/x86/intel: Account LBR user counts " Dapeng Mi
2026-11-18  3:49   ` sashiko-bot
2026-11-18  3:14 ` [Patch v7 17/24] perf/x86/intel: Refresh LBR stack for non-PEBS LBR events when needed Dapeng Mi
2026-11-18  4:09   ` sashiko-bot
2026-11-18  3:14 ` [Patch v7 18/24] perf/x86/intel: Fix draining of un-overflowed PEBS buffer in PMI handler Dapeng Mi
2026-11-18  3:46   ` sashiko-bot
2026-11-18  3:14 ` [Patch v7 19/24] perf/x86/intel: Drain PEBS buffer for branch events with PEBS LBR users Dapeng Mi
2026-11-18  3:52   ` sashiko-bot
2026-11-18  3:14 ` [Patch v7 20/24] perf/x86/intel: Clear raw LBR counters in the LBR stack Dapeng Mi
2026-11-18  3:50   ` sashiko-bot
2026-11-18  3:54   ` bot+bpf-ci
2026-11-18  6:48     ` Mi, Dapeng
2026-11-18  3:14 ` [Patch v7 21/24] perf/x86/intel: Refresh LBR stack for LBR counter events in PMI handler Dapeng Mi
2026-11-18  3:45   ` sashiko-bot
2026-11-18  3:14 ` [Patch v7 22/24] perf/x86/intel: Pass LBR stack size into intel_pmu_store_lbr() Dapeng Mi
2026-11-18  3:46   ` sashiko-bot
2026-11-18  3:14 ` [Patch v7 23/24] perf/core: Don't mutate shared branch stack depth Dapeng Mi
2026-11-18  3:51   ` sashiko-bot
2026-11-18  3:14 ` [Patch v7 24/24] perf/x86/intel: Fix incorrect PERF_METRICS overflow bit clearing Dapeng Mi
2026-11-18  3:46   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51f9a700-bd38-4187-87b6-f0fa3534bdb5@linux.intel.com \
    --to=dapeng1.mi@linux.intel.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=ananth.narayan@amd.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bot+bpf-ci@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=dapeng1.mi@intel.com \
    --cc=eddyz87@gmail.com \
    --cc=eranian@google.com \
    --cc=ihor.solodrai@linux.dev \
    --cc=irogers@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=martin.lau@kernel.org \
    --cc=mason@kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=ravi.bangoria@amd.com \
    --cc=sashiko-bot@kernel.org \
    --cc=song@kernel.org \
    --cc=thomas.falcon@intel.com \
    --cc=xudong.hao@intel.com \
    --cc=yonghong.song@linux.dev \
    --cc=zide.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox