From: Harald Servat <harald.servat@bsc.es>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: Changing frequency rate to perf mem
Date: Thu, 24 Oct 2013 09:48:09 +0200 [thread overview]
Message-ID: <5268D0B9.50704@bsc.es> (raw)
In-Reply-To: <87ppqvs15r.fsf@tassilo.jf.intel.com>
On 24/10/13 07:12, Andi Kleen wrote:
> Harald Servat <harald.servat@bsc.es> writes:
>>
>> BTW, I tried to change this value by adding "-F" and "200" into the
>> argv that is passed to cmd_report by adding
>>
>> rec_argv[i++] = strdup("-F");
>> rec_argv[i++] = strdup("200");
>>
>> into line 42 of perf-mem.c - just after the
>> strdup("record").
>
> You would need to increase the array size too.
Ouch! You're right! I forgot that!
>
>> Unfortunately, this seems to break something and
>> perf segfaults often. Which is the most appropriate way to tune the
>> user frequency of perf mem?
>
> Best would be probably to fix it to pass through unknown
> options, then -F/-c could be just used. I'm not sure
> if this is possible easily with the git option parser.
Sorry, I'm not sure what is the "git option parser" here.
I think that this could be implemented extending the mem_options[] in
file builtin-mem.c lines 205-221.
> Alternatively you can just specify the command line perf mem record
> would specify directly to perf record, plus -c/-F
>
> -andi
>
Thank you very much Andi.
--
WARNING / LEGAL TEXT: This message is intended only for the use of the
individual or entity to which it is addressed and may contain
information which is privileged, confidential, proprietary, or exempt
from disclosure under applicable law. If you are not the intended
recipient or the person responsible for delivering the message to the
intended recipient, you are strictly prohibited from disclosing,
distributing, copying, or in any way using this message. If you have
received this communication in error, please notify the sender and
destroy and delete any copies you may have received.
http://www.bsc.es/disclaimer
next prev parent reply other threads:[~2013-10-24 7:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 15:43 Changing frequency rate to perf mem Harald Servat
2013-10-24 5:12 ` Andi Kleen
2013-10-24 7:48 ` Harald Servat [this message]
2013-10-28 6:50 ` Namhyung Kim
2013-10-28 8:15 ` Harald Servat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5268D0B9.50704@bsc.es \
--to=harald.servat@bsc.es \
--cc=andi@firstfloor.org \
--cc=linux-perf-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).