linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Spencer <maillist-linux@barfooze.de>
To: linux-perf-users@vger.kernel.org
Subject: [PATCH 2/2] perf Makefile: default WERROR to off.
Date: Mon, 25 Aug 2014 21:37:08 +0200	[thread overview]
Message-ID: <53FB9064.1050000@barfooze.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 0 bytes --]



[-- Attachment #2: 0002-perf-Makefile-default-WERROR-to-off.patch --]
[-- Type: text/plain, Size: 1208 bytes --]

From 4a72032828a6784d93f4becf723303a17d723544 Mon Sep 17 00:00:00 2001
From: John Spencer <maillist-linux@barfooze.de>
Date: Mon, 25 Aug 2014 21:25:43 +0200
Subject: [PATCH 2/2] perf Makefile: default WERROR to off.

Having WERROR on by default breaks build everywhere the author hasn't
tested so far; including musl libc which warns about wrong includes.

The unsuspecting user will think there's something broken and only
if he's coureageuous enough to grep the Makefile infrastructure find
out that he may be able to get the build working with WERROR=0.

OTOH with WERROR defaulting to off, anything will work for the user
and the maintainer can knowingly use WERROR=1 to do his test builds.

Signed-off-by: John Spencer <maillist-linux@barfooze.de>

---
 tools/perf/config/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
index 1f67aa0..b1d639a 100644
--- a/tools/perf/config/Makefile
+++ b/tools/perf/config/Makefile
@@ -102,7 +102,7 @@ ifeq ($(call get-executable,$(BISON)),)
 endif
 
 # Treat warnings as errors unless directed not to
-ifneq ($(WERROR),0)
+ifeq ($(WERROR),1)
   CFLAGS += -Werror
 endif
 
-- 
1.8.4


             reply	other threads:[~2014-08-25 20:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-25 19:37 John Spencer [this message]
2014-08-26  6:53 ` [PATCH 2/2] perf Makefile: default WERROR to off Namhyung Kim
2014-08-26 12:11   ` John Spencer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53FB9064.1050000@barfooze.de \
    --to=maillist-linux@barfooze.de \
    --cc=linux-perf-users@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).