From: taeung <treeze.taeung@gmail.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] modify error code when perf_session__new() fail.
Date: Wed, 24 Sep 2014 10:39:32 +0900 [thread overview]
Message-ID: <542220D4.5070404@gmail.com> (raw)
In-Reply-To: <20140923120231.GD2979@krava.brq.redhat.com>
hi,
Sorry for my wrong format.
According to what you tell me , I forwarded the patch, again.
Thank you for your advice.
Thanks,
Taeung
On 09/23/2014 09:02 PM, Jiri Olsa wrote:
> hi,
> subject should start with 'perf tools:'
>
> On Tue, Sep 23, 2014 at 03:12:17PM +0900, taeung wrote:
>> Because perf_session__new() could fail
>> for more reasons than just ENOMEM,
>> I modified error code(ENOMEM or EINVAL)
>> into -1.
> why the indent?
>
>> Signed-off-by: taeung <treeze.taeung@gmail.com>
> the log message needs some love, but the patch looks ok
>
> Acked-by: Jiri Olsa <jolsa@kernel.org>
>
> thanks,
> jirka
prev parent reply other threads:[~2014-09-24 1:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 6:12 [PATCH] modify error code when perf_session__new() fail taeung
2014-09-23 12:02 ` Jiri Olsa
2014-09-24 1:39 ` taeung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542220D4.5070404@gmail.com \
--to=treeze.taeung@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-perf-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).