From: Dave Hansen <dave.hansen@intel.com>
To: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org
Cc: daniel.sneddon@linux.intel.com, tony.luck@intel.com,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-perf-users@vger.kernel.org,
Josh Poimboeuf <jpoimboe@kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
"Liang, Kan" <kan.liang@linux.intel.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Brice Goglin <brice.goglin@gmail.com>,
Mario Limonciello <mario.limonciello@amd.com>,
Perry Yuan <Perry.Yuan@amd.com>,
Dapeng Mi <dapeng1.mi@linux.intel.com>
Subject: Re: [PATCH v6 4/5] x86/bugs: Declutter vulnerable CPU list
Date: Thu, 6 Mar 2025 07:18:55 -0800 [thread overview]
Message-ID: <542cfd1b-65f8-4fa9-811e-d70850d0cf9a@intel.com> (raw)
In-Reply-To: <20250305-add-cpu-type-v6-4-4741735bcd75@linux.intel.com>
On 3/5/25 23:13, Pawan Gupta wrote:
...
> #define VULNWL_INTEL(vfm, whitelist) \
> - X86_MATCH_VFM(vfm, whitelist)
> + X86_MATCH_VFM(INTEL_##vfm, whitelist)
I think the new VFM code may have thrown you off here. Doing HASWELL_X
is not as nice as INTEL_HASWELL_X because, while you can grep for it, it
won't work when you're looking for full identifiers like with ctags or
cscope.
Also, this is just putting the "INTEL" in the macro instead of the VFM.
I'm not sure there's much value in doing:
VULNWL_INTEL(ALDERLAKE_L, ...)
over:
X86_MATCH_VFM(INTEL_ALDERLAKE_L, ...)
Before the 'vfm' stuff, we needed X86_VENDOR_INTEL in there somewhere.
But now that it's built in to INTEL_ALDERLAKE_L, we don't.
next prev parent reply other threads:[~2025-03-06 15:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 7:12 [PATCH v6 0/5] Utilize cpu-type for CPU matching Pawan Gupta
2025-03-06 7:12 ` [PATCH v6 1/5] x86/cpu: Name CPU matching macro more generically (and shorten) Pawan Gupta
2025-03-06 7:13 ` [PATCH v6 2/5] x86/cpu: Add cpu_type to struct x86_cpu_id Pawan Gupta
2025-03-06 7:13 ` [PATCH v6 3/5] x86/cpu: Update x86_match_cpu() to also use cpu-type Pawan Gupta
2025-03-06 7:13 ` [PATCH v6 4/5] x86/bugs: Declutter vulnerable CPU list Pawan Gupta
2025-03-06 15:18 ` Dave Hansen [this message]
2025-03-06 16:57 ` Pawan Gupta
2025-03-06 17:03 ` Dave Hansen
2025-03-06 17:20 ` Pawan Gupta
2025-03-06 7:13 ` [PATCH v6 5/5] x86/rfds: Exclude P-only parts from the RFDS affected list Pawan Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542cfd1b-65f8-4fa9-811e-d70850d0cf9a@intel.com \
--to=dave.hansen@intel.com \
--cc=Perry.Yuan@amd.com \
--cc=andrew.cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=brice.goglin@gmail.com \
--cc=daniel.sneddon@linux.intel.com \
--cc=dapeng1.mi@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=jpoimboe@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mingo@redhat.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=rafael@kernel.org \
--cc=ricardo.neri-calderon@linux.intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).