Re: [PATCH 3/3] tools/testing/selftests/powerpc: Update the bhrb filter sampling test to test for multiple branch filters

[kajoljain <kjain@linux.ibm.com>]

On 9/13/22 17:25, Athira Rajeev wrote:
> For PERF_SAMPLE_BRANCH_STACK sample type, different branch_sample_type,
> ie branch filters are supported. The testcase "bhrb_filter_map_test"
> tests the valid and invalid filter maps in different powerpc platforms.
> Update this testcase to include scenario to cover multiple branch
> filters at sametime. Since powerpc doesn't support multiple filters at
> sametime, expect failure during perf_event_open.
> 
> Reported-by: Disha Goel <disgoel@linux.vnet.ibm.com>
> Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
> ---
>  .../powerpc/pmu/sampling_tests/bhrb_filter_map_test.c    | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/tools/testing/selftests/powerpc/pmu/sampling_tests/bhrb_filter_map_test.c b/tools/testing/selftests/powerpc/pmu/sampling_tests/bhrb_filter_map_test.c
> index 8182647c63c8..605669d4e4cb 100644
> --- a/tools/testing/selftests/powerpc/pmu/sampling_tests/bhrb_filter_map_test.c
> +++ b/tools/testing/selftests/powerpc/pmu/sampling_tests/bhrb_filter_map_test.c
> @@ -96,6 +96,15 @@ static int bhrb_filter_map_test(void)
>  		}
>  	}
>  

Patch looks good to me.

Reviewed-By: Kajol Jain <kjain@linux.ibm.com>

Thanks,
Kajol Jain


> +	/*
> +	 * Combine filter maps which includes a valid branch filter and an invalid branch
> +	 * filter. Example: any ( PERF_SAMPLE_BRANCH_ANY) and save_type
> +	 * (PERF_SAMPLE_BRANCH_TYPE_SAVE).
> +	 * The perf_event_open should fail in this case.
> +	 */
> +	event.attr.branch_sample_type = PERF_SAMPLE_BRANCH_ANY | PERF_SAMPLE_BRANCH_TYPE_SAVE;
> +	FAIL_IF(!event_open(&event));
> +
>  	return 0;
>  }
>