From: Adrian Hunter <adrian.hunter@intel.com>
To: Changbin Du <changbin.du@huawei.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Hui Wang <hw.huiwang@huawei.com>
Subject: Re: [PATCH v3 0/3] perf: add new option '--workload-attr' to set workload sched_policy/priority/mask
Date: Thu, 20 Jul 2023 13:00:58 +0300 [thread overview]
Message-ID: <5889e93b-5ee3-8d59-c2fb-bce7070a1ab2@intel.com> (raw)
In-Reply-To: <20230718033355.2960912-1-changbin.du@huawei.com>
On 18/07/23 06:33, Changbin Du wrote:
> This adds a new option '--workload-attr' to set the sched_policy/priority/mask
> of the workload to reduce system noise.
>
> $ sudo perf stat --workload-attr fifo,40,0-3:7 -- ls
Not really sold on the need for this, but maybe it could be
simpler.
What about just adding a hook for a command (e.g. script) to
run before exec'ing the workload e.g.
--configure-workload=blah.sh
results in perf doing system("blah.sh 12345") where 12345
is the workload PID.
Then maybe you could do:
--configure-workload="taskset -p 0x3"
>
> Please see patch 1/2 for more details.
>
> v3:
> - replace taskset with --workload-attr option in documents and tests.
> v2:
> - Use cpu list spec instead of cpu mask number.
> - Update documents.
>
> Changbin Du (3):
> perf cpumap: Add __perf_cpu_map__new and perf_cpu_map__2_cpuset
> perf: add new option '--workload-attr' to set workload
> sched_policy/priority/mask
> perf: replace taskset with --workload-attr option
>
> tools/lib/perf/cpumap.c | 45 ++++++-
> tools/lib/perf/include/perf/cpumap.h | 4 +
> tools/lib/perf/libperf.map | 2 +
> tools/perf/Documentation/intel-hybrid.txt | 2 +-
> tools/perf/Documentation/perf-record.txt | 7 ++
> tools/perf/Documentation/perf-stat.txt | 8 +-
> tools/perf/builtin-record.c | 26 ++++
> tools/perf/builtin-stat.c | 18 +++
> tools/perf/tests/cpumap.c | 23 ++++
> .../tests/shell/stat_bpf_counters_cgrp.sh | 2 +-
> tools/perf/tests/shell/test_arm_coresight.sh | 2 +-
> tools/perf/tests/shell/test_data_symbol.sh | 2 +-
> tools/perf/tests/shell/test_intel_pt.sh | 2 +-
> tools/perf/util/evlist.c | 117 ++++++++++++++++++
> tools/perf/util/evlist.h | 3 +
> tools/perf/util/target.h | 9 ++
> 16 files changed, 263 insertions(+), 9 deletions(-)
>
next prev parent reply other threads:[~2023-07-20 10:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 3:33 [PATCH v3 0/3] perf: add new option '--workload-attr' to set workload sched_policy/priority/mask Changbin Du
2023-07-18 3:33 ` [PATCH v3 1/3] perf cpumap: Add __perf_cpu_map__new and perf_cpu_map__2_cpuset Changbin Du
2023-07-18 3:33 ` [PATCH v3 2/3] perf: add new option '--workload-attr' to set workload sched_policy/priority/mask Changbin Du
2023-07-18 3:33 ` [PATCH v3 3/3] perf: replace taskset with --workload-attr option Changbin Du
2023-07-20 10:00 ` Adrian Hunter [this message]
2023-07-24 4:02 ` [PATCH v3 0/3] perf: add new option '--workload-attr' to set workload sched_policy/priority/mask Changbin Du
2023-07-24 5:44 ` Adrian Hunter
2023-07-24 9:34 ` Changbin Du
2023-07-24 17:51 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5889e93b-5ee3-8d59-c2fb-bce7070a1ab2@intel.com \
--to=adrian.hunter@intel.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=changbin.du@huawei.com \
--cc=hw.huiwang@huawei.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).