From: "Liang, Kan" <kan.liang@linux.intel.com>
To: Zhenyu Wang <zhenyuw@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
x86@kernel.org, Rui Zhang <rui.zhang@intel.com>,
Artem Bityutskiy <artem.bityutskiy@intel.com>,
Wendy Wang <wendy.wang@intel.com>
Subject: Re: [PATCH tip rebase] perf/x86/intel/cstate: Add pkg C2 residency counter for Sierra Forest
Date: Wed, 17 Jul 2024 09:06:43 -0400 [thread overview]
Message-ID: <5bd0d2dd-27cd-4054-b152-c5acf7ef3084@linux.intel.com> (raw)
In-Reply-To: <20240717031609.74513-1-zhenyuw@linux.intel.com>
On 2024-07-16 11:16 p.m., Zhenyu Wang wrote:
> Package C2 residency counter is also available on Sierra Forest.
> So add it support in srf_cstates.
>
> Cc: Rui Zhang <rui.zhang@intel.com>
> Cc: Artem Bityutskiy <artem.bityutskiy@intel.com>
> Cc: Wendy Wang <wendy.wang@intel.com>
> Tested-by: Wendy Wang <wendy.wang@intel.com>
> Fixes: 3877d55a0db2 ("perf/x86/intel/cstate: Add Sierra Forest support")
> Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
Thanks,
Kan
> ---
>
> Hi, Peter
>
> This refresh resolved conflicts in comment against current tip tree.
> Please help to apply.
>
> Thanks!
>
> arch/x86/events/intel/cstate.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/events/intel/cstate.c b/arch/x86/events/intel/cstate.c
> index be58cfb012dd..9f116dfc4728 100644
> --- a/arch/x86/events/intel/cstate.c
> +++ b/arch/x86/events/intel/cstate.c
> @@ -64,7 +64,7 @@
> * perf code: 0x00
> * Available model: SNB,IVB,HSW,BDW,SKL,KNL,GLM,CNL,
> * KBL,CML,ICL,ICX,TGL,TNT,RKL,ADL,
> - * RPL,SPR,MTL,ARL,LNL
> + * RPL,SPR,MTL,ARL,LNL,SRF
> * Scope: Package (physical package)
> * MSR_PKG_C3_RESIDENCY: Package C3 Residency Counter.
> * perf code: 0x01
> @@ -693,7 +693,8 @@ static const struct cstate_model srf_cstates __initconst = {
> .core_events = BIT(PERF_CSTATE_CORE_C1_RES) |
> BIT(PERF_CSTATE_CORE_C6_RES),
>
> - .pkg_events = BIT(PERF_CSTATE_PKG_C6_RES),
> + .pkg_events = BIT(PERF_CSTATE_PKG_C2_RES) |
> + BIT(PERF_CSTATE_PKG_C6_RES),
>
> .module_events = BIT(PERF_CSTATE_MODULE_C6_RES),
> };
next prev parent reply other threads:[~2024-07-17 13:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 8:48 [PATCH] perf/x86/intel/cstate: Add pkg C2 residency counter for Sierra Forest Zhenyu Wang
2024-05-15 3:21 ` [PATCH RESEND] " Zhenyu Wang
2024-05-15 13:01 ` Wang, Wendy
2024-06-12 8:08 ` [PATCH RESEND AGAIN] " Zhenyu Wang
2024-07-17 3:16 ` [PATCH tip rebase] " Zhenyu Wang
2024-07-17 13:06 ` Liang, Kan [this message]
2024-07-17 16:29 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bd0d2dd-27cd-4054-b152-c5acf7ef3084@linux.intel.com \
--to=kan.liang@linux.intel.com \
--cc=artem.bityutskiy@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rui.zhang@intel.com \
--cc=wendy.wang@intel.com \
--cc=x86@kernel.org \
--cc=zhenyuw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).