Re: [PATCH] include program header in elf files generated by perf inject

[Lieven Hey <lieven.hey@kdab.com>]

Hi Leo,

6d518ac7be62 was not in my code base. It fixes the issue, but not in my 
usecase. In my usecase I open the elf files with elfutils, but elfutils 
requires a program header to be present.

Cheers,
Lieven

Am 13.09.22 um 15:49 schrieb Leo Yan:
> Hi Lieven,
> 
> On Tue, Sep 13, 2022 at 03:34:18PM +0200, Lieven Hey wrote:
>> Hi,
>>
>> perf is unable to open elf files generated by perf inject.
>>
>> Example:
>> Create a file named test.dart with the following content:
>>
>> void main() {
>>      print("Hello World");
>> }
>>
>> and then run
>>
>> perf record --call-graph dwarf -k 1 dart --generate-perf-jitdump test.dart
>> perf inject -j -i perf.data -o perf.data.jitted
>>
>> The problem exists since 2d86612aacb78. The commit added some code that now
>> requires an elf file to have a valid program header.
> 
> Sorry I missed this patch.
> 
> Could you confirm if the commit 6d518ac7be62 ("perf symbol: Fail to read
> phdr workaround") is included in your local code base?
> 
> After a quick look for this patch, I think it is doing right thing.
> Just want to check if this is the same issue with the one fixed by the
> commit 6d518ac7be62.  I will review it in details in my next 1~2 days.
> 
>>> Can you reply-all on the original mailing list thread with this and a
>>> 'to' to Leo. It's probably best to continue the discussion there so Leo
>>> is aware.
> 
> Thanks a lot, James.
> 
> Leo