From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6AB127442 for ; Mon, 15 Jul 2024 10:27:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721039230; cv=none; b=IhEKWcSpqEDvM+4Fz8ze7CixErGoxp2VxNrq/09XkN+Gf1w2rBZgxFuId/mB8CB97YJy5fTJttoTkTn2olyL91tztt4ISuOVIWSz9LoAynQI1FCP4XJuCSKWfDoi2rzZrrlSJBXsZnV4APqkZ45by4FFCUesEW01ERAqLvgz3Vk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721039230; c=relaxed/simple; bh=LNT1vxiqXsL0kXYG9utHHxb48gkqD7cdbVpmEI+FEng=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=pJy8uF3iatGrGgojfozSFwvYuWo24bAGxPUc3BCdSuo8Ts0Ei1OANoRF0lh2jLKQHxHDPn/Wc6dI50LxKYpCSH4FGbhJHjYsdM44VTUaJ39nSqa6NrPeuQaC5tQt2tHm+PZZWCDjEsNhycQxTPAnSE5GS643pzz57FyaZ81lEEE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Ugyqt/yo; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Ugyqt/yo" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-367a183df54so2755424f8f.2 for ; Mon, 15 Jul 2024 03:27:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721039227; x=1721644027; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=+YB6GyEske1j+4F/X1u+CO+rNqDoQgEE3OjwyzWAy9k=; b=Ugyqt/yoTLOi2odGZDdpRtmeGkdKk+DI6d8GaO7jm63+BaQ602N34p/ll2LysT14ZD yIODe7Y5uo53brWafFV49ayWwG9PgrqTlk0Tyit9dDButB9PC4nvmnZLUztQzjjY4vGi sHeDRhtgC59PnnF+fBNP87C2DB0S9vg6fMiKrrjfhKdW1kKchXhH6jC8Zf4JIt9MLKVg VpCG/0uQPyDcorFPL5tI4FiCHY49o+Xxgh0y0K2jD9CQI3qlkYNgUK7fbZNe3V0Y9Z6E NAIOFcMoKnXw4E/jMAbmYs1pglOLnaFIqLnntics+7C5MSSmhE8j5LUPl79VbsDfx7uj Zvew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721039227; x=1721644027; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+YB6GyEske1j+4F/X1u+CO+rNqDoQgEE3OjwyzWAy9k=; b=r0jgSKRlMDdJTzxj0h8yfAVM1pjuHGnw88x+oQTWyOj9Bh6f+xMPlR2J0b5UDArXLq 59OoMJrgrqwWZi7qc5SXdVaDSEakmDLXN4sseHZit6NLr0rKRgbqKr7dQUssr8ggZnbk q2yQUoSw7laT2mj6hRrVXiVYgSCEIzZbgYdlyY4JnQTFMSDwxbA24THgSz+C1uSu7ejf zu5PYnMtoNr+JgZejOGoNchbxSisWieA55nDjrdZ2KbgbimCh393KqhN/JGkcK1Hm7Xh hpsRNnrGvW68OcwhLp94uHuE0zCz1VUbOLXvbeMrwzWEGQOhEtaku4sOPvG+LoZ+pEKR l3lQ== X-Forwarded-Encrypted: i=1; AJvYcCVcjvwhss5c3lYnBFFgwPxA6up2PqQRCx5C9N3Y2ja0O2ZHdp5ldWDz16iXLoyAqY7J5lesTkO9DGC5HZFbTbRJJxxk+gGMbcBwHLPlRI4fsw== X-Gm-Message-State: AOJu0YwH6h0CDFSGLXWFiYOiaksETWUrkfxODdWTUqH/qBKMVS2KGB/t s/12oE+YOg6NUsUKm4PssmjpHms8ugI0IiRyY/mI/3JfMzgrDAo/czKoLoQs6Ug= X-Google-Smtp-Source: AGHT+IFzeOMW994aFZZ6KhlY57Z3nO94Tx9Y3WX/O7j+SzIT09YBmXya/qnh018zd8sZP2VHnLZmaA== X-Received: by 2002:a5d:540c:0:b0:362:8ec2:53d6 with SMTP id ffacd0b85a97d-367cead91f0mr11986981f8f.61.1721039227157; Mon, 15 Jul 2024 03:27:07 -0700 (PDT) Received: from [192.168.1.3] ([89.47.253.130]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3680dabefa6sm5952666f8f.44.2024.07.15.03.27.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jul 2024 03:27:06 -0700 (PDT) Message-ID: <5da9faa9-132c-4038-8b28-3b6e2fdeb1eb@linaro.org> Date: Mon, 15 Jul 2024 11:27:05 +0100 Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3 00/10] perf tools: Fix test "perf probe of function from different CU" From: James Clark To: Chaitanya S Prakash , linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo , Ian Rogers , Namhyung Kim Cc: anshuman.khandual@arm.com, Josh Poimboeuf , Suzuki K Poulose , Mike Leach , John Garry , Will Deacon , Leo Yan , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Chenyuan Mi , Masami Hiramatsu , Ravi Bangoria , =?UTF-8?Q?Ahelenia_Ziemia=C5=84ska?= , Colin Ian King , Changbin Du , Kan Liang , Athira Rajeev , Tiezhu Yang , Alexey Dobriyan , =?UTF-8?Q?Georg_M=C3=BCller?= , Liam Howlett , bpf@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peter Zijlstra , Ingo Molnar References: <20240601125946.1741414-1-ChaitanyaS.Prakash@arm.com> <65aaf9bb-ab2c-4185-b5bb-22a717ac7e73@arm.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 15/07/2024 10:34 am, James Clark wrote: > > > On 10/07/2024 8:39 am, Chaitanya S Prakash wrote: >> Gentle ping, are there any updates on the string clean up patch set? >> >> On 6/1/24 18:29, Chaitanya S Prakash wrote: >>> From: Chaitanya S Prakash >>> >>> Perf treated all files beginning with "/tmp/perf-" as a map file despite >>> them always ending in ".map", this caused the test "perf probe of >>> function from different CU" to fail when Perf was built with NO_DWARF=1. >>> As the file was parsed as a map file, the probe...--funcs command output >>> garbage values instead of listing the functions in the binary. After >>> fixing the issue an additional check to test the output of the >>> probe...--funcs command has been added. >>> >>> Additionally, various functions within the codebase have been refactored >>> and restructured. The definition of str_has_suffix() has been adopted >>> from tools/bpf/bpftool/gen.c and added to tools/lib/string.c in an >>> attempt to make the function more generic. The implementation has been >>> retained but the return values have been modified to resemble that of >>> str_has_prefix(), i.e., return strlen(suffix) on success and 0 on >>> failure. In light of the new addition, "ends_with()", a locally defined >>> function used for checking if a string had a given suffix has been >>> deleted and str_has_suffix() has replaced its usage. A call to >>> strtailcmp() has also been replaced as str_has_suffix() seemed more >>> suited for that particular use case. >>> >>> Finally str_has_prefix() is adopted from the kernel and is added to >>> tools/lib/string.c, following which strstarts() is deleted and its use >>> has been replaced with str_has_prefix(). >>> >>> This patch series has been tested on 6.10-rc1 mainline kernel, both on >>> arm64 and x86 platforms. >>> >>> Changes in V3: >>> >>> - Patch adding configs required by "perf probe of function from >>> different >>>    CU" was originally part of the series but has been merged in >>> 6.10-rc1. >>> https://github.com/torvalds/linux/commit/6b718ac6874c2233b8dec369a8a377d6c5b638e6 >>> >>> - Restructure patches according to the maintainer trees. >>> - Add explanation for why '| grep "foo"' is used. >>> - Fix build errors for when perf is built with LLVM=1. >>> >>> Changes in V2: >>> https://lore.kernel.org/all/20240408062230.1949882-1-ChaitanyaS.Prakash@arm.com/ >>> >>> - Add str_has_suffix() and str_has_prefix() to tools/lib/string.c >>> - Delete ends_with() and replace its usage with str_has_suffix() >>> - Replace an instance of strtailcmp() with str_has_suffix() >>> - Delete strstarts() from tools/include/linux/string.h and replace its >>>    usage with str_has_prefix() >>> >>> Changes in V1: >>> https://lore.kernel.org/all/20240220042957.2022391-1-ChaitanyaS.Prakash@arm.com/ >>> >>> Cc: Josh Poimboeuf >>> Cc: Peter Zijlstra >>> Cc: Suzuki K Poulose >>> Cc: Mike Leach >>> Cc: James Clark >>> Cc: John Garry >>> Cc: Will Deacon >>> Cc: Leo Yan >>> Cc: Ingo Molnar >>> Cc: Arnaldo Carvalho de Melo >>> Cc: Namhyung Kim >>> Cc: Mark Rutland >>> Cc: Alexander Shishkin >>> Cc: Jiri Olsa >>> Cc: Ian Rogers >>> Cc: Adrian Hunter >>> Cc: Chenyuan Mi >>> Cc: Masami Hiramatsu >>> Cc: Ravi Bangoria >>> Cc: Ahelenia Ziemiańska >>> Cc: Colin Ian King >>> Cc: Changbin Du >>> Cc: Kan Liang >>> Cc: Athira Rajeev >>> Cc: Tiezhu Yang >>> Cc: Alexey Dobriyan >>> Cc: Georg Müller >>> Cc: Liam Howlett >>> Cc: bpf@vger.kernel.org >>> Cc: coresight@lists.linaro.org >>> Cc: linux-arm-kernel@lists.infradead.org >>> Cc: linux-kernel@vger.kernel.org >>> Cc: linux-perf-users@vger.kernel.org >>> >>> Chaitanya S Prakash (10): >>>    tools lib: adopt str_has_suffix() from bpftool/gen.c > > LGTM, > > Reviewed-by: James Clark Reviewed-by: James Clark Need to fix that... > > The below commit looked like it could be prone to an off by one error > but I debugged it to confirm that it's ok: > >>>    perf util: Delete ends_with() and replace its use with >>>      str_has_suffix() > >>>    perf util: Replace an instance of strtailcmp() by str_has_suffix() >>>    tools lib: Adopt str_has_prefix() from kernel >>>    libsubcmd: Replace strstarts() usage with str_has_prefix() >>>    objtool: Replace strstarts() usage with str_has_prefix() >>>    perf tools: Replace strstarts() usage with str_has_prefix() >>>    tools lib: Remove strstarts() as all its usecases have been replaced >>>      by str_has_prefix() >>>    perf tools: Only treat files as map files when they have the >>> extension >>>      .map >>>    perf test: Check output of the probe ... --funcs command >>> >>>   tools/include/linux/string.h                  | 12 ++--- >>>   tools/lib/string.c                            | 48 +++++++++++++++++++ >>>   tools/lib/subcmd/help.c                       |  2 +- >>>   tools/lib/subcmd/parse-options.c              | 18 +++---- >>>   tools/objtool/check.c                         |  2 +- >>>   tools/perf/arch/arm/util/pmu.c                |  4 +- >>>   tools/perf/arch/x86/annotate/instructions.c   | 14 +++--- >>>   tools/perf/arch/x86/util/env.c                |  2 +- >>>   tools/perf/builtin-c2c.c                      |  4 +- >>>   tools/perf/builtin-config.c                   |  2 +- >>>   tools/perf/builtin-daemon.c                   |  2 +- >>>   tools/perf/builtin-ftrace.c                   |  2 +- >>>   tools/perf/builtin-help.c                     |  6 +-- >>>   tools/perf/builtin-kmem.c                     |  2 +- >>>   tools/perf/builtin-kvm.c                      | 14 +++--- >>>   tools/perf/builtin-kwork.c                    | 10 ++-- >>>   tools/perf/builtin-lock.c                     |  6 +-- >>>   tools/perf/builtin-mem.c                      |  4 +- >>>   tools/perf/builtin-sched.c                    |  6 +-- >>>   tools/perf/builtin-script.c                   | 30 ++++-------- >>>   tools/perf/builtin-stat.c                     |  4 +- >>>   tools/perf/builtin-timechart.c                |  2 +- >>>   tools/perf/builtin-trace.c                    |  6 +-- >>>   tools/perf/perf.c                             | 12 ++--- >>>   .../shell/test_uprobe_from_different_cu.sh    |  2 +- >>>   tools/perf/tests/symbols.c                    |  2 +- >>>   tools/perf/ui/browser.c                       |  2 +- >>>   tools/perf/ui/browsers/scripts.c              |  2 +- >>>   tools/perf/ui/stdio/hist.c                    |  2 +- >>>   tools/perf/util/amd-sample-raw.c              |  4 +- >>>   tools/perf/util/annotate.c                    |  2 +- >>>   tools/perf/util/callchain.c                   |  2 +- >>>   tools/perf/util/config.c                      | 12 ++--- >>>   tools/perf/util/map.c                         |  8 ++-- >>>   tools/perf/util/pmus.c                        |  2 +- >>>   tools/perf/util/probe-event.c                 |  2 +- >>>   tools/perf/util/sample-raw.c                  |  2 +- >>>   tools/perf/util/symbol-elf.c                  |  4 +- >>>   tools/perf/util/symbol.c                      |  3 +- >>>   39 files changed, 148 insertions(+), 117 deletions(-) >>> >>