From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EB5E3232 for ; Mon, 13 Jan 2025 14:33:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736778831; cv=none; b=RbveeBcAOoMnUDF7a7nr8BOIfAOXfWcT/ojd5fr5whxqsoh6XfX/Qhx8VmQKqVXCriQgWehKYtsHEidKMPCR/RHioQS/HA1QUwEJqjp2Izc6lLr8T2rCOFBaiOz115YCIEY17zFY28PncX7fHdhgnuGwE7JaIolqfSSuRQgUbv0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736778831; c=relaxed/simple; bh=UI5UyGHuHx/kdjWc1ifSNCtnWW7AKfhnT+stQLJgjJ8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Qhg9yEJYrP6cgcsIBixdRGa0D7PHeEImyN/7sUCjIKaBWR/gx2hG86sijOWDmqTSDKEBaQdbPG2WlUwZ1MDQx6cAsPGTJtIZD8V3YqtKtIK9OOjF1BavzuwdE5YS5iMrr9i748JKzCoy+3Uh8IMQWv3DrQs2OPMsU7M7pme674I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Pl9v3cKR; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Pl9v3cKR" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4361b0ec57aso42091985e9.0 for ; Mon, 13 Jan 2025 06:33:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736778829; x=1737383629; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MqbC9h0hn607K4Ewdqlu+9qs+7+DikbnXyIiUIob8m8=; b=Pl9v3cKR/Y9zStQ0pSc57YUmGwD+yPW8ate390qUQivSveNhc1Z2qyIqcrdje8VNxm G2esWiHsHHKMHF5EGEfsIsfds4vmKxv8eth6Ef7wn8/LeW+ghaXr4qr1M+zaBAbjzsXd nYMXC3vapiaCatwGIqBd+JLPMxgZZXky+/xTWjFmdV0smDpvCRYxHx+pcyIZa9cyfur1 Vibgq4xvvbooacmoBL/H6HgYnuiPl7NLW1nFvu2XMNasxYBuw80zGdamsIhQlhkPXKqa n7yv6zMB4yO3EEJE7jof3jpA9k79fJeDrSRU2Rq7jsSGw6I6FzsFepuJDzn9AJpPlR88 XjEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736778829; x=1737383629; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MqbC9h0hn607K4Ewdqlu+9qs+7+DikbnXyIiUIob8m8=; b=f0mb4rO2TfTqWOFjLMVn+miOKUvd3BdmpKnlIP8z1Nsy4+8/6L3XLdlHKK6F3IIQGh C2BZajClB9+Xh+11fo8y6BZTez0WaPuOHfaxp7zVQSxdQo0F4z5+WOaCHOwU0D4Q6vOV MoOWZOlM1NDiKVLIfobjLDqcJChQVzpvOY3yQq77XJeVyUbcNop6gndiFcwBuxd0BtcY lGt3+ZoOO7zn77FdhYgYPWFGL5jPTaexOppqJdZCNjvZsQFVxHOmEdSvRbunXDhBdzwy EvEiahfXYbUVdeQPhSZZcxnSh2by8UV5MrGwsmDPhO4aAQffE19Um6vOvxx7+iGMehTR mjlA== X-Forwarded-Encrypted: i=1; AJvYcCUrpng6dXOKiYZGnTciBW6mRUa27O1McgsA7KGBulbs7MRHzJLVcF9tyajuFgQbs38qRJ4Cula/LcuDDfQpPJ80@vger.kernel.org X-Gm-Message-State: AOJu0YwQMzSOEnstwsaYv1QsfI/XVfXnGi+0Sa342qXaYzt9TwFHXFl8 Rb7qB06loX0QogZgFsg4nN3ZQIEQQM5W08Nldi5BoqOgqE8MOcYwQ78HiZg1qZ8= X-Gm-Gg: ASbGncvMcyfc4melsITf/tmfQ/kHd7BWbnppk+UaclE/Q4mXwezwPTXnVDAf6PATDOv yoG1aA+feMow+XzJxRcCicj1iVK4t8d2MZmsgvws735+ByRov20zGgG+Qy2twBzxmXgOqSq2Qeu 8gBke+W4ir+omU+OMcN0ofSBDxN2yKPw03JJH9uH+6ap2L6UVgEuWZfb/JnVYQRexxoD3qtkp67 I3qXJi2c5Y1lyVm1T2mlW2ynD7aF4zZkRwFirpNCxuoW+ubxQpcSe0Mdf8cIpeNLxXs X-Google-Smtp-Source: AGHT+IH09rhSt7io4S7fN4A/EBvnW9x8LDmprwxYrp67xLY37+QhpKW/LvjLTHUaqq4ASbZ5AEkR2A== X-Received: by 2002:a05:600c:4511:b0:436:5165:f1ec with SMTP id 5b1f17b1804b1-436e271d428mr208866655e9.30.1736778828577; Mon, 13 Jan 2025 06:33:48 -0800 (PST) Received: from [192.168.68.163] ([212.105.145.205]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e9e6263fsm149061365e9.39.2025.01.13.06.33.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jan 2025 06:33:48 -0800 (PST) Message-ID: <5ea201e5-6ab7-4935-a8ce-20f67f3193c1@linaro.org> Date: Mon, 13 Jan 2025 14:33:46 +0000 Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/5] perf: arm_spe: Add format option for discard mode To: Will Deacon , namhyung@kernel.org, acme@kernel.org Cc: catalin.marinas@arm.com, kernel-team@android.com, robh@kernel.org, Peter Zijlstra , Ingo Molnar , Alexander Shishkin , Jiri Olsa , Adrian Hunter , "Liang, Kan" , John Garry , Mike Leach , Leo Yan , Graham Woodward , Michael Petlan , Veronika Molnarova , Thomas Richter , Athira Rajeev , linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, irogers@google.com, yeoreum.yun@arm.com, mark.rutland@arm.com References: <20250108142904.401139-1-james.clark@linaro.org> <173652065683.3245172.11665292685923367751.b4-ty@kernel.org> Content-Language: en-US From: James Clark In-Reply-To: <173652065683.3245172.11665292685923367751.b4-ty@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/01/2025 4:22 pm, Will Deacon wrote: > On Wed, 08 Jan 2025 14:28:55 +0000, James Clark wrote: >> Discard mode (Armv8.6) is a way to enable SPE related PMU events without >> the overhead of recording any data. Add a format option, tests and docs >> for it. >> >> In theory we could make the driver drop calls to allocate the aux buffer >> when discard mode is enabled. This would give a small memory saving, >> but I think there is potential to interfere with any tools that don't >> expect this so I left the aux allocation untouched. Even old tools that >> don't know about discard mode will be able to use it because we publish >> the format option. Not allocating the aux buffer will have to be added >> to tools which I've done in Perf. >> >> [...] > > Applied driver and docs patches to will (for-next/perf), thanks! > > [1/5] perf: arm_spe: Add format option for discard mode > https://git.kernel.org/will/c/d28d95bc63cb > [2/5] perf docs: arm_spe: Document new discard mode > https://git.kernel.org/will/c/ba113ecad81a > > Cheers, Thanks Will. Arnaldo and Namhyung, are you ok to take the Perf changes now? Thanks James