From: Milian Wolff <milian.wolff@kdab.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-perf-users@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH] perf trace: Add support for printing call chains on sys_exit events.
Date: Sat, 09 Apr 2016 13:38:48 +0200 [thread overview]
Message-ID: <6162029.GvZZdvIglj@agathebauer> (raw)
In-Reply-To: <20160408175754.GB25165@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 863 bytes --]
On Freitag, 8. April 2016 14:57:54 CEST Arnaldo Carvalho de Melo wrote:
> Em Fri, Apr 08, 2016 at 01:34:15PM +0200, Milian Wolff escreveu:
> > Now, one can print the call chain for every encountered sys_exit
>
> > event, e.g.:
> You mixed up multiple changes in one single patch, I'll break it down
> while testing, and before pushing upstream.
Cool, thanks a lot Arnaldo. I'm also interested to see how you break it up,
apparently you handle this differently to the projects I work on so far. I
guess you want the "pass `FILE* fp` to `perf_evsel__print_ip`" as one chunk
and then actually using it in a second patch? Or are there even more steps you
can split this into?
Thanks
--
Milian Wolff | milian.wolff@kdab.com | Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5903 bytes --]
prev parent reply other threads:[~2016-04-09 11:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 11:34 [PATCH] perf trace: Add support for printing call chains on sys_exit events Milian Wolff
2016-04-08 17:57 ` Arnaldo Carvalho de Melo
2016-04-08 18:18 ` Arnaldo Carvalho de Melo
2016-04-09 11:44 ` Milian Wolff
2016-04-09 11:38 ` Milian Wolff [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6162029.GvZZdvIglj@agathebauer \
--to=milian.wolff@kdab.com \
--cc=acme@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).