From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC0ABC77B61 for ; Fri, 28 Apr 2023 15:35:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346036AbjD1Pfx (ORCPT ); Fri, 28 Apr 2023 11:35:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346470AbjD1Pfb (ORCPT ); Fri, 28 Apr 2023 11:35:31 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D0DD270C for ; Fri, 28 Apr 2023 08:34:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682696081; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i1I3bxKpOJ94ZKtbze6sl4BqpXL9nzWwU/RAx5bKUL4=; b=TQN0QZcYyJMDEh33ESJbF+b3tlF1o5gTCZZDLKkjQx+mnxIRS47oX650LWB7KFTGGNUVT0 09FRjfSX+x6RuR2vaWFdeibtwBELvmplAX+iWsPtz9Qu73omzkpSe/vDpJ2BiJXcnSVB0e pnoEidHowuzsWHr2M1aojGXXwbUtHsY= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-668-CZBOA6J7PP6kO7aqUTKrFQ-1; Fri, 28 Apr 2023 11:34:40 -0400 X-MC-Unique: CZBOA6J7PP6kO7aqUTKrFQ-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3f250e9e090so23293265e9.0 for ; Fri, 28 Apr 2023 08:34:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682696079; x=1685288079; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=i1I3bxKpOJ94ZKtbze6sl4BqpXL9nzWwU/RAx5bKUL4=; b=J8Xv8pHjOUk+INrsrOGflQZ+DlaIELZGe1vsME6KQ0d0PcH2A4MjQZNW2Q6+/oG6WR KICnAr6Vr+o0CUHI4JG3gTE5aeaHLibPtEw8UtvW96HtLiqpXPoGw7RrC3QjTPd+0TLV 2Vn+4qyC5upnsYIDWw8H/CdL9d8+LCqvOZKP1XXZa/leVQLBZ6JMHH77pPOfnCso43u4 jOlyAfwRU3FNVNhIMT/4vUn8Pw9P1MHZQEZqVSAAatQSuKIHJuwe3XRKYgiiFhSOrQnK oGK4hLsOjrDKSDhnAF6IMgZ4qqa7N/2bcWWsxbVoRgpU92fMAg9ZDSz1Ve19u87+23BJ yo0g== X-Gm-Message-State: AC+VfDzpKsIvi2NibA6lrPCSKPhIM5TqalrpuwGEobXlfrNMiXZMpB8m aWUZc1BjJcRjCh1vW5P5z7He3BQDUWvres6Iu58rqufJFFO/RVpOXuMt9280KwgIDNfBZ3fyrnl 2tXUt+oAuEr8o8jADilowIiXV606f0w== X-Received: by 2002:a7b:c408:0:b0:3f1:643e:3872 with SMTP id k8-20020a7bc408000000b003f1643e3872mr4562554wmi.2.1682696079111; Fri, 28 Apr 2023 08:34:39 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6Z+53Bygi3DB3brEFB63AzkuIarkk5LoZoC423ssWGGEMwrQKBO68KVGzpDBEWIV0h6613fA== X-Received: by 2002:a7b:c408:0:b0:3f1:643e:3872 with SMTP id k8-20020a7bc408000000b003f1643e3872mr4562508wmi.2.1682696078744; Fri, 28 Apr 2023 08:34:38 -0700 (PDT) Received: from ?IPV6:2003:cb:c726:9300:1711:356:6550:7502? (p200300cbc72693001711035665507502.dip0.t-ipconnect.de. [2003:cb:c726:9300:1711:356:6550:7502]) by smtp.gmail.com with ESMTPSA id g9-20020a05600c000900b003f0aa490336sm27987597wmc.26.2023.04.28.08.34.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Apr 2023 08:34:38 -0700 (PDT) Message-ID: <62ec50da-5f73-559c-c4b3-bde4eb215e08@redhat.com> Date: Fri, 28 Apr 2023 17:34:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v5] mm/gup: disallow GUP writing to file-backed mappings by default Content-Language: en-US To: Lorenzo Stoakes Cc: Jason Gunthorpe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Jens Axboe , Matthew Wilcox , Dennis Dalessandro , Leon Romanovsky , Christian Benvenuti , Nelson Escobar , Bernard Metzler , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Bjorn Topel , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Christian Brauner , Richard Cochran , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, Oleg Nesterov , John Hubbard , Jan Kara , "Kirill A . Shutemov" , Pavel Begunkov , Mika Penttila , David Howells , Christoph Hellwig References: <6b73e692c2929dc4613af711bdf92e2ec1956a66.1682638385.git.lstoakes@gmail.com> <094d2074-5b69-5d61-07f7-9f962014fa68@redhat.com> <400da248-a14e-46a4-420a-a3e075291085@redhat.com> <077c4b21-8806-455f-be98-d7052a584259@lucifer.local> From: David Hildenbrand Organization: Red Hat In-Reply-To: <077c4b21-8806-455f-be98-d7052a584259@lucifer.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On 28.04.23 17:33, Lorenzo Stoakes wrote: > On Fri, Apr 28, 2023 at 05:23:29PM +0200, David Hildenbrand wrote: >>>> >>>> Security is the primary case where we have historically closed uAPI >>>> items. >>> >>> As this patch >>> >>> 1) Does not tackle GUP-fast >>> 2) Does not take care of !FOLL_LONGTERM >>> >>> I am not convinced by the security argument in regard to this patch. >>> >>> >>> If we want to sells this as a security thing, we have to block it >>> *completely* and then CC stable. >> >> Regarding GUP-fast, to fix the issue there as well, I guess we could do >> something similar as I did in gup_must_unshare(): >> >> If we're in GUP-fast (no VMA), and want to pin a !anon page writable, >> fallback to ordinary GUP. IOW, if we don't know, better be safe. > > How do we determine it's non-anon in the first place? The check is on the > VMA. We could do it by following page tables down to folio and checking > folio->mapping for PAGE_MAPPING_ANON I suppose? PageAnon(page) can be called from GUP-fast after grabbing a reference. See gup_must_unshare(). > >> >> Of course, this would prevent hugetlb/shmem from getting pinned writable >> during gup-fast. Unless we're able to whitelist them somehow in there. > > We could degrade those to non-fast assuming not FOLL_FAST_ONLY. But it'd be > a pity. -- Thanks, David / dhildenb