From: Dan Williams <dan.j.williams@intel.com>
To: "Liang, Kan" <kan.liang@linux.intel.com>,
Ian Rogers <irogers@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
"Namhyung Kim" <namhyung@kernel.org>,
Zhengjun Xing <zhengjun.xing@linux.intel.com>,
<linux-perf-users@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
"Edward Baker" <edward.baker@intel.com>,
Dan Williams <dan.j.williams@intel.com>, <perry.taylor@intel.com>,
<caleb.biggers@intel.com>, <samantha.alt@intel.com>,
<weilin.wang@intel.com>
Subject: Re: [PATCH v2 8/9] perf metrics: Add has_optane literal
Date: Thu, 23 Mar 2023 13:43:49 -0700 [thread overview]
Message-ID: <641cba052d0f8_1b98bb294ab@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <44476adc-3797-504b-2b82-8ec670c691b6@linux.intel.com>
Liang, Kan wrote:
>
>
> On 2023-03-23 3:20 p.m., Ian Rogers wrote:
> > Add literal so that if optane memory isn't installed we can record
> > fewer events.
>
> I think we call it pmem (Persistent Memory) everywhere in the Linux
> code. Maybe we should use #has_pmem instead?
That makes sense especially because has_optane implies more precision
than the the check is performing. In general Optane is probably the
widest deployed NVDIMM type, but this check will succeed with battery
backed NVDIMMs and emulated PMEM in VMs which I think is perfectly ok
for making a default event record decision.
next prev parent reply other threads:[~2023-03-23 20:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 19:20 [PATCH v2 0/9] Update Intel events and make optane events dynamic Ian Rogers
2023-03-23 19:20 ` [PATCH v2 4/9] perf vendor events: Haswell v33 events Ian Rogers
2023-03-23 19:20 ` [PATCH v2 5/9] perf vendor events: Haswellx v27 events Ian Rogers
2023-03-23 19:20 ` [PATCH v2 6/9] perf vendor events: Jaketown v23 events Ian Rogers
2023-03-23 19:20 ` [PATCH v2 7/9] perf vendor events: Sandybridge v19 events Ian Rogers
2023-03-23 19:20 ` [PATCH v2 8/9] perf metrics: Add has_optane literal Ian Rogers
2023-03-23 20:31 ` Liang, Kan
2023-03-23 20:43 ` Dan Williams [this message]
2023-03-24 7:15 ` Ian Rogers
2023-03-23 19:20 ` [PATCH v2 9/9] perf vendor events: Update metrics to detect optane memory at runtime Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=641cba052d0f8_1b98bb294ab@dwillia2-xfh.jf.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=caleb.biggers@intel.com \
--cc=edward.baker@intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=perry.taylor@intel.com \
--cc=peterz@infradead.org \
--cc=samantha.alt@intel.com \
--cc=weilin.wang@intel.com \
--cc=zhengjun.xing@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).