From: "Liang, Kan" <kan.liang@linux.intel.com>
To: Ian Rogers <irogers@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Weilin Wang <weilin.wang@intel.com>, Song Liu <song@kernel.org>
Subject: Re: [PATCH v1] perf vendor events: SKX, CLX, SNR uncore cache event fixes
Date: Mon, 12 Aug 2024 10:26:36 -0400 [thread overview]
Message-ID: <6947c956-2ba6-4fec-8d8b-79c5bbd3d725@linux.intel.com> (raw)
In-Reply-To: <20240811042004.421869-1-irogers@google.com>
On 2024-08-11 12:20 a.m., Ian Rogers wrote:
> Cache home agent (CHA) events were setting the low rather than high
> config1 bits. SNR was using CLX CHA events, however its CHA is similar
> to ICX so remove the events.
>
> Incorporate the updates in:
> https://github.com/intel/perfmon/pull/215
> https://github.com/intel/perfmon/pull/216
>
> Co-authored-by: Weilin Wang <weilin.wang@intel.com>
> Reported-by: Song Liu <song@kernel.org>
> Closes: https://lore.kernel.org/linux-perf-users/CAPhsuW4nem9XZP+b=sJJ7kqXG-cafz0djZf51HsgjCiwkGBA+A@mail.gmail.com/
> Fixes: 4cc49942444e ("perf vendor events: Update cascadelakex events/metrics")
> Signed-off-by: Ian Rogers <irogers@google.com>
Thanks Ian and Weilin
Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
Thanks,
Kan
> ---
> .../arch/x86/cascadelakex/uncore-cache.json | 60 +++++++++----------
> .../arch/x86/skylakex/uncore-cache.json | 60 +++++++++----------
> .../arch/x86/snowridgex/uncore-cache.json | 57 ------------------
> 3 files changed, 60 insertions(+), 117 deletions(-)
>
> diff --git a/tools/perf/pmu-events/arch/x86/cascadelakex/uncore-cache.json b/tools/perf/pmu-events/arch/x86/cascadelakex/uncore-cache.json
> index c9596e18ec09..6347eba48810 100644
> --- a/tools/perf/pmu-events/arch/x86/cascadelakex/uncore-cache.json
> +++ b/tools/perf/pmu-events/arch/x86/cascadelakex/uncore-cache.json
> @@ -4577,7 +4577,7 @@
> "Counter": "0,1,2,3",
> "EventCode": "0x35",
> "EventName": "UNC_CHA_TOR_INSERTS.IA_HIT_CRD",
> - "Filter": "config1=0x40233",
> + "Filter": "config1=0x4023300000000",
> "PerPkg": "1",
> "PublicDescription": "TOR Inserts : CRds issued by iA Cores that Hit the LLC : Counts the number of entries successfully inserted into the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> "UMask": "0x11",
> @@ -4588,7 +4588,7 @@
> "Counter": "0,1,2,3",
> "EventCode": "0x35",
> "EventName": "UNC_CHA_TOR_INSERTS.IA_HIT_DRD",
> - "Filter": "config1=0x40433",
> + "Filter": "config1=0x4043300000000",
> "PerPkg": "1",
> "PublicDescription": "TOR Inserts : DRds issued by iA Cores that Hit the LLC : Counts the number of entries successfully inserted into the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> "UMask": "0x11",
> @@ -4599,7 +4599,7 @@
> "Counter": "0,1,2,3",
> "EventCode": "0x35",
> "EventName": "UNC_CHA_TOR_INSERTS.IA_HIT_LlcPrefCRD",
> - "Filter": "config1=0x4b233",
> + "Filter": "config1=0x4b23300000000",
> "PerPkg": "1",
> "UMask": "0x11",
> "Unit": "CHA"
> @@ -4609,7 +4609,7 @@
> "Counter": "0,1,2,3",
> "EventCode": "0x35",
> "EventName": "UNC_CHA_TOR_INSERTS.IA_HIT_LlcPrefDRD",
> - "Filter": "config1=0x4b433",
> + "Filter": "config1=0x4b43300000000",
> "PerPkg": "1",
> "UMask": "0x11",
> "Unit": "CHA"
> @@ -4619,7 +4619,7 @@
> "Counter": "0,1,2,3",
> "EventCode": "0x35",
> "EventName": "UNC_CHA_TOR_INSERTS.IA_HIT_LlcPrefRFO",
> - "Filter": "config1=0x4b033",
> + "Filter": "config1=0x4b03300000000",
> "PerPkg": "1",
> "PublicDescription": "TOR Inserts : LLCPrefRFO issued by iA Cores that hit the LLC : Counts the number of entries successfully inserted into the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> "UMask": "0x11",
> @@ -4630,7 +4630,7 @@
> "Counter": "0,1,2,3",
> "EventCode": "0x35",
> "EventName": "UNC_CHA_TOR_INSERTS.IA_HIT_RFO",
> - "Filter": "config1=0x40033",
> + "Filter": "config1=0x4003300000000",
> "PerPkg": "1",
> "PublicDescription": "TOR Inserts : RFOs issued by iA Cores that Hit the LLC : Counts the number of entries successfully inserted into the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> "UMask": "0x11",
> @@ -4651,7 +4651,7 @@
> "Counter": "0,1,2,3",
> "EventCode": "0x35",
> "EventName": "UNC_CHA_TOR_INSERTS.IA_MISS_CRD",
> - "Filter": "config1=0x40233",
> + "Filter": "config1=0x4023300000000",
> "PerPkg": "1",
> "PublicDescription": "TOR Inserts : CRds issued by iA Cores that Missed the LLC : Counts the number of entries successfully inserted into the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> "UMask": "0x21",
> @@ -4662,7 +4662,7 @@
> "Counter": "0,1,2,3",
> "EventCode": "0x35",
> "EventName": "UNC_CHA_TOR_INSERTS.IA_MISS_DRD",
> - "Filter": "config1=0x40433",
> + "Filter": "config1=0x4043300000000",
> "PerPkg": "1",
> "PublicDescription": "TOR Inserts : DRds issued by iA Cores that Missed the LLC : Counts the number of entries successfully inserted into the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> "UMask": "0x21",
> @@ -4673,7 +4673,7 @@
> "Counter": "0,1,2,3",
> "EventCode": "0x35",
> "EventName": "UNC_CHA_TOR_INSERTS.IA_MISS_LlcPrefCRD",
> - "Filter": "config1=0x4b233",
> + "Filter": "config1=0x4b23300000000",
> "PerPkg": "1",
> "UMask": "0x21",
> "Unit": "CHA"
> @@ -4683,7 +4683,7 @@
> "Counter": "0,1,2,3",
> "EventCode": "0x35",
> "EventName": "UNC_CHA_TOR_INSERTS.IA_MISS_LlcPrefDRD",
> - "Filter": "config1=0x4b433",
> + "Filter": "config1=0x4b43300000000",
> "PerPkg": "1",
> "UMask": "0x21",
> "Unit": "CHA"
> @@ -4693,7 +4693,7 @@
> "Counter": "0,1,2,3",
> "EventCode": "0x35",
> "EventName": "UNC_CHA_TOR_INSERTS.IA_MISS_LlcPrefRFO",
> - "Filter": "config1=0x4b033",
> + "Filter": "config1=0x4b03300000000",
> "PerPkg": "1",
> "PublicDescription": "TOR Inserts : LLCPrefRFO issued by iA Cores that missed the LLC : Counts the number of entries successfully inserted into the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> "UMask": "0x21",
> @@ -4704,7 +4704,7 @@
> "Counter": "0,1,2,3",
> "EventCode": "0x35",
> "EventName": "UNC_CHA_TOR_INSERTS.IA_MISS_RFO",
> - "Filter": "config1=0x40033",
> + "Filter": "config1=0x4003300000000",
> "PerPkg": "1",
> "PublicDescription": "TOR Inserts : RFOs issued by iA Cores that Missed the LLC : Counts the number of entries successfully inserted into the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> "UMask": "0x21",
> @@ -4747,7 +4747,7 @@
> "EventCode": "0x35",
> "EventName": "UNC_CHA_TOR_INSERTS.IO_MISS_ITOM",
> "Experimental": "1",
> - "Filter": "config1=0x49033",
> + "Filter": "config1=0x4903300000000",
> "PerPkg": "1",
> "PublicDescription": "Counts the number of entries successfully inserted into the TOR that are generated from local IO ItoM requests that miss the LLC. An ItoM request is used by IIO to request a data write without first reading the data for ownership.",
> "UMask": "0x24",
> @@ -4759,7 +4759,7 @@
> "EventCode": "0x35",
> "EventName": "UNC_CHA_TOR_INSERTS.IO_MISS_RDCUR",
> "Experimental": "1",
> - "Filter": "config1=0x43C33",
> + "Filter": "config1=0x43c3300000000",
> "PerPkg": "1",
> "PublicDescription": "Counts the number of entries successfully inserted into the TOR that are generated from local IO RdCur requests and miss the LLC. A RdCur request is used by IIO to read data without changing state.",
> "UMask": "0x24",
> @@ -4771,7 +4771,7 @@
> "EventCode": "0x35",
> "EventName": "UNC_CHA_TOR_INSERTS.IO_MISS_RFO",
> "Experimental": "1",
> - "Filter": "config1=0x40033",
> + "Filter": "config1=0x4003300000000",
> "PerPkg": "1",
> "PublicDescription": "Counts the number of entries successfully inserted into the TOR that are generated from local IO RFO requests that miss the LLC. A read for ownership (RFO) requests a cache line to be cached in E state with the intent to modify.",
> "UMask": "0x24",
> @@ -4999,7 +4999,7 @@
> "Counter": "0",
> "EventCode": "0x36",
> "EventName": "UNC_CHA_TOR_OCCUPANCY.IA_HIT_CRD",
> - "Filter": "config1=0x40233",
> + "Filter": "config1=0x4023300000000",
> "PerPkg": "1",
> "PublicDescription": "TOR Occupancy : CRds issued by iA Cores that Hit the LLC : For each cycle, this event accumulates the number of valid entries in the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> "UMask": "0x11",
> @@ -5010,7 +5010,7 @@
> "Counter": "0",
> "EventCode": "0x36",
> "EventName": "UNC_CHA_TOR_OCCUPANCY.IA_HIT_DRD",
> - "Filter": "config1=0x40433",
> + "Filter": "config1=0x4043300000000",
> "PerPkg": "1",
> "PublicDescription": "TOR Occupancy : DRds issued by iA Cores that Hit the LLC : For each cycle, this event accumulates the number of valid entries in the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> "UMask": "0x11",
> @@ -5021,7 +5021,7 @@
> "Counter": "0",
> "EventCode": "0x36",
> "EventName": "UNC_CHA_TOR_OCCUPANCY.IA_HIT_LlcPrefCRD",
> - "Filter": "config1=0x4b233",
> + "Filter": "config1=0x4b23300000000",
> "PerPkg": "1",
> "UMask": "0x11",
> "Unit": "CHA"
> @@ -5031,7 +5031,7 @@
> "Counter": "0",
> "EventCode": "0x36",
> "EventName": "UNC_CHA_TOR_OCCUPANCY.IA_HIT_LlcPrefDRD",
> - "Filter": "config1=0x4b433",
> + "Filter": "config1=0x4b43300000000",
> "PerPkg": "1",
> "UMask": "0x11",
> "Unit": "CHA"
> @@ -5041,7 +5041,7 @@
> "Counter": "0",
> "EventCode": "0x36",
> "EventName": "UNC_CHA_TOR_OCCUPANCY.IA_HIT_LlcPrefRFO",
> - "Filter": "config1=0x4b033",
> + "Filter": "config1=0x4b03300000000",
> "PerPkg": "1",
> "PublicDescription": "TOR Occupancy : LLCPrefRFO issued by iA Cores that hit the LLC : For each cycle, this event accumulates the number of valid entries in the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> "UMask": "0x11",
> @@ -5052,7 +5052,7 @@
> "Counter": "0",
> "EventCode": "0x36",
> "EventName": "UNC_CHA_TOR_OCCUPANCY.IA_HIT_RFO",
> - "Filter": "config1=0x40033",
> + "Filter": "config1=0x4003300000000",
> "PerPkg": "1",
> "PublicDescription": "TOR Occupancy : RFOs issued by iA Cores that Hit the LLC : For each cycle, this event accumulates the number of valid entries in the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> "UMask": "0x11",
> @@ -5073,7 +5073,7 @@
> "Counter": "0",
> "EventCode": "0x36",
> "EventName": "UNC_CHA_TOR_OCCUPANCY.IA_MISS_CRD",
> - "Filter": "config1=0x40233",
> + "Filter": "config1=0x4023300000000",
> "PerPkg": "1",
> "PublicDescription": "TOR Occupancy : CRds issued by iA Cores that Missed the LLC : For each cycle, this event accumulates the number of valid entries in the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> "UMask": "0x21",
> @@ -5084,7 +5084,7 @@
> "Counter": "0",
> "EventCode": "0x36",
> "EventName": "UNC_CHA_TOR_OCCUPANCY.IA_MISS_DRD",
> - "Filter": "config1=0x40433",
> + "Filter": "config1=0x4043300000000",
> "PerPkg": "1",
> "PublicDescription": "TOR Occupancy : DRds issued by iA Cores that Missed the LLC : For each cycle, this event accumulates the number of valid entries in the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> "UMask": "0x21",
> @@ -5095,7 +5095,7 @@
> "Counter": "0",
> "EventCode": "0x36",
> "EventName": "UNC_CHA_TOR_OCCUPANCY.IA_MISS_LlcPrefCRD",
> - "Filter": "config1=0x4b233",
> + "Filter": "config1=0x4b23300000000",
> "PerPkg": "1",
> "UMask": "0x21",
> "Unit": "CHA"
> @@ -5105,7 +5105,7 @@
> "Counter": "0",
> "EventCode": "0x36",
> "EventName": "UNC_CHA_TOR_OCCUPANCY.IA_MISS_LlcPrefDRD",
> - "Filter": "config1=0x4b433",
> + "Filter": "config1=0x4b43300000000",
> "PerPkg": "1",
> "UMask": "0x21",
> "Unit": "CHA"
> @@ -5115,7 +5115,7 @@
> "Counter": "0",
> "EventCode": "0x36",
> "EventName": "UNC_CHA_TOR_OCCUPANCY.IA_MISS_LlcPrefRFO",
> - "Filter": "config1=0x4b033",
> + "Filter": "config1=0x4b03300000000",
> "PerPkg": "1",
> "PublicDescription": "TOR Occupancy : LLCPrefRFO issued by iA Cores that missed the LLC : For each cycle, this event accumulates the number of valid entries in the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> "UMask": "0x21",
> @@ -5126,7 +5126,7 @@
> "Counter": "0",
> "EventCode": "0x36",
> "EventName": "UNC_CHA_TOR_OCCUPANCY.IA_MISS_RFO",
> - "Filter": "config1=0x40033",
> + "Filter": "config1=0x4003300000000",
> "PerPkg": "1",
> "PublicDescription": "TOR Occupancy : RFOs issued by iA Cores that Missed the LLC : For each cycle, this event accumulates the number of valid entries in the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> "UMask": "0x21",
> @@ -5171,7 +5171,7 @@
> "EventCode": "0x36",
> "EventName": "UNC_CHA_TOR_OCCUPANCY.IO_MISS_ITOM",
> "Experimental": "1",
> - "Filter": "config1=0x49033",
> + "Filter": "config1=0x4903300000000",
> "PerPkg": "1",
> "PublicDescription": "For each cycle, this event accumulates the number of valid entries in the TOR that are generated from local IO ItoM requests that miss the LLC. An ItoM is used by IIO to request a data write without first reading the data for ownership.",
> "UMask": "0x24",
> @@ -5183,7 +5183,7 @@
> "EventCode": "0x36",
> "EventName": "UNC_CHA_TOR_OCCUPANCY.IO_MISS_RDCUR",
> "Experimental": "1",
> - "Filter": "config1=0x43C33",
> + "Filter": "config1=0x43c3300000000",
> "PerPkg": "1",
> "PublicDescription": "For each cycle, this event accumulates the number of valid entries in the TOR that are generated from local IO RdCur requests that miss the LLC. A RdCur request is used by IIO to read data without changing state.",
> "UMask": "0x24",
> @@ -5195,7 +5195,7 @@
> "EventCode": "0x36",
> "EventName": "UNC_CHA_TOR_OCCUPANCY.IO_MISS_RFO",
> "Experimental": "1",
> - "Filter": "config1=0x40033",
> + "Filter": "config1=0x4003300000000",
> "PerPkg": "1",
> "PublicDescription": "For each cycle, this event accumulates the number of valid entries in the TOR that are generated from local IO RFO requests that miss the LLC. A read for ownership (RFO) requests data to be cached in E state with the intent to modify.",
> "UMask": "0x24",
> diff --git a/tools/perf/pmu-events/arch/x86/skylakex/uncore-cache.json b/tools/perf/pmu-events/arch/x86/skylakex/uncore-cache.json
> index da46a3aeb58c..4fc818626491 100644
> --- a/tools/perf/pmu-events/arch/x86/skylakex/uncore-cache.json
> +++ b/tools/perf/pmu-events/arch/x86/skylakex/uncore-cache.json
> @@ -4454,7 +4454,7 @@
> "Counter": "0,1,2,3",
> "EventCode": "0x35",
> "EventName": "UNC_CHA_TOR_INSERTS.IA_HIT_CRD",
> - "Filter": "config1=0x40233",
> + "Filter": "config1=0x4023300000000",
> "PerPkg": "1",
> "PublicDescription": "TOR Inserts : CRds issued by iA Cores that Hit the LLC : Counts the number of entries successfully inserted into the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> "UMask": "0x11",
> @@ -4465,7 +4465,7 @@
> "Counter": "0,1,2,3",
> "EventCode": "0x35",
> "EventName": "UNC_CHA_TOR_INSERTS.IA_HIT_DRD",
> - "Filter": "config1=0x40433",
> + "Filter": "config1=0x4043300000000",
> "PerPkg": "1",
> "PublicDescription": "TOR Inserts : DRds issued by iA Cores that Hit the LLC : Counts the number of entries successfully inserted into the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> "UMask": "0x11",
> @@ -4476,7 +4476,7 @@
> "Counter": "0,1,2,3",
> "EventCode": "0x35",
> "EventName": "UNC_CHA_TOR_INSERTS.IA_HIT_LlcPrefCRD",
> - "Filter": "config1=0x4b233",
> + "Filter": "config1=0x4b23300000000",
> "PerPkg": "1",
> "UMask": "0x11",
> "Unit": "CHA"
> @@ -4486,7 +4486,7 @@
> "Counter": "0,1,2,3",
> "EventCode": "0x35",
> "EventName": "UNC_CHA_TOR_INSERTS.IA_HIT_LlcPrefDRD",
> - "Filter": "config1=0x4b433",
> + "Filter": "config1=0x4b43300000000",
> "PerPkg": "1",
> "UMask": "0x11",
> "Unit": "CHA"
> @@ -4496,7 +4496,7 @@
> "Counter": "0,1,2,3",
> "EventCode": "0x35",
> "EventName": "UNC_CHA_TOR_INSERTS.IA_HIT_LlcPrefRFO",
> - "Filter": "config1=0x4b033",
> + "Filter": "config1=0x4b03300000000",
> "PerPkg": "1",
> "PublicDescription": "TOR Inserts : LLCPrefRFO issued by iA Cores that hit the LLC : Counts the number of entries successfully inserted into the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> "UMask": "0x11",
> @@ -4507,7 +4507,7 @@
> "Counter": "0,1,2,3",
> "EventCode": "0x35",
> "EventName": "UNC_CHA_TOR_INSERTS.IA_HIT_RFO",
> - "Filter": "config1=0x40033",
> + "Filter": "config1=0x4003300000000",
> "PerPkg": "1",
> "PublicDescription": "TOR Inserts : RFOs issued by iA Cores that Hit the LLC : Counts the number of entries successfully inserted into the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> "UMask": "0x11",
> @@ -4528,7 +4528,7 @@
> "Counter": "0,1,2,3",
> "EventCode": "0x35",
> "EventName": "UNC_CHA_TOR_INSERTS.IA_MISS_CRD",
> - "Filter": "config1=0x40233",
> + "Filter": "config1=0x4023300000000",
> "PerPkg": "1",
> "PublicDescription": "TOR Inserts : CRds issued by iA Cores that Missed the LLC : Counts the number of entries successfully inserted into the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> "UMask": "0x21",
> @@ -4539,7 +4539,7 @@
> "Counter": "0,1,2,3",
> "EventCode": "0x35",
> "EventName": "UNC_CHA_TOR_INSERTS.IA_MISS_DRD",
> - "Filter": "config1=0x40433",
> + "Filter": "config1=0x4043300000000",
> "PerPkg": "1",
> "PublicDescription": "TOR Inserts : DRds issued by iA Cores that Missed the LLC : Counts the number of entries successfully inserted into the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> "UMask": "0x21",
> @@ -4550,7 +4550,7 @@
> "Counter": "0,1,2,3",
> "EventCode": "0x35",
> "EventName": "UNC_CHA_TOR_INSERTS.IA_MISS_LlcPrefCRD",
> - "Filter": "config1=0x4b233",
> + "Filter": "config1=0x4b23300000000",
> "PerPkg": "1",
> "UMask": "0x21",
> "Unit": "CHA"
> @@ -4560,7 +4560,7 @@
> "Counter": "0,1,2,3",
> "EventCode": "0x35",
> "EventName": "UNC_CHA_TOR_INSERTS.IA_MISS_LlcPrefDRD",
> - "Filter": "config1=0x4b433",
> + "Filter": "config1=0x4b43300000000",
> "PerPkg": "1",
> "UMask": "0x21",
> "Unit": "CHA"
> @@ -4570,7 +4570,7 @@
> "Counter": "0,1,2,3",
> "EventCode": "0x35",
> "EventName": "UNC_CHA_TOR_INSERTS.IA_MISS_LlcPrefRFO",
> - "Filter": "config1=0x4b033",
> + "Filter": "config1=0x4b03300000000",
> "PerPkg": "1",
> "PublicDescription": "TOR Inserts : LLCPrefRFO issued by iA Cores that missed the LLC : Counts the number of entries successfully inserted into the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> "UMask": "0x21",
> @@ -4581,7 +4581,7 @@
> "Counter": "0,1,2,3",
> "EventCode": "0x35",
> "EventName": "UNC_CHA_TOR_INSERTS.IA_MISS_RFO",
> - "Filter": "config1=0x40033",
> + "Filter": "config1=0x4003300000000",
> "PerPkg": "1",
> "PublicDescription": "TOR Inserts : RFOs issued by iA Cores that Missed the LLC : Counts the number of entries successfully inserted into the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> "UMask": "0x21",
> @@ -4624,7 +4624,7 @@
> "EventCode": "0x35",
> "EventName": "UNC_CHA_TOR_INSERTS.IO_MISS_ITOM",
> "Experimental": "1",
> - "Filter": "config1=0x49033",
> + "Filter": "config1=0x4903300000000",
> "PerPkg": "1",
> "PublicDescription": "Counts the number of entries successfully inserted into the TOR that are generated from local IO ItoM requests that miss the LLC. An ItoM request is used by IIO to request a data write without first reading the data for ownership.",
> "UMask": "0x24",
> @@ -4636,7 +4636,7 @@
> "EventCode": "0x35",
> "EventName": "UNC_CHA_TOR_INSERTS.IO_MISS_RDCUR",
> "Experimental": "1",
> - "Filter": "config1=0x43C33",
> + "Filter": "config1=0x43c3300000000",
> "PerPkg": "1",
> "PublicDescription": "Counts the number of entries successfully inserted into the TOR that are generated from local IO RdCur requests and miss the LLC. A RdCur request is used by IIO to read data without changing state.",
> "UMask": "0x24",
> @@ -4648,7 +4648,7 @@
> "EventCode": "0x35",
> "EventName": "UNC_CHA_TOR_INSERTS.IO_MISS_RFO",
> "Experimental": "1",
> - "Filter": "config1=0x40033",
> + "Filter": "config1=0x4003300000000",
> "PerPkg": "1",
> "PublicDescription": "Counts the number of entries successfully inserted into the TOR that are generated from local IO RFO requests that miss the LLC. A read for ownership (RFO) requests a cache line to be cached in E state with the intent to modify.",
> "UMask": "0x24",
> @@ -4865,7 +4865,7 @@
> "Counter": "0",
> "EventCode": "0x36",
> "EventName": "UNC_CHA_TOR_OCCUPANCY.IA_HIT_CRD",
> - "Filter": "config1=0x40233",
> + "Filter": "config1=0x4023300000000",
> "PerPkg": "1",
> "PublicDescription": "TOR Occupancy : CRds issued by iA Cores that Hit the LLC : For each cycle, this event accumulates the number of valid entries in the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> "UMask": "0x11",
> @@ -4876,7 +4876,7 @@
> "Counter": "0",
> "EventCode": "0x36",
> "EventName": "UNC_CHA_TOR_OCCUPANCY.IA_HIT_DRD",
> - "Filter": "config1=0x40433",
> + "Filter": "config1=0x4043300000000",
> "PerPkg": "1",
> "PublicDescription": "TOR Occupancy : DRds issued by iA Cores that Hit the LLC : For each cycle, this event accumulates the number of valid entries in the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> "UMask": "0x11",
> @@ -4887,7 +4887,7 @@
> "Counter": "0",
> "EventCode": "0x36",
> "EventName": "UNC_CHA_TOR_OCCUPANCY.IA_HIT_LlcPrefCRD",
> - "Filter": "config1=0x4b233",
> + "Filter": "config1=0x4b23300000000",
> "PerPkg": "1",
> "UMask": "0x11",
> "Unit": "CHA"
> @@ -4897,7 +4897,7 @@
> "Counter": "0",
> "EventCode": "0x36",
> "EventName": "UNC_CHA_TOR_OCCUPANCY.IA_HIT_LlcPrefDRD",
> - "Filter": "config1=0x4b433",
> + "Filter": "config1=0x4b43300000000",
> "PerPkg": "1",
> "UMask": "0x11",
> "Unit": "CHA"
> @@ -4907,7 +4907,7 @@
> "Counter": "0",
> "EventCode": "0x36",
> "EventName": "UNC_CHA_TOR_OCCUPANCY.IA_HIT_LlcPrefRFO",
> - "Filter": "config1=0x4b033",
> + "Filter": "config1=0x4b03300000000",
> "PerPkg": "1",
> "PublicDescription": "TOR Occupancy : LLCPrefRFO issued by iA Cores that hit the LLC : For each cycle, this event accumulates the number of valid entries in the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> "UMask": "0x11",
> @@ -4918,7 +4918,7 @@
> "Counter": "0",
> "EventCode": "0x36",
> "EventName": "UNC_CHA_TOR_OCCUPANCY.IA_HIT_RFO",
> - "Filter": "config1=0x40033",
> + "Filter": "config1=0x4003300000000",
> "PerPkg": "1",
> "PublicDescription": "TOR Occupancy : RFOs issued by iA Cores that Hit the LLC : For each cycle, this event accumulates the number of valid entries in the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> "UMask": "0x11",
> @@ -4939,7 +4939,7 @@
> "Counter": "0",
> "EventCode": "0x36",
> "EventName": "UNC_CHA_TOR_OCCUPANCY.IA_MISS_CRD",
> - "Filter": "config1=0x40233",
> + "Filter": "config1=0x4023300000000",
> "PerPkg": "1",
> "PublicDescription": "TOR Occupancy : CRds issued by iA Cores that Missed the LLC : For each cycle, this event accumulates the number of valid entries in the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> "UMask": "0x21",
> @@ -4950,7 +4950,7 @@
> "Counter": "0",
> "EventCode": "0x36",
> "EventName": "UNC_CHA_TOR_OCCUPANCY.IA_MISS_DRD",
> - "Filter": "config1=0x40433",
> + "Filter": "config1=0x4043300000000",
> "PerPkg": "1",
> "PublicDescription": "TOR Occupancy : DRds issued by iA Cores that Missed the LLC : For each cycle, this event accumulates the number of valid entries in the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> "UMask": "0x21",
> @@ -4961,7 +4961,7 @@
> "Counter": "0",
> "EventCode": "0x36",
> "EventName": "UNC_CHA_TOR_OCCUPANCY.IA_MISS_LlcPrefCRD",
> - "Filter": "config1=0x4b233",
> + "Filter": "config1=0x4b23300000000",
> "PerPkg": "1",
> "UMask": "0x21",
> "Unit": "CHA"
> @@ -4971,7 +4971,7 @@
> "Counter": "0",
> "EventCode": "0x36",
> "EventName": "UNC_CHA_TOR_OCCUPANCY.IA_MISS_LlcPrefDRD",
> - "Filter": "config1=0x4b433",
> + "Filter": "config1=0x4b43300000000",
> "PerPkg": "1",
> "UMask": "0x21",
> "Unit": "CHA"
> @@ -4981,7 +4981,7 @@
> "Counter": "0",
> "EventCode": "0x36",
> "EventName": "UNC_CHA_TOR_OCCUPANCY.IA_MISS_LlcPrefRFO",
> - "Filter": "config1=0x4b033",
> + "Filter": "config1=0x4b03300000000",
> "PerPkg": "1",
> "PublicDescription": "TOR Occupancy : LLCPrefRFO issued by iA Cores that missed the LLC : For each cycle, this event accumulates the number of valid entries in the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> "UMask": "0x21",
> @@ -4992,7 +4992,7 @@
> "Counter": "0",
> "EventCode": "0x36",
> "EventName": "UNC_CHA_TOR_OCCUPANCY.IA_MISS_RFO",
> - "Filter": "config1=0x40033",
> + "Filter": "config1=0x4003300000000",
> "PerPkg": "1",
> "PublicDescription": "TOR Occupancy : RFOs issued by iA Cores that Missed the LLC : For each cycle, this event accumulates the number of valid entries in the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> "UMask": "0x21",
> @@ -5037,7 +5037,7 @@
> "EventCode": "0x36",
> "EventName": "UNC_CHA_TOR_OCCUPANCY.IO_MISS_ITOM",
> "Experimental": "1",
> - "Filter": "config1=0x49033",
> + "Filter": "config1=0x4903300000000",
> "PerPkg": "1",
> "PublicDescription": "For each cycle, this event accumulates the number of valid entries in the TOR that are generated from local IO ItoM requests that miss the LLC. An ItoM is used by IIO to request a data write without first reading the data for ownership.",
> "UMask": "0x24",
> @@ -5049,7 +5049,7 @@
> "EventCode": "0x36",
> "EventName": "UNC_CHA_TOR_OCCUPANCY.IO_MISS_RDCUR",
> "Experimental": "1",
> - "Filter": "config1=0x43C33",
> + "Filter": "config1=0x43c3300000000",
> "PerPkg": "1",
> "PublicDescription": "For each cycle, this event accumulates the number of valid entries in the TOR that are generated from local IO RdCur requests that miss the LLC. A RdCur request is used by IIO to read data without changing state.",
> "UMask": "0x24",
> @@ -5061,7 +5061,7 @@
> "EventCode": "0x36",
> "EventName": "UNC_CHA_TOR_OCCUPANCY.IO_MISS_RFO",
> "Experimental": "1",
> - "Filter": "config1=0x40033",
> + "Filter": "config1=0x4003300000000",
> "PerPkg": "1",
> "PublicDescription": "For each cycle, this event accumulates the number of valid entries in the TOR that are generated from local IO RFO requests that miss the LLC. A read for ownership (RFO) requests data to be cached in E state with the intent to modify.",
> "UMask": "0x24",
> diff --git a/tools/perf/pmu-events/arch/x86/snowridgex/uncore-cache.json b/tools/perf/pmu-events/arch/x86/snowridgex/uncore-cache.json
> index 7551fb91a9d7..a81776deb2e6 100644
> --- a/tools/perf/pmu-events/arch/x86/snowridgex/uncore-cache.json
> +++ b/tools/perf/pmu-events/arch/x86/snowridgex/uncore-cache.json
> @@ -1,61 +1,4 @@
> [
> - {
> - "BriefDescription": "MMIO reads. Derived from unc_cha_tor_inserts.ia_miss",
> - "Counter": "0,1,2,3",
> - "EventCode": "0x35",
> - "EventName": "LLC_MISSES.MMIO_READ",
> - "Filter": "config1=0x40040e33",
> - "PerPkg": "1",
> - "PublicDescription": "TOR Inserts : All requests from iA Cores that Missed the LLC : Counts the number of entries successfully inserted into the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> - "UMask": "0xc001fe01",
> - "Unit": "CHA"
> - },
> - {
> - "BriefDescription": "MMIO writes. Derived from unc_cha_tor_inserts.ia_miss",
> - "Counter": "0,1,2,3",
> - "EventCode": "0x35",
> - "EventName": "LLC_MISSES.MMIO_WRITE",
> - "Filter": "config1=0x40041e33",
> - "PerPkg": "1",
> - "PublicDescription": "TOR Inserts : All requests from iA Cores that Missed the LLC : Counts the number of entries successfully inserted into the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> - "UMask": "0xc001fe01",
> - "Unit": "CHA"
> - },
> - {
> - "BriefDescription": "LLC misses - Uncacheable reads (from cpu) . Derived from unc_cha_tor_inserts.ia_miss",
> - "Counter": "0,1,2,3",
> - "EventCode": "0x35",
> - "EventName": "LLC_MISSES.UNCACHEABLE",
> - "Filter": "config1=0x40e33",
> - "PerPkg": "1",
> - "PublicDescription": "TOR Inserts : All requests from iA Cores that Missed the LLC : Counts the number of entries successfully inserted into the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> - "UMask": "0xc001fe01",
> - "Unit": "CHA"
> - },
> - {
> - "BriefDescription": "Streaming stores (full cache line). Derived from unc_cha_tor_inserts.ia_miss",
> - "Counter": "0,1,2,3",
> - "EventCode": "0x35",
> - "EventName": "LLC_REFERENCES.STREAMING_FULL",
> - "Filter": "config1=0x41833",
> - "PerPkg": "1",
> - "PublicDescription": "TOR Inserts : All requests from iA Cores that Missed the LLC : Counts the number of entries successfully inserted into the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> - "ScaleUnit": "64Bytes",
> - "UMask": "0xc001fe01",
> - "Unit": "CHA"
> - },
> - {
> - "BriefDescription": "Streaming stores (partial cache line). Derived from unc_cha_tor_inserts.ia_miss",
> - "Counter": "0,1,2,3",
> - "EventCode": "0x35",
> - "EventName": "LLC_REFERENCES.STREAMING_PARTIAL",
> - "Filter": "config1=0x41a33",
> - "PerPkg": "1",
> - "PublicDescription": "TOR Inserts : All requests from iA Cores that Missed the LLC : Counts the number of entries successfully inserted into the TOR that match qualifications specified by the subevent. Does not include addressless requests such as locks and interrupts.",
> - "ScaleUnit": "64Bytes",
> - "UMask": "0xc001fe01",
> - "Unit": "CHA"
> - },
> {
> "BriefDescription": "CMS Agent0 AD Credits Acquired : For Transgress 0",
> "Counter": "0,1,2,3",
next prev parent reply other threads:[~2024-08-12 14:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-11 4:20 [PATCH v1] perf vendor events: SKX, CLX, SNR uncore cache event fixes Ian Rogers
2024-08-12 14:26 ` Liang, Kan [this message]
2024-08-12 20:11 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6947c956-2ba6-4fec-8d8b-79c5bbd3d725@linux.intel.com \
--to=kan.liang@linux.intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=song@kernel.org \
--cc=weilin.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox