From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2168AC77B7F for ; Tue, 16 May 2023 21:42:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229877AbjEPVmH (ORCPT ); Tue, 16 May 2023 17:42:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229873AbjEPVmG (ORCPT ); Tue, 16 May 2023 17:42:06 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E00B55FF1; Tue, 16 May 2023 14:42:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684273323; x=1715809323; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=r7TKuMl8TXg5daYTaBJSfljSsUGfrwi+T/80mD6+RxE=; b=d9W/sYwbdUF4KK9MdC94EOiv/lMl0R5qk0gL7Hjn8fTd8gsA7ow3Egn9 rCAaysnFeoZ6cVVNfe9jAGk/P9WWsQJe4qFmdBHrMFMxrBHjcTTDWUnkV c60jIl6Grbcp/1LUH8DOqEs/7pJgX045Md8ABNAaON3MHgc/zLZa+LXi0 3TcoZe9Q0b2m5qWCMr4P4zPInhiwNw1Tt7VP/5UYJB13x9gyJXET0aMiS pFDFZn7XL18583fvE5o9YAqGj+UC8ykAIr0oz+NJab00cEF9rN0Uk9d5g Q9bW7HP2EYynZGPPHHyq6ksba5l+2WxjfmDBQnEvDryVmWpsKkHCGnex/ A==; X-IronPort-AV: E=McAfee;i="6600,9927,10712"; a="354768828" X-IronPort-AV: E=Sophos;i="5.99,278,1677571200"; d="scan'208";a="354768828" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2023 14:42:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10712"; a="791234019" X-IronPort-AV: E=Sophos;i="5.99,278,1677571200"; d="scan'208";a="791234019" Received: from linux.intel.com ([10.54.29.200]) by FMSMGA003.fm.intel.com with ESMTP; 16 May 2023 14:42:02 -0700 Received: from [10.212.175.225] (kliang2-mobl1.ccr.corp.intel.com [10.212.175.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 4A107580B9A; Tue, 16 May 2023 14:42:01 -0700 (PDT) Message-ID: <6ad0faf3-d264-9455-6e82-93b63240f6da@linux.intel.com> Date: Tue, 16 May 2023 17:41:59 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v1 15/15] perf vendor events intel: Add metricgroup descriptions for all models Content-Language: en-US To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , John Garry , Kajol Jain , Thomas Richter , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org References: <20230515215844.653610-1-irogers@google.com> <20230515215844.653610-16-irogers@google.com> <4f1e2e31-4efd-ba94-18e5-e53189429d9b@linux.intel.com> From: "Liang, Kan" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On 2023-05-16 2:19 p.m., Ian Rogers wrote: > On Tue, May 16, 2023 at 10:54 AM Liang, Kan wrote: >> >> >> >> On 2023-05-15 5:58 p.m., Ian Rogers wrote: >>> Add metric group descriptions created by: >>> https://github.com/intel/perfmon/blob/main/scripts/create_perf_json.py >>> The descriptions add some additional detail in perf list. >>> >>> Signed-off-by: Ian Rogers >>> --- >>> .../arch/x86/alderlake/metricgroups.json | 122 ++++++++++++++++++ >>> .../arch/x86/alderlaken/metricgroups.json | 26 ++++ >>> .../arch/x86/broadwell/metricgroups.json | 107 +++++++++++++++ >>> .../arch/x86/broadwellde/metricgroups.json | 107 +++++++++++++++ >>> .../arch/x86/broadwellx/metricgroups.json | 107 +++++++++++++++ >>> .../arch/x86/cascadelakex/metricgroups.json | 114 ++++++++++++++++ >>> .../arch/x86/haswell/metricgroups.json | 107 +++++++++++++++ >>> .../arch/x86/haswellx/metricgroups.json | 107 +++++++++++++++ >>> .../arch/x86/icelake/metricgroups.json | 113 ++++++++++++++++ >>> .../arch/x86/icelakex/metricgroups.json | 114 ++++++++++++++++ >>> .../arch/x86/ivybridge/metricgroups.json | 107 +++++++++++++++ >>> .../arch/x86/ivytown/metricgroups.json | 107 +++++++++++++++ >>> .../arch/x86/jaketown/metricgroups.json | 100 ++++++++++++++ >>> .../arch/x86/sandybridge/metricgroups.json | 100 ++++++++++++++ >>> .../arch/x86/sapphirerapids/metricgroups.json | 118 +++++++++++++++++ >>> .../arch/x86/skylake/metricgroups.json | 113 ++++++++++++++++ >>> .../arch/x86/skylakex/metricgroups.json | 114 ++++++++++++++++ >>> .../arch/x86/tigerlake/metricgroups.json | 113 ++++++++++++++++ >>> 18 files changed, 1896 insertions(+) >>> create mode 100644 tools/perf/pmu-events/arch/x86/alderlake/metricgroups.json >>> create mode 100644 tools/perf/pmu-events/arch/x86/alderlaken/metricgroups.json >>> create mode 100644 tools/perf/pmu-events/arch/x86/broadwell/metricgroups.json >>> create mode 100644 tools/perf/pmu-events/arch/x86/broadwellde/metricgroups.json >>> create mode 100644 tools/perf/pmu-events/arch/x86/broadwellx/metricgroups.json >>> create mode 100644 tools/perf/pmu-events/arch/x86/cascadelakex/metricgroups.json >>> create mode 100644 tools/perf/pmu-events/arch/x86/haswell/metricgroups.json >>> create mode 100644 tools/perf/pmu-events/arch/x86/haswellx/metricgroups.json >>> create mode 100644 tools/perf/pmu-events/arch/x86/icelake/metricgroups.json >>> create mode 100644 tools/perf/pmu-events/arch/x86/icelakex/metricgroups.json >>> create mode 100644 tools/perf/pmu-events/arch/x86/ivybridge/metricgroups.json >>> create mode 100644 tools/perf/pmu-events/arch/x86/ivytown/metricgroups.json >>> create mode 100644 tools/perf/pmu-events/arch/x86/jaketown/metricgroups.json >>> create mode 100644 tools/perf/pmu-events/arch/x86/sandybridge/metricgroups.json >>> create mode 100644 tools/perf/pmu-events/arch/x86/sapphirerapids/metricgroups.json >>> create mode 100644 tools/perf/pmu-events/arch/x86/skylake/metricgroups.json >>> create mode 100644 tools/perf/pmu-events/arch/x86/skylakex/metricgroups.json >>> create mode 100644 tools/perf/pmu-events/arch/x86/tigerlake/metricgroups.json >>> >>> diff --git a/tools/perf/pmu-events/arch/x86/alderlake/metricgroups.json b/tools/perf/pmu-events/arch/x86/alderlake/metricgroups.json >>> new file mode 100644 >>> index 000000000000..273ccfb0ed6f >>> --- /dev/null >>> +++ b/tools/perf/pmu-events/arch/x86/alderlake/metricgroups.json >>> @@ -0,0 +1,122 @@ >>> +{ >>> + "Backend": "Grouping from metrics spreadsheet", >>> + "Bad": "Grouping from metrics spreadsheet", >>> + "BadSpec": "Grouping from metrics spreadsheet", >>> + "BigFoot": "Grouping from metrics spreadsheet", >>> + "BrMispredicts": "Grouping from metrics spreadsheet", >>> + "Branches": "Grouping from metrics spreadsheet", >> >> The description "Grouping from metrics spreadsheet" seems meaningless, >> and may bring confusion information, e.g., what is metrics spreadsheet? >> I think it may be better to leave it empty if we don't have a proper >> description for the metricgroup. > > Thanks Kan, the TMA spreadsheet has a column (AG in version 4.5-full) > called Metric Group. For the level 3 ICache_Misses metric the value of > the cell is "BigFoot;FetchLat;IcMiss". The converter will put these > groups alongside the groups derived by level, parent/child > relationship. A group like "BigFoot" could use some explanation. The > intent with saying "Grouping from metrics spreadsheet" is to at least > give the origin of the metric group which I think is at least a little > bit better than saying nothing and not knowing the origin of where the > grouping comes from. I'd like to do more, so I think we can iterate > and improve, but I think this first step has some value. > So the groups with "Grouping from metrics spreadsheet" are all from the "Metric Group" column, right? I think the official name of TMA is Top-down Microarchitecture Analysis Metrics. Can we change the description to "Grouping from Top-down Microarchitecture Analysis Metrics spreadsheet"? If the end user searches the name, they can be pointed to the correct spreadsheet file. Thanks, Kan