From: Zoe Gates <zoe.blair.gates@icloud.com>
To: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
namhyung@kernel.org
Cc: mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com,
zoe@zeocities.dev, yujie.liu@intel.com, sandipan.das@amd.com,
leo.yan@arm.com, linux-perf-users@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/3] perf trace: Fix filter expansion length typo
Date: Mon, 27 Oct 2025 23:00:33 -0500 [thread overview]
Message-ID: <6b7c6221032fe9ca888d9905479d0bd502f583f7.camel@icloud.com> (raw)
From 08185c5be135eb83194a49e593be9258cec78d77 Mon Sep 17 00:00:00 2001
From: Zoe Gates <zoe@zeocities.dev>
Date: Mon, 27 Oct 2025 22:14:24 -0500
Subject: [PATCH 1/3] perf trace: Fix filter expansion length typo
Keep the filter expansion helper readable by using
expansion_length everywhere and wrapping the scnprintf call.
Signed-off-by: Zoe Gates <zoe@zeocities.dev>
---
tools/perf/Documentation/perf-script.txt | 2 +-
tools/perf/builtin-trace.c | 7 +++++--
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/tools/perf/Documentation/perf-script.txt
b/tools/perf/Documentation/perf-script.txt
index 28bec7e78bc8..e136ca35d380 100644
--- a/tools/perf/Documentation/perf-script.txt
+++ b/tools/perf/Documentation/perf-script.txt
@@ -262,7 +262,7 @@ OPTIONS
is printed. This is the full execution path leading to the
sample. This is only supported when the
sample was recorded with perf record -b or -j any.
- Use brstackinsnlen to print the brstackinsn lenght. For
example, you
+ Use brstackinsnlen to print the brstackinsn length. For
example, you
can’t know the next sequential instruction after an
unconditional branch unless
you calculate that based on its length.
diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index c607f39b8c8b..ae5fabf91c96 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -4291,7 +4291,10 @@ static int trace__expand_filter(struct trace
*trace, struct evsel *evsel)
if (fmt->strtoul(right, right_size,
&syscall_arg, &val)) {
char *n, expansion[19];
- int expansion_lenght =
scnprintf(expansion, sizeof(expansion), "%#" PRIx64, val);
+ int expansion_length;
+
+ expansion_length =
scnprintf(expansion, sizeof(expansion),
+
"%#" PRIx64, val);
int expansion_offset = right -
new_filter;
pr_debug("%s", expansion);
@@ -4303,7 +4306,7 @@ static int trace__expand_filter(struct trace
*trace, struct evsel *evsel)
}
if (new_filter != evsel-
>filter)
free(new_filter);
- left = n + expansion_offset +
expansion_lenght;
+ left = n + expansion_offset +
expansion_length;
new_filter = n;
} else {
pr_err("\"%.*s\" not found for
\"%s\" in \"%s\", can't set filter \"%s\"\n",
base-commit: fd57572253bc356330dbe5b233c2e1d8426c66fd
--
2.51.1
next reply other threads:[~2025-10-28 4:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 4:00 Zoe Gates [this message]
2025-10-28 15:01 ` [PATCH 1/3] perf trace: Fix filter expansion length typo Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b7c6221032fe9ca888d9905479d0bd502f583f7.camel@icloud.com \
--to=zoe.blair.gates@icloud.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=sandipan.das@amd.com \
--cc=yujie.liu@intel.com \
--cc=zoe@zeocities.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).