From: James Clark <james.clark@linaro.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Oliver Sang <oliver.sang@intel.com>,
oe-lkp@lists.linux.dev, lkp@intel.com,
linux-kernel@vger.kernel.org, x86@kernel.org,
Ravi Bangoria <ravi.bangoria@amd.com>,
linux-perf-users@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [tip:perf/core] [perf] da916e96e2: BUG:KASAN:null-ptr-deref_in_put_event
Date: Thu, 17 Apr 2025 09:58:36 +0100 [thread overview]
Message-ID: <72b016c4-3959-49d1-8964-0927eee101bf@linaro.org> (raw)
In-Reply-To: <20250416190817.GD6580@noisy.programming.kicks-ass.net>
On 16/04/2025 8:08 pm, Peter Zijlstra wrote:
> On Wed, Apr 16, 2025 at 10:46:10AM +0200, Peter Zijlstra wrote:
>> On Tue, Apr 15, 2025 at 04:52:56PM +0100, James Clark wrote:
>>> Unrelated to the pointer deref issue, I'm also seeing perf stat not working
>>> due to this commit. And that's both with and without this fixup:
>>>
>>> -> perf stat -- true
>>>
>>> Performance counter stats for 'true':
>>>
>>> <not counted> msec task-clock
>>>
>>> <not counted> context-switches
>>>
>>> <not counted> cpu-migrations
>>>
>>> <not counted> page-faults
>>>
>>> <not counted> armv8_cortex_a53/instructions/
>>>
>>> <not counted> armv8_cortex_a57/instructions/
>>>
>>> <not counted> armv8_cortex_a53/cycles/
>>>
>>> <not counted> armv8_cortex_a57/cycles/
>>>
>>> <not counted> armv8_cortex_a53/branches/
>>>
>>> <not counted> armv8_cortex_a53/branch-misses/
>>>
>>> <not counted> armv8_cortex_a57/branch-misses/
>>>
>>>
>>> 0.074139992 seconds time elapsed
>>>
>>> 0.000000000 seconds user
>>> 0.054797000 seconds sys
>>>
>>> Didn't look into it more other than bisecting it to this commit, but I can
>>> dig more unless the issue is obvious. This is on Arm big.LITTLE, although I
>>> didn't test it elsewhere so I'm not sure if that's relevant or not.
>>
>> I can reproduce on x86 alderlake (first machine I tried), so let me go
>> have a quick poke.
>
> Could you please try queue.git/perf/core ? I've fixed this and found
> another problem.
>
> I'll post the patches tomorrow, after the robot has had a go.
Yep that's all working now, thanks.
next prev parent reply other threads:[~2025-04-17 8:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-14 1:59 [tip:perf/core] [perf] da916e96e2: BUG:KASAN:null-ptr-deref_in_put_event kernel test robot
2025-04-14 19:01 ` Peter Zijlstra
2025-04-15 4:46 ` Oliver Sang
2025-04-15 9:14 ` James Clark
2025-04-15 10:08 ` Peter Zijlstra
2025-04-15 13:14 ` Peter Zijlstra
2025-04-15 15:52 ` James Clark
2025-04-16 8:46 ` Peter Zijlstra
2025-04-16 19:08 ` Peter Zijlstra
2025-04-17 8:58 ` James Clark [this message]
2025-04-16 8:36 ` Venkat Rao Bagalkote
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72b016c4-3959-49d1-8964-0927eee101bf@linaro.org \
--to=james.clark@linaro.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mark.rutland@arm.com \
--cc=oe-lkp@lists.linux.dev \
--cc=oliver.sang@intel.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).