From: Thomas Richter <tmricht@linux.ibm.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
linux-perf-users@vger.kernel.org, acme@kernel.org,
irogers@google.com, agordeev@linux.ibm.com, gor@linux.ibm.com,
sumanthk@linux.ibm.com, hca@linux.ibm.com, japo@linux.ibm.com
Subject: Re: [PATCH v2 2/3] perf config: Make symbol_conf::addr2line_disable_warn configurable
Date: Tue, 7 Apr 2026 08:58:54 +0200 [thread overview]
Message-ID: <72f255b9-8480-4e5b-be42-b8a185e4c5dc@linux.ibm.com> (raw)
In-Reply-To: <ac8h9ypRe4nHUu5q@google.com>
On 4/3/26 04:12, Namhyung Kim wrote:
> On Thu, Apr 02, 2026 at 10:01:58AM +0200, Thomas Richter wrote:
>> Make symbol_conf::addr2line_disable_warn configurable by reading
>> the perfconfig file. Use section core and addr2line-disable-warn =
>> value.
>
> I think it's better to have it under "report" or something. But it
> seems we already have one in the "core" section.
>
...snip...
It was added to the core section of the perf-config file by this patch:
commit 701677b95764 ("perf srcline: Add a timeout to reading from addr2line")
submitted by Ian Rogers in 2023. That is the reason why I left it in this section for
backward compatability.
We could also move it to the annotate::* section. What do you prefer?
I will add the other remarks in the new patch v3.
--
Thomas Richter, Dept 3303, IBM s390 Linux Development, Boeblingen, Germany
--
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294
next prev parent reply other threads:[~2026-04-07 6:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 8:01 [PATCH v2 0/3] perf addr2line: Rework disable_add2line_warn Thomas Richter
2026-04-02 8:01 ` [PATCH v2 1/3] perf config: Rename symbol_conf::disable_add2line_warn Thomas Richter
2026-04-03 2:08 ` Namhyung Kim
2026-04-07 6:50 ` Thomas Richter
2026-04-07 7:29 ` Namhyung Kim
2026-04-02 8:01 ` [PATCH v2 2/3] perf config: Make symbol_conf::addr2line_disable_warn configurable Thomas Richter
2026-04-03 2:12 ` Namhyung Kim
2026-04-07 6:58 ` Thomas Richter [this message]
2026-04-07 7:31 ` Namhyung Kim
2026-04-02 8:01 ` [PATCH v2 3/3] perf addr2line: Remove global variable addr2line_timeout_ms Thomas Richter
2026-04-03 2:16 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72f255b9-8480-4e5b-be42-b8a185e4c5dc@linux.ibm.com \
--to=tmricht@linux.ibm.com \
--cc=acme@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=irogers@google.com \
--cc=japo@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=sumanthk@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox