From: James Clark <james.clark@arm.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, will@kernel.org,
catalin.marinas@arm.com, mark.rutland@arm.com
Cc: Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Marc Zyngier <maz@kernel.org>,
Suzuki Poulose <suzuki.poulose@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH V10 00/10] arm64/perf: Enable branch stack sampling
Date: Tue, 30 May 2023 14:03:13 +0100 [thread overview]
Message-ID: <79fec396-94c8-6f69-b869-d19b89ccd2cc@arm.com> (raw)
In-Reply-To: <632289e3-6f3c-20b9-0454-77d6295c1c87@arm.com>
On 29/05/2023 05:35, Anshuman Khandual wrote:
>
>
> On 5/17/23 07:54, Anshuman Khandual wrote:
>> This series enables perf branch stack sampling support on arm64 platform
>> via a new arch feature called Branch Record Buffer Extension (BRBE). All
>> relevant register definitions could be accessed here.
>>
>> https://developer.arm.com/documentation/ddi0601/2021-12/AArch64-Registers
>>
>> This series applies on 6.4-rc2.
>>
>> Changes in V10:
>>
>> - Rebased the series on v6.4-rc2
>> - Moved ARMV8 PMUV3 changes inside drivers/perf/arm_pmuv3.c
>> - Moved BRBE driver changes inside drivers/perf/arm_brbe.[c|h]
>> - Moved the WARN_ON() inside the if condition in armv8pmu_handle_irq()
>
> Hello Will/Mark,
>
> There was a crash reported on V9 (applicable here in V10 as well) because of
> accessing event->pmu_ctx->task_ctx_data during a PMU IRQ for per-cpu events,
> where it would not have been allocated in the first place. I have proposed a
> fix for that on the other thread [1]. Besides, does the series looks good in
> the current form ? Unless there are other comments, will respin with the fix
> later in the week. Thank you.
>
> [1] https://lore.kernel.org/linux-arm-kernel/d02df808-6d2b-c24b-bc8d-8f4859c0c71b@arm.com/
>
> - Anshuman
Hi Anshuman,
With the new fix I don't get the crash anymore and the tests are all
passing so:
Tested-by: James Clark <james.clark@arm.com>
prev parent reply other threads:[~2023-05-30 13:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 2:24 [PATCH V10 00/10] arm64/perf: Enable branch stack sampling Anshuman Khandual
2023-05-17 2:24 ` [PATCH V10 01/10] drivers: perf: arm_pmu: Add new sched_task() callback Anshuman Khandual
2023-05-17 2:24 ` [PATCH V10 02/10] arm64/perf: Add BRBE registers and fields Anshuman Khandual
2023-05-17 2:24 ` [PATCH V10 03/10] arm64/perf: Add branch stack support in struct arm_pmu Anshuman Khandual
2023-05-17 2:24 ` [PATCH V10 04/10] arm64/perf: Add branch stack support in struct pmu_hw_events Anshuman Khandual
2023-05-17 2:24 ` [PATCH V10 05/10] arm64/perf: Add branch stack support in ARMV8 PMU Anshuman Khandual
2023-05-17 2:24 ` [PATCH V10 06/10] arm64/perf: Enable branch stack events via FEAT_BRBE Anshuman Khandual
2023-05-17 2:24 ` [PATCH V10 07/10] arm64/perf: Add PERF_ATTACH_TASK_DATA to events with has_branch_stack() Anshuman Khandual
2023-05-17 2:24 ` [PATCH V10 08/10] arm64/perf: Add struct brbe_regset helper functions Anshuman Khandual
2023-05-17 2:24 ` [PATCH V10 09/10] arm64/perf: Implement branch records save on task sched out Anshuman Khandual
2023-05-17 2:24 ` [PATCH V10 10/10] arm64/perf: Implement branch records save on PMU IRQ Anshuman Khandual
2023-05-29 4:35 ` [PATCH V10 00/10] arm64/perf: Enable branch stack sampling Anshuman Khandual
2023-05-30 13:03 ` James Clark [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79fec396-94c8-6f69-b869-d19b89ccd2cc@arm.com \
--to=james.clark@arm.com \
--cc=acme@kernel.org \
--cc=anshuman.khandual@arm.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=robh@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).