From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ravi Bangoria Subject: Re: [PATCH v2] perf test: S390 does not support watchpoints in test 22 Date: Fri, 28 Sep 2018 15:47:18 +0530 Message-ID: <7a99b293-fd3d-db4a-fc4b-d552e2458fb9@linux.ibm.com> References: <20180928074317.42893-1-tmricht@linux.ibm.com> <491ce3c5-f1ce-1513-3a9f-b86795e0332a@linux.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <491ce3c5-f1ce-1513-3a9f-b86795e0332a@linux.ibm.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Thomas-Mich Richter Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, acme@kernel.org, brueckner@linux.vnet.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, Ravi Bangoria List-Id: linux-perf-users.vger.kernel.org Hi Thomas, On 09/28/2018 03:32 PM, Thomas-Mich Richter wrote: > I can rework the patch to use the is_supported() member function. The > down side is that the test does not show up in the list of executed tests anymore, > unless some debug output is enabled: Which should be fine because s390 is doing that in all breakpoint related tests. But more important thing to suggest .is_supported field is, this patch has a regression on x86: Before: $ sudo ./perf test 22 22: Watchpoint : 22.1: Read Only Watchpoint : Skip 22.2: Write Only Watchpoint : Ok 22.3: Read / Write Watchpoint : Ok 22.4: Modify Watchpoint : Ok After: $ git apply 1.patch $ make $ sudo ./perf test 22 22: Watchpoint : 22.1: Read Only Watchpoint : Skip 22.2: Write Only Watchpoint : Skip 22.3: Read / Write Watchpoint : Skip 22.4: Modify Watchpoint : Skip Intel hw does not support read only watchpoitns. If you use skip_if_fail=true, all subsequent testcases are skipped as well. Thanks, Ravi