From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 863D719F10A; Thu, 29 May 2025 16:56:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748537775; cv=none; b=YgOY2evsnoDbomT7SMYcL+CjdB86brwE+PHx963vUDeLZ38agiym7lej37S4uKcLypKhBSCepAbM6TA9xPerIQjvQqF1fTE/61iKH+ToZP+PaYFj9W5f6gZ+tOF/gwcsSn6J6h8ZGZRUU0lvcnkbmAVuQNunYoTC8nhUhd4fE6Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748537775; c=relaxed/simple; bh=DRaD1/jwNIxgIiu48AG/4frKcAETzPdIlDu3ZM3psGY=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=l8rpuiH7IBrYRo1sMArecziJ6PYrIdipdcyFDcY67xfnxerG+mYb1cVzyaZJ1Y2M0cuIy2LaYI4xITVrqVBFZKGB189pU01kHBRka4M2v8qdC7uIdTe81LBEXqIYlfQDPxyKW2X+yirYcrzRZ79h7IMTGRfY9oYEX93ql2xvlk8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gIDhpcE1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gIDhpcE1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB6ECC4CEE7; Thu, 29 May 2025 16:56:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1748537774; bh=DRaD1/jwNIxgIiu48AG/4frKcAETzPdIlDu3ZM3psGY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gIDhpcE1ynd3+7vSpPrOvxUKNvDMgUoOkEX4LZUgb0B6MUhwkkQ7qSGAf2Ei/Ka37 tuU84O9CJlS5vUKpzniOmU/Z+V2IxZ6KWX56UvBIIEYF3orRMkseqfL++q2Av7uVUN GU9ezDGkYsxDDJ822W2OmGAmZpwW9u8dAusndcwrkIaSj8um7Lp2eMhNZNnOyMwwqf IKc0PdGmhD+/ulFCTvN0sXsURVqZFaH2dJp+eu3zZAAk60A6Tf9mgnbVxu2+VokQin bwOIQVnnB8360DYl7zLIajbDaS/QbFjopslOYyD4PYXZHZSwB+aNnjutIUOVDuYj1R 51DyHqGiFTpNA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uKgY8-001ckx-7m; Thu, 29 May 2025 17:56:12 +0100 Date: Thu, 29 May 2025 17:56:11 +0100 Message-ID: <867c1ze4pg.wl-maz@kernel.org> From: Marc Zyngier To: James Clark Cc: Catalin Marinas , Will Deacon , Mark Rutland , Jonathan Corbet , Oliver Upton , Joey Gouly , Suzuki K Poulose , Zenghui Yu , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev Subject: Re: [PATCH v2 06/11] KVM: arm64: Add trap configs for PMSDSFR_EL1 In-Reply-To: <20250529-james-perf-feat_spe_eft-v2-6-a01a9baad06a@linaro.org> References: <20250529-james-perf-feat_spe_eft-v2-0-a01a9baad06a@linaro.org> <20250529-james-perf-feat_spe_eft-v2-6-a01a9baad06a@linaro.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: james.clark@linaro.org, catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com, corbet@lwn.net, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, namhyung@kernel.org, alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Thu, 29 May 2025 12:30:27 +0100, James Clark wrote: > > SPE data source filtering (SPE_FEAT_FDS) adds a new register > PMSDSFR_EL1, add the trap configs for it. > > Signed-off-by: James Clark > --- > arch/arm64/kvm/emulate-nested.c | 1 + > arch/arm64/kvm/sys_regs.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/arch/arm64/kvm/emulate-nested.c b/arch/arm64/kvm/emulate-nested.c > index 0fcfcc0478f9..05d3e6b93ae9 100644 > --- a/arch/arm64/kvm/emulate-nested.c > +++ b/arch/arm64/kvm/emulate-nested.c > @@ -1169,6 +1169,7 @@ static const struct encoding_to_trap_config encoding_to_cgt[] __initconst = { > SR_TRAP(SYS_PMSIRR_EL1, CGT_MDCR_TPMS), > SR_TRAP(SYS_PMSLATFR_EL1, CGT_MDCR_TPMS), > SR_TRAP(SYS_PMSNEVFR_EL1, CGT_MDCR_TPMS), > + SR_TRAP(SYS_PMSDSFR_EL1, CGT_MDCR_TPMS), > SR_TRAP(SYS_TRFCR_EL1, CGT_MDCR_TTRF), > SR_TRAP(SYS_TRBBASER_EL1, CGT_MDCR_E2TB), > SR_TRAP(SYS_TRBLIMITR_EL1, CGT_MDCR_E2TB), > diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c > index 5dde9285afc8..9f544ac7b5a6 100644 > --- a/arch/arm64/kvm/sys_regs.c > +++ b/arch/arm64/kvm/sys_regs.c > @@ -2956,6 +2956,7 @@ static const struct sys_reg_desc sys_reg_descs[] = { > { SYS_DESC(SYS_PMBLIMITR_EL1), undef_access }, > { SYS_DESC(SYS_PMBPTR_EL1), undef_access }, > { SYS_DESC(SYS_PMBSR_EL1), undef_access }, > + { SYS_DESC(SYS_PMSDSFR_EL1), undef_access }, PMSDSFR_EL1 has an offset in the VNCR page (0x858), and must be described as such. This is equally true for a bunch of other SPE-related registers, so you might as well fix those while you're at it. Thanks, M. -- Without deviation from the norm, progress is not possible.