From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, will@kernel.org,
catalin.marinas@arm.com, mark.rutland@arm.com,
James Clark <james.clark@arm.com>, Rob Herring <robh@kernel.org>,
Marc Zyngier <maz@kernel.org>,
Suzuki Poulose <suzuki.poulose@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH V15 1/8] arm64/sysreg: Add BRBE registers and fields
Date: Mon, 4 Dec 2023 09:33:56 +0530 [thread overview]
Message-ID: <86f91d68-207d-40a5-9d76-1cbb80e4f210@arm.com> (raw)
In-Reply-To: <fd278f4e-0632-4474-8609-7711ad725f85@sirena.org.uk>
On 12/1/23 22:28, Mark Brown wrote:
> On Fri, Dec 01, 2023 at 11:08:59AM +0530, Anshuman Khandual wrote:
>
> This looks good apart from a few small omissions:
>
>> +SysregFields BRBINFx_EL1
>
>> +Enum 13:8 TYPE
>> + 0b000000 UNCOND_DIRECT
>> + 0b000001 INDIRECT
>> + 0b000010 DIRECT_LINK
>> + 0b000011 INDIRECT_LINK
>> + 0b000101 RET
>> + 0b000111 ERET
>> + 0b001000 COND_DIRECT
>> + 0b100001 DEBUG_HALT
>> + 0b100010 CALL
>> + 0b100011 TRAP
>> + 0b100100 SERROR
>> + 0b100110 INSN_DEBUG
>> + 0b100111 DATA_DEBUG
>> + 0b101010 ALIGN_FAULT
>> + 0b101011 INSN_FAULT
>> + 0b101100 DATA_FAULT
>> + 0b101110 IRQ
>> + 0b101111 FIQ
>> + 0b111001 DEBUG_EXIT
>> +EndEnum
>
> DDI0601 2023-09 also defines 0b110000 as an IMPLEMENTATION DEFINED
> exception to EL3.
Should this field be just IMPDEF or IMPDEF_TRAP_EL3 sounds better ?
>
>> +SysregFields BRBCR_ELx
>> +Res0 63:24
>> +Field 23 EXCEPTION
>> +Field 22 ERTN
>> +Res0 21:9
>
> DDI0601 2023-09 defines bit 9 as FZPSS.
Sure, will update.
>
>> +Sysreg BRBINFINJ_EL1 2 1 9 1 0
>
>> +Enum 13:8 TYPE
>> + 0b000000 UNCOND_DIRECT
>> + 0b000001 INDIRECT
>> + 0b000010 DIRECT_LINK
>> + 0b000011 INDIRECT_LINK
>> + 0b000101 RET
>> + 0b000111 ERET
>> + 0b001000 COND_DIRECT
>> + 0b100001 DEBUG_HALT
>> + 0b100010 CALL
>> + 0b100011 TRAP
>> + 0b100100 SERROR
>> + 0b100110 INSN_DEBUG
>> + 0b100111 DATA_DEBUG
>> + 0b101010 ALIGN_FAULT
>> + 0b101011 INSN_FAULT
>> + 0b101100 DATA_FAULT
>> + 0b101110 IRQ
>> + 0b101111 FIQ
>> + 0b111001 DEBUG_EXIT
>> +EndEnum
>
> DDI0601 2023-09 also defines 0b11000 as IMPLEMENTATION DEFINED exception
> to EL3.
Should this field be just IMPDEF or IMPDEF_TRAP_EL3 sounds better ?
Seems like BRBINFx_EL1 could be used for defining BRBINFINJ_EL1 as well.
next prev parent reply other threads:[~2023-12-04 4:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 5:38 [PATCH V15 0/8] arm64/perf: Enable branch stack sampling Anshuman Khandual
2023-12-01 5:38 ` [PATCH V15 1/8] arm64/sysreg: Add BRBE registers and fields Anshuman Khandual
2023-12-01 16:58 ` Mark Brown
2023-12-04 4:03 ` Anshuman Khandual [this message]
2023-12-04 12:18 ` Mark Brown
2023-12-01 5:39 ` [PATCH V15 2/8] KVM: arm64: Prevent guest accesses into BRBE system registers/instructions Anshuman Khandual
2023-12-04 8:22 ` Marc Zyngier
2023-12-11 6:34 ` Anshuman Khandual
2023-12-13 3:55 ` Anshuman Khandual
2023-12-01 5:39 ` [PATCH V15 3/8] drivers: perf: arm_pmuv3: Enable branch stack sampling framework Anshuman Khandual
2023-12-01 5:39 ` [PATCH V15 4/8] drivers: perf: arm_pmuv3: Enable branch stack sampling via FEAT_BRBE Anshuman Khandual
2023-12-01 5:39 ` [PATCH V15 5/8] KVM: arm64: nvhe: Disable branch generation in nVHE guests Anshuman Khandual
2023-12-04 8:42 ` Marc Zyngier
2023-12-11 6:00 ` Anshuman Khandual
2023-12-13 4:56 ` Anshuman Khandual
2023-12-01 5:39 ` [PATCH V15 6/8] perf: test: Speed up running brstack test on an Arm model Anshuman Khandual
2023-12-01 5:39 ` [PATCH V15 7/8] perf: test: Remove empty lines from branch filter test output Anshuman Khandual
2023-12-01 5:39 ` [PATCH V15 8/8] perf: test: Extend branch stack sampling test for Arm64 BRBE Anshuman Khandual
2023-12-04 8:15 ` [PATCH V15 0/8] arm64/perf: Enable branch stack sampling Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86f91d68-207d-40a5-9d76-1cbb80e4f210@arm.com \
--to=anshuman.khandual@arm.com \
--cc=acme@kernel.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=james.clark@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=robh@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).