linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Liang, Kan" <kan.liang@linux.intel.com>
To: Vince Weaver <vincent.weaver@maine.edu>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [perf] unchecked MSR access error: WRMSR to 0x3f1
Date: Wed, 18 Jun 2025 07:02:55 -0400	[thread overview]
Message-ID: <8739c2c6-a27c-4ab6-ad74-8b95e258737e@linux.intel.com> (raw)
In-Reply-To: <7e8bb736-3955-c479-99de-e08efb494bdd@maine.edu>



On 2025-06-17 11:49 p.m., Vince Weaver wrote:
> On Tue, 17 Jun 2025, Liang, Kan wrote:
> 
>> The commit 2dc0572f2cef was triggered by the fake event VLBR_EVENT.
>> But this error should be triggered by the Topdown perf metrics event,
>> INTEL_TD_METRIC_RETIRING, which uses the idx 48 internally.
>>
>> We never support perf metrics events in sampling mode. The PEBS cannot
>> be enabled in counting mode. So it's weird the cpuc->pebs_enabled has
>> the idx 48 set.
>>
>> The recent change I did for the PEBS is commit e02e9b0374c3
>> "perf/x86/intel: Support PEBS counters snapshotting". But it should not
>> impact the above.
>>
>> Could you please help on the below questions?
>> - It only happens on the p-core, right?
> 
> how would I tell?  I don't think the error message says what CPU it 
> happens on?

No, the error message doesn't say it. Just want to check if you have
extra information. Because the Topdown perf metrics is only supported on
p-core. I want to understand whether the code messes up with e-core.

> 
>> - Which kernel base do you use? Is it 6.16-rc2?
> 
> I was running just before -rc1.  I've updated to current git but didn't 
> realize the throttle fix hadn't made it upstream yet so managed to lock up 
> the machine and not sure when I'll be able to get over to reboot it.
>

They are not in rc2 as well. I guess it should be included in rc3.


>> - Can this be easily reproduced?
> 
> probably.  It's another thing that's a pain to check because it's a 
> WARN_ONCE I think so I have to reboot in order to see.  Even if it's not 
> reproducible the fuzzer usually hits it within a few hours.

OK. I will try to reproduce it locally.

> 
>>   Is it possible to bisect the error commit? (Maybe start from the
>> commit e02e9b0374c3?)
> 
> Maybe but I'd only like to do that as a last resort as it's a pain to 
> build and reboot kernels on this machine (for secureboot and other 
> reasons).  


Sure.

Thanks,
Kan

> Also I suppose I'd have to manually apply the throttle patch 
> while bisecting.

> 
> Vince Weaver
> vincent.weaver@maine.edu
> 


  reply	other threads:[~2025-06-18 11:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-17 15:39 [perf] unchecked MSR access error: WRMSR to 0x3f1 Vince Weaver
2025-06-17 15:50 ` Abhigyan ghosh
2025-06-17 19:47 ` Liang, Kan
2025-06-18  3:49   ` Vince Weaver
2025-06-18 11:02     ` Liang, Kan [this message]
2025-06-18 18:26       ` Vince Weaver
2025-06-19 15:17         ` Vince Weaver
2025-06-19 16:06           ` Liang, Kan
2025-06-19 20:10             ` Vince Weaver
2025-06-20 11:07               ` Liang, Kan
2025-06-20 16:12                 ` Vince Weaver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8739c2c6-a27c-4ab6-ad74-8b95e258737e@linux.intel.com \
    --to=kan.liang@linux.intel.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=vincent.weaver@maine.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).