From: Andi Kleen <ak@linux.intel.com>
To: Thomas Richter <tmricht@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
acme@kernel.org, brueckner@linux.vnet.ibm.com,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com
Subject: Re: [PATCH 4/4] perf stat: Add transaction flag (-T) support for s390
Date: Thu, 21 Jun 2018 19:36:04 -0700 [thread overview]
Message-ID: <87in6bsg2z.fsf@linux.intel.com> (raw)
In-Reply-To: <20180621080452.61012-4-tmricht@linux.ibm.com> (Thomas Richter's message of "Thu, 21 Jun 2018 10:04:52 +0200")
Thomas Richter <tmricht@linux.ibm.com> writes:
>
> + /* Handle -T as -M transaction. Once platform specific metrics
> + * support has been added to the json files, all archiectures
> + * will use this approach.
> + */
> + if (!strcmp(perf_env__arch(NULL), "s390")) {
Use pmu_have_event() instead.
You may need to add support for wildcard pmus to it.
-Andi
next prev parent reply other threads:[~2018-06-22 2:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 8:04 [PATCH 1/4] Revert "perf list: Add s390 support for detailed/verbose PMU event description" Thomas Richter
2018-06-21 8:04 ` [PATCH 2/4] perf list: Add s390 support for detailed PMU event description Thomas Richter
2018-06-21 8:04 ` [PATCH 3/4] perf json: Add s390 transaction counter definition Thomas Richter
2018-06-21 8:04 ` [PATCH 4/4] perf stat: Add transaction flag (-T) support for s390 Thomas Richter
2018-06-22 2:36 ` Andi Kleen [this message]
2018-06-22 8:10 ` Thomas-Mich Richter
2018-06-22 14:31 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87in6bsg2z.fsf@linux.intel.com \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=brueckner@linux.vnet.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).