From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Li RongQing <lirongqing@baidu.com>,
peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
namhyung@kernel.org, mark.rutland@arm.com, jolsa@kernel.org,
irogers@google.com, adrian.hunter@intel.com,
kan.liang@linux.intel.com, tglx@linutronix.de, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
zhiquan1.li@intel.com, alexander.shishkin@linux.intel.com
Cc: Li RongQing <lirongqing@baidu.com>
Subject: Re: [PATCH] perf/x86/intel/bts: allocate bts_ctx only if necessary
Date: Wed, 30 Oct 2024 09:26:55 +0200 [thread overview]
Message-ID: <87msimt5j4.fsf@ubik.fi.intel.com> (raw)
In-Reply-To: <20241030063521.4025-1-lirongqing@baidu.com>
Li RongQing <lirongqing@baidu.com> writes:
> Avoid unnecessary per-CPU memory allocation on unsupported CPUs,
> this can save 12K memory for every CPU
Looks reasonable, but have you tested it? This driver is in serious
danger of bitrot ever since KPTI. It might save even more if we simply
remove the whole thing.
Regards,
--
Alex
next parent reply other threads:[~2024-10-30 7:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241030063521.4025-1-lirongqing@baidu.com>
2024-10-30 7:26 ` Alexander Shishkin [this message]
2025-01-22 7:41 [PATCH] perf/x86/intel/bts: allocate bts_ctx only if necessary lirongqing
2025-01-23 18:36 ` Adrian Hunter
2025-01-23 18:54 ` Liang, Kan
2025-03-05 13:47 ` Jiri Olsa
2025-03-05 13:54 ` Jiri Olsa
2025-03-05 14:58 ` Adrian Hunter
2025-03-05 16:11 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87msimt5j4.fsf@ubik.fi.intel.com \
--to=alexander.shishkin@linux.intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=zhiquan1.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).