From: "Liang, Kan" <kan.liang@linux.intel.com>
To: Ian Rogers <irogers@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Yang Jihong <yangjihong1@huawei.com>,
James Clark <james.clark@arm.com>,
Ravi Bangoria <ravi.bangoria@amd.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/6] Extra verbose/perf-list details
Date: Fri, 8 Mar 2024 10:39:27 -0500 [thread overview]
Message-ID: <89249fc5-6102-45d4-9345-5dd80d06e001@linux.intel.com> (raw)
In-Reply-To: <20240308001915.4060155-1-irogers@google.com>
On 2024-03-07 7:19 p.m., Ian Rogers wrote:
> Add more encoding detail and raw event details in perf list. Add PMU
> name and reverse lookup from config to event name to
> perf_event_attr_fprintf. This makes the verbose output easier to read,
> and the perf list information more specific.
>
> v3. Fix to reverse lookup to ensure or aliases are loaded and if
> getting the config value fails for an event/alias just continue to
> the next one.
> v2. Address feedback from Kan Liang, "Raw hardware event descriptor"
> becomes "Raw event descriptor" add assert to keep term numbers in
> sync, fix a commit message.
>
> Ian Rogers (6):
> perf list: Add tracepoint encoding to detailed output
> perf pmu: Drop "default_core" from alias names
> perf list: Allow wordwrap to wrap on commas
> perf list: Give more details about raw event encodings
> perf tools: Use pmus to describe type from attribute
> perf tools: Add/use PMU reverse lookup from config to name
The patch series look good to me.
I verified it on a hybrid machine. The new format is the same as the
advertise.
Tested-by: Kan Liang <kan.liang@linux.intel.com>
Thanks,
Kan
>
> tools/perf/builtin-list.c | 21 ++++-
> tools/perf/util/perf_event_attr_fprintf.c | 26 +++++--
> tools/perf/util/pmu.c | 82 +++++++++++++++++++-
> tools/perf/util/pmu.h | 4 +
> tools/perf/util/pmus.c | 94 +++++++++++++++++++++++
> tools/perf/util/pmus.h | 1 +
> tools/perf/util/print-events.c | 55 +++++++------
> 7 files changed, 242 insertions(+), 41 deletions(-)
>
next prev parent reply other threads:[~2024-03-08 15:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 0:19 [PATCH v3 0/6] Extra verbose/perf-list details Ian Rogers
2024-03-08 0:19 ` [PATCH v3 1/6] perf list: Add tracepoint encoding to detailed output Ian Rogers
2024-03-08 0:19 ` [PATCH v3 2/6] perf pmu: Drop "default_core" from alias names Ian Rogers
2024-03-08 0:19 ` [PATCH v3 3/6] perf list: Allow wordwrap to wrap on commas Ian Rogers
2024-03-08 0:19 ` [PATCH v3 4/6] perf list: Give more details about raw event encodings Ian Rogers
2024-03-21 2:59 ` Ian Rogers
2024-03-21 13:31 ` Arnaldo Carvalho de Melo
2024-03-08 0:19 ` [PATCH v3 5/6] perf tools: Use pmus to describe type from attribute Ian Rogers
2024-03-08 0:19 ` [PATCH v3 6/6] perf tools: Add/use PMU reverse lookup from config to name Ian Rogers
2024-03-08 15:39 ` Liang, Kan [this message]
[not found] ` <CAP-5=fWGhZHnsBWo4=+9PdfaAPNEnx7u40G+BHAWR+4rPC2Udw@mail.gmail.com>
2024-03-20 1:01 ` [PATCH v3 0/6] Extra verbose/perf-list details Ian Rogers
2024-03-20 14:42 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89249fc5-6102-45d4-9345-5dd80d06e001@linux.intel.com \
--to=kan.liang@linux.intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=yangjihong1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).