* [PATCH v2] perf test: Add basic callgraph test to record testing
@ 2025-06-28 1:55 Ian Rogers
2025-06-30 8:01 ` Thomas Richter
2025-07-01 17:55 ` Namhyung Kim
0 siblings, 2 replies; 4+ messages in thread
From: Ian Rogers @ 2025-06-28 1:55 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Mark Rutland, Alexander Shishkin, Jiri Olsa,
Ian Rogers, Adrian Hunter, Kan Liang, James Clark, Dapeng Mi,
Thomas Richter, Chun-Tse Shao, linux-perf-users, linux-kernel
Give some basic perf record callgraph coverage.
Signed-off-by: Ian Rogers <irogers@google.com>
---
v2: Pick up s390's needed "--call-graph dwarf" as spotted by James
Clark <james.clark@linaro.org>.
---
tools/perf/tests/shell/record.sh | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh
index 2022a4f739be..b1ad24fb3b33 100755
--- a/tools/perf/tests/shell/record.sh
+++ b/tools/perf/tests/shell/record.sh
@@ -12,8 +12,10 @@ shelldir=$(dirname "$0")
. "${shelldir}"/lib/perf_has_symbol.sh
testsym="test_loop"
+testsym2="brstack"
skip_test_missing_symbol ${testsym}
+skip_test_missing_symbol ${testsym2}
err=0
perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX)
@@ -359,6 +361,33 @@ test_precise_max() {
fi
}
+test_callgraph() {
+ echo "Callgraph test"
+
+ case $(uname -m)
+ in s390x)
+ cmd_flags="--call-graph dwarf -e cpu-clock";;
+ *)
+ cmd_flags="-g";;
+ esac
+
+ if ! perf record -o "${perfdata}" $cmd_flags perf test -w brstack
+ then
+ echo "Callgraph test [Failed missing output]"
+ err=1
+ return
+ fi
+
+ if ! perf report -i "${perfdata}" 2>&1 | grep "${testsym2}"
+ then
+ echo "Callgraph test [Failed missing symbol]"
+ err=1
+ return
+ fi
+
+ echo "Callgraph test [Success]"
+}
+
# raise the limit of file descriptors to minimum
if [[ $default_fd_limit -lt $min_fd_limit ]]; then
ulimit -Sn $min_fd_limit
@@ -374,6 +403,7 @@ test_uid
test_leader_sampling
test_topdown_leader_sampling
test_precise_max
+test_callgraph
# restore the default value
ulimit -Sn $default_fd_limit
--
2.50.0.727.gbf7dc18ff4-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] perf test: Add basic callgraph test to record testing
2025-06-28 1:55 [PATCH v2] perf test: Add basic callgraph test to record testing Ian Rogers
@ 2025-06-30 8:01 ` Thomas Richter
2025-06-30 9:14 ` James Clark
2025-07-01 17:55 ` Namhyung Kim
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Richter @ 2025-06-30 8:01 UTC (permalink / raw)
To: Ian Rogers, Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Mark Rutland, Alexander Shishkin, Jiri Olsa,
Adrian Hunter, Kan Liang, James Clark, Dapeng Mi, Chun-Tse Shao,
linux-perf-users, linux-kernel
On 6/28/25 03:55, Ian Rogers wrote:
> Give some basic perf record callgraph coverage.
>
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> v2: Pick up s390's needed "--call-graph dwarf" as spotted by James
> Clark <james.clark@linaro.org>.
> ---
> tools/perf/tests/shell/record.sh | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh
> index 2022a4f739be..b1ad24fb3b33 100755
> --- a/tools/perf/tests/shell/record.sh
> +++ b/tools/perf/tests/shell/record.sh
> @@ -12,8 +12,10 @@ shelldir=$(dirname "$0")
> . "${shelldir}"/lib/perf_has_symbol.sh
>
> testsym="test_loop"
> +testsym2="brstack"
>
> skip_test_missing_symbol ${testsym}
> +skip_test_missing_symbol ${testsym2}
>
> err=0
> perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX)
> @@ -359,6 +361,33 @@ test_precise_max() {
> fi
> }
>
> +test_callgraph() {
> + echo "Callgraph test"
> +
> + case $(uname -m)
> + in s390x)
> + cmd_flags="--call-graph dwarf -e cpu-clock";;
> + *)
> + cmd_flags="-g";;
> + esac
> +
> + if ! perf record -o "${perfdata}" $cmd_flags perf test -w brstack
> + then
> + echo "Callgraph test [Failed missing output]"
> + err=1
> + return
> + fi
> +
> + if ! perf report -i "${perfdata}" 2>&1 | grep "${testsym2}"
> + then
> + echo "Callgraph test [Failed missing symbol]"
> + err=1
> + return
> + fi
> +
> + echo "Callgraph test [Success]"
> +}
> +
> # raise the limit of file descriptors to minimum
> if [[ $default_fd_limit -lt $min_fd_limit ]]; then
> ulimit -Sn $min_fd_limit
> @@ -374,6 +403,7 @@ test_uid
> test_leader_sampling
> test_topdown_leader_sampling
> test_precise_max
> +test_callgraph
>
> # restore the default value
> ulimit -Sn $default_fd_limit
Works ok for s390
Tested-by: Thomas Richter <tmricht@linux.ibm.com>
--
Thomas Richter, Dept 3303, IBM s390 Linux Development, Boeblingen, Germany
--
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] perf test: Add basic callgraph test to record testing
2025-06-30 8:01 ` Thomas Richter
@ 2025-06-30 9:14 ` James Clark
0 siblings, 0 replies; 4+ messages in thread
From: James Clark @ 2025-06-30 9:14 UTC (permalink / raw)
To: Thomas Richter, Ian Rogers
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Mark Rutland, Alexander Shishkin, Jiri Olsa,
Adrian Hunter, Kan Liang, Dapeng Mi, Chun-Tse Shao,
linux-perf-users, linux-kernel
On 30/06/2025 9:01 am, Thomas Richter wrote:
> On 6/28/25 03:55, Ian Rogers wrote:
>> Give some basic perf record callgraph coverage.
>>
>> Signed-off-by: Ian Rogers <irogers@google.com>
>> ---
>> v2: Pick up s390's needed "--call-graph dwarf" as spotted by James
>> Clark <james.clark@linaro.org>.
>> ---
>> tools/perf/tests/shell/record.sh | 30 ++++++++++++++++++++++++++++++
>> 1 file changed, 30 insertions(+)
>>
>> diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh
>> index 2022a4f739be..b1ad24fb3b33 100755
>> --- a/tools/perf/tests/shell/record.sh
>> +++ b/tools/perf/tests/shell/record.sh
>> @@ -12,8 +12,10 @@ shelldir=$(dirname "$0")
>> . "${shelldir}"/lib/perf_has_symbol.sh
>>
>> testsym="test_loop"
>> +testsym2="brstack"
>>
>> skip_test_missing_symbol ${testsym}
>> +skip_test_missing_symbol ${testsym2}
>>
>> err=0
>> perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX)
>> @@ -359,6 +361,33 @@ test_precise_max() {
>> fi
>> }
>>
>> +test_callgraph() {
>> + echo "Callgraph test"
>> +
>> + case $(uname -m)
>> + in s390x)
>> + cmd_flags="--call-graph dwarf -e cpu-clock";;
>> + *)
>> + cmd_flags="-g";;
>> + esac
>> +
>> + if ! perf record -o "${perfdata}" $cmd_flags perf test -w brstack
>> + then
>> + echo "Callgraph test [Failed missing output]"
>> + err=1
>> + return
>> + fi
>> +
>> + if ! perf report -i "${perfdata}" 2>&1 | grep "${testsym2}"
>> + then
>> + echo "Callgraph test [Failed missing symbol]"
>> + err=1
>> + return
>> + fi
>> +
>> + echo "Callgraph test [Success]"
>> +}
>> +
>> # raise the limit of file descriptors to minimum
>> if [[ $default_fd_limit -lt $min_fd_limit ]]; then
>> ulimit -Sn $min_fd_limit
>> @@ -374,6 +403,7 @@ test_uid
>> test_leader_sampling
>> test_topdown_leader_sampling
>> test_precise_max
>> +test_callgraph
>>
>> # restore the default value
>> ulimit -Sn $default_fd_limit
>
> Works ok for s390
>
> Tested-by: Thomas Richter <tmricht@linux.ibm.com>
Reviewed-by: James Clark <james.clark@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] perf test: Add basic callgraph test to record testing
2025-06-28 1:55 [PATCH v2] perf test: Add basic callgraph test to record testing Ian Rogers
2025-06-30 8:01 ` Thomas Richter
@ 2025-07-01 17:55 ` Namhyung Kim
1 sibling, 0 replies; 4+ messages in thread
From: Namhyung Kim @ 2025-07-01 17:55 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Adrian Hunter,
Kan Liang, James Clark, Dapeng Mi, Thomas Richter, Chun-Tse Shao,
linux-perf-users, linux-kernel, Ian Rogers
On Fri, 27 Jun 2025 18:55:53 -0700, Ian Rogers wrote:
> Give some basic perf record callgraph coverage.
>
>
Applied to perf-tools-next, thanks!
Best regards,
Namhyung
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-07-01 17:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-28 1:55 [PATCH v2] perf test: Add basic callgraph test to record testing Ian Rogers
2025-06-30 8:01 ` Thomas Richter
2025-06-30 9:14 ` James Clark
2025-07-01 17:55 ` Namhyung Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).