From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AD49C001B0 for ; Fri, 23 Jun 2023 18:20:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229668AbjFWSUf (ORCPT ); Fri, 23 Jun 2023 14:20:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbjFWSUe (ORCPT ); Fri, 23 Jun 2023 14:20:34 -0400 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D30E8271E for ; Fri, 23 Jun 2023 11:20:33 -0700 (PDT) Received: from pps.filterd (m0353728.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35NIAGSP009279; Fri, 23 Jun 2023 18:19:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=FNNXuGN+qWVuW98bDcWnFuj0QuvjBHI/jUYVmnWPASs=; b=LuHd8yY002WD5Am/4Vu8WVWUrJdp3OBr5cXqEVN+ohnntmzwJzjU5vo6nNLpr7deHWbO +uiOOIFxlMdzews1Dy+VW8GT5pErJ9G54JhPvFk2mfFcYTxYL6GDpG0JuU5edXfgFCj1 FCD+oxnL9nR1JjSIm51XCiIlxjMtdZiay/acleZ0MWBRcujMwK7TYGp0TwXGlpgZzYBY sa0ihfsX/WKS+oIafqh3j78YczCKYsg9nS/PBLPRRdmeTEmQMrHjmu8rHgkU1+7Pe8JX Jp87nieolw5tPsBsLVkrW5jOmXhqqdjFRjheyuu0ebZAHN69hFLx+wxSjIDOxOFa3VA0 iA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rdg68rj4n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 Jun 2023 18:19:33 +0000 Received: from m0353728.ppops.net (m0353728.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 35NHtGC8025943; Fri, 23 Jun 2023 18:19:33 GMT Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rdg68rj3w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 Jun 2023 18:19:33 +0000 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 35NDqNOY013571; Fri, 23 Jun 2023 18:19:31 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma04ams.nl.ibm.com (PPS) with ESMTPS id 3r94f5cbg8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 Jun 2023 18:19:30 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 35NIJRQf58786154 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 23 Jun 2023 18:19:27 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 549B520040; Fri, 23 Jun 2023 18:19:27 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2592B2004B; Fri, 23 Jun 2023 18:19:24 +0000 (GMT) Received: from [9.43.112.194] (unknown [9.43.112.194]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Fri, 23 Jun 2023 18:19:23 +0000 (GMT) Message-ID: <89f3889b-7d1e-0b04-34a0-f6eb8d9309c8@linux.ibm.com> Date: Fri, 23 Jun 2023 23:49:22 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 15/17] perf tests task_analyzer: fix bad substitution ${$1} Content-Language: en-IN, en-US To: Namhyung Kim Cc: irogers@google.com, Athira Rajeev , john.g.garry@oracle.com, kjain@linux.ibm.com, Hagen Paul Pfeifer , Arnaldo Carvalho de Melo , linux-perf-users@vger.kernel.org, ravi.bangoria@amd.com, maddy@linux.ibm.com, jolsa@kernel.org, Petar Gligoric , disgoel@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org References: <20230613164145.50488-1-atrajeev@linux.vnet.ibm.com> <20230613164145.50488-16-atrajeev@linux.vnet.ibm.com> <5ab5cc25-03b0-ef7f-3dc0-be1b59a4147d@linux.ibm.com> From: Aditya Gupta In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 1PRJaXYJZC4AofxumG695F9LDdYqQt8o X-Proofpoint-ORIG-GUID: O1wtWD-OH6HzP2maxlgMAXxfNn2-eOld Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-23_10,2023-06-22_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 bulkscore=0 spamscore=0 suspectscore=0 mlxlogscore=762 malwarescore=0 mlxscore=0 priorityscore=1501 adultscore=0 phishscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306230161 Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Hello, Namhyung, On 23/06/23 04:55, Namhyung Kim wrote: > Ok, I found two problems. > > ... > > The first one is related to this message. It couldn't find the script > (task-analyzer.py) because PERF_EXEC_PATH is not set. > Running with --exec-path=$PWD was ok, but I got a segfault. > > The other problem is in set_regs_in_dict(). It tries to capture > register values in the sample and save them to a dictionary. > The sample doesn't have registers so it should have no problem. > But the 'bf' was not initialized properly when size is 0, and it led > PyUnicode_FromString() returning NULL. > > After the changes, it ran ok: > > $ sudo ./perf test -v task > 116: perf script task-analyzer tests : > --- start --- > test child forked, pid 204088 > PASS: "test_basic" > PASS: "test_ns_rename" > PASS: "test_ms_filtertasks_highlight" > PASS: "test_extended_times_timelimit_limittasks" > PASS: "test_summary" > PASS: "test_summaryextended" > PASS: "test_summaryonly" > PASS: "test_extended_times_summary_ns" > PASS: "test_extended_times_summary_ns" > PASS: "test_csv" > PASS: "test_csvsummary" > PASS: "test_csv_extended_times" > PASS: "test_csvsummary_extended" > test child finished with 0 > ---- end ---- > perf script task-analyzer tests: Ok This is interesting. I did not encounter these earlier. > I'll send the fixes soon. > Thanks for fixing it. >>> You can try the perf-tools-next branch in the perf/perft-tools-next.git repo. >>> >>> git://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git >>> >>> $ make clean all >>> $ sudo ./perf test -v task >>> I tested with the steps provided, i.e.. clone, /*apply patch 15 (added this step myself)*/, clean, make, ./perf test -v test. But still- test passed: ''' ~/temp_clones/perf-tools-next/tools/perf git:(master) sudo ./perf test -v test ... --- start --- test child forked, pid 75261 PASS: "test_basic" PASS: "test_ns_rename" PASS: "test_ms_filtertasks_highlight" PASS: "test_extended_times_timelimit_limittasks" PASS: "test_summary" PASS: "test_summaryextended" PASS: "test_summaryonly" PASS: "test_extended_times_summary_ns" PASS: "test_extended_times_summary_ns" PASS: "test_csv" PASS: "test_csvsummary" PASS: "test_csv_extended_times" PASS: "test_csvsummary_extended" test child finished with 0 ---- end ---- ''' Maybe my environment had that other things set in a way that, I did not face any issue (I don't recall doing any special thing with my environment though, and these patches have been tested multiple times by more people also). But thanks for your efforts to debug and fix the issue. Thanks, - AdityaG