From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F3B2C77B72 for ; Mon, 17 Apr 2023 11:30:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229825AbjDQLaY (ORCPT ); Mon, 17 Apr 2023 07:30:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229878AbjDQLaW (ORCPT ); Mon, 17 Apr 2023 07:30:22 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A77E11FDA for ; Mon, 17 Apr 2023 04:28:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681730838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oVc9uxy2kIdreOR/jYYEkHBdj+2RYiJitTncQTj92Ak=; b=NanM95DIf6UqjG2Vx5RF7ykf0oZmfTs/2USLb19AXJCGj+zVOHGy9cSV2QghmE+K5qo87U qzqBOFXZ0PgBHYGDwQ5N3yrClRiR7CQFCcnmMLRBQX91F/5zVnjiYosuoqmja2QAitRaHU LDcF0eQkZnNUwADKchhrd4Jv61QWPi0= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-607-L1fMpgNMPgKv93yYRSYDRg-1; Mon, 17 Apr 2023 07:01:23 -0400 X-MC-Unique: L1fMpgNMPgKv93yYRSYDRg-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-2efbab2e7ffso389712f8f.1 for ; Mon, 17 Apr 2023 04:01:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681729281; x=1684321281; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oVc9uxy2kIdreOR/jYYEkHBdj+2RYiJitTncQTj92Ak=; b=ZUKy0g4dMpsFc4v4TylYNQQjz4vQvfiqYfO4iA9C6ppNbezAm6Mvk1F+ylrPXgHWVV f3SxZFn5OK3aADsHKuYLRzCoG0coe6WIF/k/ECQKmrTVFPU7kk/uZatdF2DAP5YMTDHy VpQ+4rD7566Ak0fXBQpGbJy2tWfODmvwGz6cf7TLHv1sbqVGkeomjLykFu8YtVEv0y9n Le/4pTk4bhXBwMVDuB8UOwuF37A9QSTf4t0Va0vVSongFFOgdlRmmYhUllxzjRv3ItVI syvIYFSGejPyaLi4RirboPr7MmalhPB6AO43ka35wOwFmDzfGknNO60AlTPlQPBzhZ4S WZEw== X-Gm-Message-State: AAQBX9dcFmCIrj9oRlhpzp8/+Zz13yyAO9kY7Xnh88gx4rWLtcuLd5jD 9RERVRfySn+xtK/wNWuQ7xdTtubjyyoHaM47TZHlOXDJe6RkbGEX/GGJbNmaCgxZwE7lxxc4eLp R4zaU9Knx6/Vau9jl4NqqzC3jYHRMLg== X-Received: by 2002:a05:6000:1376:b0:2f7:fb78:9694 with SMTP id q22-20020a056000137600b002f7fb789694mr5066284wrz.17.1681729281619; Mon, 17 Apr 2023 04:01:21 -0700 (PDT) X-Google-Smtp-Source: AKy350ZQIa4sVrexrjBGWt+x2dl05vD2C7OxIO4qZKWXoX9kbiyotAMI/EdKnSlVTtQjGuOSPjILbQ== X-Received: by 2002:a05:6000:1376:b0:2f7:fb78:9694 with SMTP id q22-20020a056000137600b002f7fb789694mr5066215wrz.17.1681729280958; Mon, 17 Apr 2023 04:01:20 -0700 (PDT) Received: from ?IPV6:2003:cb:c700:fc00:db07:68a9:6af5:ecdf? (p200300cbc700fc00db0768a96af5ecdf.dip0.t-ipconnect.de. [2003:cb:c700:fc00:db07:68a9:6af5:ecdf]) by smtp.gmail.com with ESMTPSA id h12-20020a5d4fcc000000b002f22c44e974sm10214704wrw.102.2023.04.17.04.01.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Apr 2023 04:01:20 -0700 (PDT) Message-ID: <8a323d9f-f54e-065d-d611-0a07aea170c8@redhat.com> Date: Mon, 17 Apr 2023 13:01:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v3 3/7] mm/gup: remove vmas parameter from get_user_pages_remote() Content-Language: en-US To: Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton Cc: Matthew Wilcox , linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-security-module@vger.kernel.org, Catalin Marinas , Will Deacon , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Sven Schnelle , Eric Biederman , Kees Cook , Alexander Viro , Christian Brauner , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Kentaro Takeda , Tetsuo Handa , Paul Moore , James Morris , "Serge E . Hallyn" , Paolo Bonzini References: <523f0764f4979276a6d4b89cbad9af9124e4bf0a.1681558407.git.lstoakes@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <523f0764f4979276a6d4b89cbad9af9124e4bf0a.1681558407.git.lstoakes@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On 15.04.23 14:09, Lorenzo Stoakes wrote: > The only instances of get_user_pages_remote() invocations which used the > vmas parameter were for a single page which can instead simply look up the > VMA directly. In particular:- > > - __update_ref_ctr() looked up the VMA but did nothing with it so we simply > remove it. > > - __access_remote_vm() was already using vma_lookup() when the original > lookup failed so by doing the lookup directly this also de-duplicates the > code. > > This forms part of a broader set of patches intended to eliminate the vmas > parameter altogether. > > Signed-off-by: Lorenzo Stoakes > --- I guess we should never drop the mmap lock temporarily in these cases, so it's fine. Acked-by: David Hildenbrand -- Thanks, David / dhildenb