From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D7A3107BE for ; Wed, 27 Sep 2023 13:47:36 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 141E9126; Wed, 27 Sep 2023 06:47:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695822455; x=1727358455; h=message-id:date:mime-version:subject:to:references:from: in-reply-to:content-transfer-encoding; bh=rckWQBH09ux7UItuMOh4cqx0HvWKbyWH8NUeUGHWWJA=; b=UEPeYWjAu6a/e6SLyqv1l+EbhzJztlpkZyrewag9fwQBcS+JH3w4ZUhG 2Mc0rLb5yc9KSvmJ7gctfQqAZGkTgzoqJhVnQQ0jJlip4R+luoAGX7ac0 Q9sNSxYUA3q4N6/lN68okxO32k4gGN3d3dTA/jwnaOVyGHcXGAZ6lM9sQ xdJSnzOr/HiT5x2xqzUu+f6LiQt9/n9LFAqYYQDigBFGweQ267zZyTliq Yv+oMBw2hRc3NFlYFoadFAMGHONObsd3ihY9D0lbVALCOnWlJ8v7qhltj bXYKLoXwll9gwsm80Rd5TQ7VRgsiHP+iGhcW55IXm75t0JfWtRCjBgXKb w==; X-IronPort-AV: E=McAfee;i="6600,9927,10846"; a="448319069" X-IronPort-AV: E=Sophos;i="6.03,181,1694761200"; d="scan'208";a="448319069" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2023 06:47:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10846"; a="698888049" X-IronPort-AV: E=Sophos;i="6.03,181,1694761200"; d="scan'208";a="698888049" Received: from linux.intel.com ([10.54.29.200]) by orsmga003.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2023 06:47:34 -0700 Received: from [10.209.178.226] (kliang2-mobl1.ccr.corp.intel.com [10.209.178.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id A8EA058068A; Wed, 27 Sep 2023 06:47:32 -0700 (PDT) Message-ID: <8a6b9556-c82c-4253-a4c1-74d696ad26df@linux.intel.com> Date: Wed, 27 Sep 2023 09:47:31 -0400 Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v2 1/3] perf vendor events intel: Fix broadwellde tma_info_system_dram_bw_use metric Content-Language: en-US To: Ian Rogers , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Perry Taylor , Caleb Biggers References: <20230926205948.1399594-1-irogers@google.com> From: "Liang, Kan" In-Reply-To: <20230926205948.1399594-1-irogers@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On 2023-09-26 4:59 p.m., Ian Rogers wrote: > Broadwell-de has a consumer core and server uncore. The uncore_arb PMU > isn't present and the broadwellx style cbox PMU should be used > instead. Fix the tma_info_system_dram_bw_use metric to use the server > metric rather than client. > > The associated converter script fix is in: > https://github.com/intel/perfmon/pull/111 > > Fixes: 7d124303d620 ("perf vendor events intel: Update broadwell variant events/metrics") > Signed-off-by: Ian Rogers > --- Thanks Ian. The whole patch series looks good to me. Reviewed-by: Kan Liang Thanks, Kan > tools/perf/pmu-events/arch/x86/broadwellde/bdwde-metrics.json | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/pmu-events/arch/x86/broadwellde/bdwde-metrics.json b/tools/perf/pmu-events/arch/x86/broadwellde/bdwde-metrics.json > index 8fc62b8f667d..d0ef46c9bb61 100644 > --- a/tools/perf/pmu-events/arch/x86/broadwellde/bdwde-metrics.json > +++ b/tools/perf/pmu-events/arch/x86/broadwellde/bdwde-metrics.json > @@ -652,7 +652,7 @@ > }, > { > "BriefDescription": "Average external Memory Bandwidth Use for reads and writes [GB / sec]", > - "MetricExpr": "64 * (arb@event\\=0x81\\,umask\\=0x1@ + arb@event\\=0x84\\,umask\\=0x1@) / 1e6 / duration_time / 1e3", > + "MetricExpr": "64 * (UNC_M_CAS_COUNT.RD + UNC_M_CAS_COUNT.WR) / 1e9 / duration_time", > "MetricGroup": "HPC;Mem;MemoryBW;SoC;tma_issueBW", > "MetricName": "tma_info_system_dram_bw_use", > "PublicDescription": "Average external Memory Bandwidth Use for reads and writes [GB / sec]. Related metrics: tma_fb_full, tma_mem_bandwidth, tma_sq_full"