From: James Clark <james.clark@linaro.org>
To: Leo Yan <leo.yan@arm.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH 11/25] perf arm_spe: Report MTE allocation tag in record
Date: Thu, 9 Oct 2025 10:32:08 +0100 [thread overview]
Message-ID: <94dcea04-c2ab-4fc0-b61c-ac2c1a8d6a8c@linaro.org> (raw)
In-Reply-To: <20250929-perf_support_arm_spev1-3-v1-11-1150b3c83857@arm.com>
On 29/09/2025 5:37 pm, Leo Yan wrote:
> Save MTE tag info in memory record.
>
> Signed-off-by: Leo Yan <leo.yan@arm.com>
> ---
> tools/perf/util/arm-spe-decoder/arm-spe-decoder.c | 2 ++
> tools/perf/util/arm-spe-decoder/arm-spe-decoder.h | 3 ++-
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c b/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
> index 804dce129121b9d2600be01af7f1f2780a9d0fc9..6696448bdf4f347e2032a1b4da46fcdd4016f9fc 100644
> --- a/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
> +++ b/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
> @@ -209,6 +209,8 @@ static int arm_spe_read_record(struct arm_spe_decoder *decoder)
> decoder->record.op |= ARM_SPE_OP_UNSPEC_REG;
> } else if (SPE_OP_PKT_LDST_SUBCLASS_NV_SYSREG(payload)) {
> decoder->record.op |= ARM_SPE_OP_NV_SYSREG;
> + } else if (SPE_OP_PKT_LDST_SUBCLASS_MTE_TAG(payload)) {
> + decoder->record.op |= ARM_SPE_OP_MTE_TAG;
> } else if (SPE_OP_PKT_LDST_SUBCLASS_SVE_SME_REG(payload)) {
> decoder->record.op |= ARM_SPE_OP_SVE;
> }
> diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-decoder.h b/tools/perf/util/arm-spe-decoder/arm-spe-decoder.h
> index 08ef83cb8bf00be75459c78b9ee8a6cbf1971986..9b7b6c42505f43c32a188b6e9769390f057adce8 100644
> --- a/tools/perf/util/arm-spe-decoder/arm-spe-decoder.h
> +++ b/tools/perf/util/arm-spe-decoder/arm-spe-decoder.h
> @@ -42,7 +42,8 @@ enum arm_spe_op_type {
> ARM_SPE_OP_UNSPEC_REG = 1 << 9,
> ARM_SPE_OP_NV_SYSREG = 1 << 10,
> ARM_SPE_OP_SIMD_FP = 1 << 11,
> - ARM_SPE_OP_SVE = 1 << 12,
> + ARM_SPE_OP_MTE_TAG = 1 << 12,
> + ARM_SPE_OP_SVE = 1 << 13,
Changing the bit position of ARM_SPE_OP_SVE looks like a mistake. Don't
we just need to add ARM_SPE_OP_MTE_TAG at bit 13?
>
> /* Assisted information for memory / SIMD */
> ARM_SPE_OP_LD = 1 << 20,
>
next prev parent reply other threads:[~2025-10-09 9:32 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-29 16:37 [PATCH 00/25] perf arm_spe: Extend operations Leo Yan
2025-09-29 16:37 ` [PATCH 01/25] perf arm_spe: Fix memset subclass in operation Leo Yan
2025-09-29 16:37 ` [PATCH 02/25] perf arm_spe: Unify operation naming Leo Yan
2025-09-29 16:37 ` [PATCH 03/25] perf arm_spe: Decode GCS operation Leo Yan
2025-09-29 16:37 ` [PATCH 04/25] perf arm_spe: Rename SPE_OP_PKT_IS_OTHER_SVE_OP macro Leo Yan
2025-09-29 16:37 ` [PATCH 05/25] perf arm_spe: Decode ASE and FP fields in other operation Leo Yan
2025-10-09 9:04 ` James Clark
2025-10-09 9:06 ` James Clark
2025-09-29 16:37 ` [PATCH 06/25] perf arm_spe: Decode SME data processing packet Leo Yan
2025-09-29 16:37 ` [PATCH 07/25] perf arm_spe: Remove unused operation types Leo Yan
2025-09-29 16:37 ` [PATCH 08/25] perf arm_spe: Consolidate " Leo Yan
2025-10-09 9:18 ` James Clark
2025-09-29 16:37 ` [PATCH 09/25] perf arm_spe: Introduce data processing macro for SVE operations Leo Yan
2025-09-29 16:37 ` [PATCH 10/25] perf arm_spe: Report register access in record Leo Yan
2025-09-29 16:37 ` [PATCH 11/25] perf arm_spe: Report MTE allocation tag " Leo Yan
2025-10-09 9:32 ` James Clark [this message]
2025-09-29 16:37 ` [PATCH 12/25] perf arm_spe: Report extended memory operations in records Leo Yan
2025-09-29 16:37 ` [PATCH 13/25] perf arm_spe: Report associated info for SVE / SME operations Leo Yan
2025-09-29 16:37 ` [PATCH 14/25] perf arm_spe: Report memset and memcpy in records Leo Yan
2025-10-09 9:33 ` James Clark
2025-09-29 16:37 ` [PATCH 15/25] perf arm_spe: Report GCS in record Leo Yan
2025-09-29 16:37 ` [PATCH 16/25] perf arm_spe: Expose SIMD information in other operations Leo Yan
2025-09-29 16:37 ` [PATCH 17/25] perf arm_spe: Expose length for SVE and SME operations Leo Yan
2025-10-09 9:45 ` James Clark
2025-09-29 16:37 ` [PATCH 18/25] perf arm_spe: Synthesize memory samples for SIMD operations Leo Yan
2025-09-29 16:37 ` [PATCH 19/25] perf/uapi: Extend data source fields Leo Yan
2025-10-09 10:00 ` James Clark
2025-09-29 16:37 ` [PATCH 20/25] perf mem: Print extended fields Leo Yan
2025-10-09 10:02 ` James Clark
2025-10-09 12:49 ` Arnaldo Carvalho de Melo
2025-09-29 16:37 ` [PATCH 21/25] perf arm_spe: Set extended fields in data source Leo Yan
2025-09-29 16:37 ` [PATCH 22/25] perf sort: Support sort ASE and SME Leo Yan
2025-10-09 10:05 ` James Clark
2025-09-29 16:37 ` [PATCH 23/25] perf sort: Sort disabled and full predicated flags Leo Yan
2025-09-29 16:38 ` [PATCH 24/25] perf report: Update document for SIMD flags Leo Yan
2025-09-29 16:38 ` [PATCH 25/25] perf arm_spe: Improve SIMD flags setting Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94dcea04-c2ab-4fc0-b61c-ac2c1a8d6a8c@linaro.org \
--to=james.clark@linaro.org \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).