From: Adrian Hunter <adrian.hunter@intel.com>
To: Chengdong Li <brytonlee01@gmail.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
jolsa@redhat.com, namhyung@kernel.org
Cc: ak@linux.intel.com, likexu@tencent.com, chengdongli@tencent.com
Subject: Re: [PATCH] perf test tsc: Fix error message report when not supported.
Date: Mon, 4 Apr 2022 07:41:59 +0300 [thread overview]
Message-ID: <9914dba4-7ff0-b6a3-cf6e-bdc426bc594c@intel.com> (raw)
In-Reply-To: <20220402114218.14131-1-chengdongli@tencent.com>
On 02/04/2022 14.42, Chengdong Li wrote:
> By default `perf test tsc` does not return the error message
> when child process detected kernel does not support. Instead, child
> process print error message to stderr, unfortunately the stderr is
> redirected to /dev/null when verbose <= 0.
> This patch add a helper function test__perf_test_tsc_skip_reason() to
> help parent process to get the appropriate error message and force child
> process returns TEST_SKIP instead of TEST_OK.
>
> Signed-off-by: Chengdong Li <chengdongli@tencent.com>
> ---
> tools/perf/tests/builtin-test.c | 3 +++
> tools/perf/tests/perf-time-to-tsc.c | 17 +++++++++++------
> tools/perf/tests/tests.h | 1 +
> 3 files changed, 15 insertions(+), 6 deletions(-)
>
Please base on current source, for example perf/core branch of:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git
prev parent reply other threads:[~2022-04-04 4:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-02 11:42 [PATCH] perf test tsc: Fix error message report when not supported Chengdong Li
2022-04-04 4:41 ` Adrian Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9914dba4-7ff0-b6a3-cf6e-bdc426bc594c@intel.com \
--to=adrian.hunter@intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=brytonlee01@gmail.com \
--cc=chengdongli@tencent.com \
--cc=jolsa@redhat.com \
--cc=likexu@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).