From: Robin Murphy <robin.murphy@arm.com>
To: Srinivasarao Pathipati <quic_spathi@quicinc.com>,
will@kernel.org, mark.rutland@arm.com, peterz@infradead.org,
mingo@redhat.com, acme@kernel.org,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
namhyung@kernel.org, catalin.marinas@arm.com,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V1] arm64: perf: Change PMCR write to read-modify-write
Date: Wed, 27 Apr 2022 11:16:11 +0100 [thread overview]
Message-ID: <99352dbe-c7dd-73da-3e48-807dcaea3e91@arm.com> (raw)
In-Reply-To: <1651053105-11557-1-git-send-email-quic_spathi@quicinc.com>
On 2022-04-27 10:51, Srinivasarao Pathipati wrote:
> Preserve the bitfields of PMCR_EL0 during PMU reset.
> Reset routine should set only PMCR.C, PMCR.P and PMCR.LC fields only
> to reset the counters. Other fields should not be changed
> as they could be set before PMU initialization and their value must
> be preserved even after reset.
No. We also want to ensure PMCR.E and PMCR.D are set to 0, for example.
Given that nearly all the writeable fields in PMCR reset to an
architecturally UNKNOWN value, preserving that is clearly nonsense.
What's your *real* motivation here?
Thanks,
Robin.
> Signed-off-by: Srinivasarao Pathipati <quic_spathi@quicinc.com>
> ---
> arch/arm64/kernel/perf_event.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c
> index cb69ff1..9e22326 100644
> --- a/arch/arm64/kernel/perf_event.c
> +++ b/arch/arm64/kernel/perf_event.c
> @@ -1047,7 +1047,7 @@ static void armv8pmu_reset(void *info)
> if (armv8pmu_has_long_event(cpu_pmu))
> pmcr |= ARMV8_PMU_PMCR_LP;
>
> - armv8pmu_pmcr_write(pmcr);
> + armv8pmu_pmcr_write(armv8pmu_pmcr_read() | pmcr);
> }
>
> static int __armv8_pmuv3_map_event(struct perf_event *event,
next prev parent reply other threads:[~2022-04-27 10:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 9:51 [PATCH V1] arm64: perf: Change PMCR write to read-modify-write Srinivasarao Pathipati
2022-04-27 10:16 ` Robin Murphy [this message]
2022-04-27 11:09 ` Srinivasarao Pathipati (Consultant)
2022-04-27 11:49 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99352dbe-c7dd-73da-3e48-807dcaea3e91@arm.com \
--to=robin.murphy@arm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=catalin.marinas@arm.com \
--cc=jolsa@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=quic_spathi@quicinc.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox