From: "Liang, Kan" <kan.liang@linux.intel.com>
To: Xiongfeng Wang <wangxiongfeng2@huawei.com>,
adrian.hunter@intel.com, peterz@infradead.org,
ak@linux.intel.com, alexander.shishkin@linux.intel.com,
alexander.antonov@linux.intel.com, acme@kernel.org,
jolsa@kernel.org
Cc: linux-perf-users@vger.kernel.org, yangyingliang@huawei.com
Subject: Re: [PATCH v5 0/4] perf/x86/intel/uncore: Fix PCI device reference count leak
Date: Fri, 18 Nov 2022 07:33:20 -0500 [thread overview]
Message-ID: <9c74afc2-e349-881a-7326-31ddf00bf00c@linux.intel.com> (raw)
In-Reply-To: <20221118063137.121512-1-wangxiongfeng2@huawei.com>
On 2022-11-18 1:31 a.m., Xiongfeng Wang wrote:
> pci_get_device() will increase the reference count for the returned
> pci_dev, and also decrease the reference count for the input parameter
> *from* if it is not NULL. We add missing pci_dev_put() to decrease the
> reference count.
>
>
> ChangeLog:
> v1->v2:
> move pci_dev_put() to the last of function sad_cfg_iio_topology()
> add fixes for snr_uncore_mmio_map(), hswep_has_limit_sbox() and __uncore_imc_init_box()
> v2->v3:
> split one patch into several patches, one patch for one fix
> v3->v4:
> change 'pci_dev_put(pdev)' to 'pci_dev_put(dev)' in the first patch
> v4->v5:
> move the pci_dev_put() to avoid patching it twice
Thanks Xiongfeng. The series looks good to me.
Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
Thanks,
Kan
> Xiongfeng Wang (4):
> perf/x86/intel/uncore: Fix reference count leak in
> sad_cfg_iio_topology()
> perf/x86/intel/uncore: Fix reference count leak in
> hswep_has_limit_sbox()
> perf/x86/intel/uncore: Fix reference count leak in
> snr_uncore_mmio_map()
> perf/x86/intel/uncore: Fix reference count leak in
> __uncore_imc_init_box()
>
> arch/x86/events/intel/uncore_snb.c | 3 +++
> arch/x86/events/intel/uncore_snbep.c | 5 +++++
> 2 files changed, 8 insertions(+)
>
prev parent reply other threads:[~2022-11-18 12:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 6:31 [PATCH v5 0/4] perf/x86/intel/uncore: Fix PCI device reference count leak Xiongfeng Wang
2022-11-18 6:31 ` [PATCH v5 1/4] perf/x86/intel/uncore: Fix reference count leak in sad_cfg_iio_topology() Xiongfeng Wang
2022-11-18 6:31 ` [PATCH v5 2/4] perf/x86/intel/uncore: Fix reference count leak in hswep_has_limit_sbox() Xiongfeng Wang
2022-11-18 6:31 ` [PATCH v5 3/4] perf/x86/intel/uncore: Fix reference count leak in snr_uncore_mmio_map() Xiongfeng Wang
2022-11-18 6:31 ` [PATCH v5 4/4] perf/x86/intel/uncore: Fix reference count leak in __uncore_imc_init_box() Xiongfeng Wang
2022-11-18 12:33 ` Liang, Kan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c74afc2-e349-881a-7326-31ddf00bf00c@linux.intel.com \
--to=kan.liang@linux.intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.antonov@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=wangxiongfeng2@huawei.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).