Linux Perf Users
 help / color / mirror / Atom feed
From: Athira Rajeev <atrajeev@linux.ibm.com>
To: sashiko@lists.linux.dev
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH V3 2/2] tools/perf: Add kernel-doc comment to auxtrace_record__init() function
Date: Sat, 2 May 2026 14:00:02 +0530	[thread overview]
Message-ID: <C36AD9FA-6A1F-4F22-9969-9C54B2A72ED7@linux.ibm.com> (raw)
In-Reply-To: <20260502081055.8D980C19425@smtp.kernel.org>



> On 2 May 2026, at 1:40 PM, sashiko-bot@kernel.org wrote:
> 
> Is this description for case 'c' completely accurate?
> 
> Looking at the architecture-specific implementations, such as the one in
> tools/perf/arch/x86/util/auxtrace.c, it appears the function can return
> positive error codes. For instance, the x86 implementation calls get_cpuid(),
> which returns ENOBUFS (a positive integer) on failure. This positive value
> is then assigned to *err before returning NULL.
> 
> Could this comment be updated to reflect that *err can be any non-zero
> value on failure, rather than strictly less than zero?

Sure

I will update this in next version

Thanks
Athira



      reply	other threads:[~2026-05-02  8:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-02  7:39 [PATCH V3 1/2] powerpc tools perf: Initialize error code in auxtrace_record_init function Athira Rajeev
2026-05-02  7:39 ` [PATCH V3 2/2] tools/perf: Add kernel-doc comment to auxtrace_record__init() function Athira Rajeev
2026-05-02  8:10   ` sashiko-bot
2026-05-02  8:30     ` Athira Rajeev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C36AD9FA-6A1F-4F22-9969-9C54B2A72ED7@linux.ibm.com \
    --to=atrajeev@linux.ibm.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox