From: Linus Walleij <linus.walleij@linaro.org>
To: Li Huafei <lihuafei1@huawei.com>
Cc: linux@armlinux.org.uk, rmk+kernel@armlinux.org.uk,
ardb@kernel.org, will@kernel.org, broonie@kernel.org,
mark.rutland@arm.com, peterz@infradead.org, mingo@redhat.com,
acme@kernel.org, alexander.shishkin@linux.intel.com,
jolsa@kernel.org, namhyung@kernel.org, arnd@arndb.de,
rostedt@goodmis.org, nick.hawkins@hpe.com, john@phrozen.org,
mhiramat@kernel.org, ast@kernel.org, linyujun809@huawei.com,
ndesaulniers@google.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v2 0/5] ARM: Convert to ARCH_STACKWALK
Date: Mon, 18 Jul 2022 11:14:37 +0200 [thread overview]
Message-ID: <CACRpkdYmwojupt_024LKA2B0e7zBKmreYYX3ZMC56i5Vrr3fFA@mail.gmail.com> (raw)
In-Reply-To: <20220713110020.85511-1-lihuafei1@huawei.com>
On Wed, Jul 13, 2022 at 1:02 PM Li Huafei <lihuafei1@huawei.com> wrote:
> This series mainly updates the ARM stack trace code to use the newer and
> simpler arch_stack_walk() interface. Two issues were fixed before that
> (see patch 1 and 2), as well as allowing stack_trace_save_tsk() to
> trace non-current tasks (see patch 3).
>
> v2:
> - As suggested by Mark, the commit logs for patch 4 and 5 were
> refined for easy review.
I see I reviewed v1 when v2 was already out but think the
comments still stand.
I think you can already add patches 1 & 2 to Russells patch tracker,
they are straight-forward fixes.
Patches 3-5 may need some elaboration but I trust that you have
done some serious testing since you found the snags in
patches 1 & 2.
Yours,
Linus Walleij
prev parent reply other threads:[~2022-07-18 9:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 11:00 [PATCH v2 0/5] ARM: Convert to ARCH_STACKWALK Li Huafei
2022-07-13 11:00 ` [PATCH v2 1/5] ARM: stacktrace: Skip frame pointer boundary check for call_with_stack() Li Huafei
2022-07-13 11:00 ` [PATCH v2 2/5] ARM: stacktrace: Avoid duplicate saving of exception PC value Li Huafei
2022-07-13 11:00 ` [PATCH v2 3/5] ARM: stacktrace: Allow stack trace saving for non-current tasks Li Huafei
2022-07-13 11:00 ` [PATCH v2 4/5] ARM: stacktrace: Make stack walk callback consistent with generic code Li Huafei
2022-07-13 11:00 ` [PATCH v2 5/5] ARM: stacktrace: Convert stacktrace to generic ARCH_STACKWALK Li Huafei
2022-07-18 9:14 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYmwojupt_024LKA2B0e7zBKmreYYX3ZMC56i5Vrr3fFA@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=ast@kernel.org \
--cc=broonie@kernel.org \
--cc=john@phrozen.org \
--cc=jolsa@kernel.org \
--cc=lihuafei1@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linyujun809@huawei.com \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nick.hawkins@hpe.com \
--cc=peterz@infradead.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=rostedt@goodmis.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).