From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5990EEAA41 for ; Thu, 14 Sep 2023 13:52:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239287AbjINNwD (ORCPT ); Thu, 14 Sep 2023 09:52:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239257AbjINNwD (ORCPT ); Thu, 14 Sep 2023 09:52:03 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6343310C7 for ; Thu, 14 Sep 2023 06:51:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694699472; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K1aANZQtwFDU4g/VWeNDGent7e6hMjtrdWucBBS3aak=; b=UQayGSK0b+mo+8T73EKI4aswLlWNmA+SCTxy60guCh+txhUtztqv/9QdZlWT/WDSMkZ+dU Ezwo5wdKzderosmHKpLX5sUu+NHWzoTTbkUHh+1lmiAyeo8LMqq0f8uZg7YW0n4h8pz/0U 3jxdxfrux3UahoECUgVa93amRt92SRo= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-241-QbHkFOy_NtaqCk3dSxQHhw-1; Thu, 14 Sep 2023 09:51:10 -0400 X-MC-Unique: QbHkFOy_NtaqCk3dSxQHhw-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2bcec24e8f8so12504821fa.1 for ; Thu, 14 Sep 2023 06:51:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694699469; x=1695304269; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K1aANZQtwFDU4g/VWeNDGent7e6hMjtrdWucBBS3aak=; b=vWEQvA+joLhx/FLvSnFaW6fEaEuJhQRthRsRcnQ+H6QQnNK71AdOwvjnoUxkPhfEMg MYTk2hK7iWf3uPqMJfpj+0SWW+wVodyJ+w8VBKkwV1BAuh+SO7eE7jbcLEx+2ExOrGQn skR0LUssFFD+eHS72dd5NHsQVQ9GxiceNed/wNejEBfKK6V7Oaz0BxURSDXPz1GYhnnC Pz0o3y5nBmXa04q0BSlhBIE9mgMVzxs7j1HiMfBCCiMQyn/+hMO2K7+3je1SEwhRvvBf u59PVCMqVXeQrgJz5YBbYZNzreC+KHXNWMa4sWaGQpbCze/YiWWA5ymD8znRzz7oB3vE Z4+g== X-Gm-Message-State: AOJu0Yzos7K3wLO7I6MaeBtz411pldQrK/ZTtBwoYfmz8Yqf6wARhx/d bUqbCuisfW3j+LV8cO9itXsEsTB3Ff4oG0BDuaXnI6zeA3abZPyfX9WtQQ/bQfTD7xRY7ysieyq eDw7uzTIKVI6VxryyXsWK0mIPG2oSxn2yXrRYC3G1NvfnYQ== X-Received: by 2002:a2e:924d:0:b0:2bc:bf29:18d3 with SMTP id v13-20020a2e924d000000b002bcbf2918d3mr4921025ljg.31.1694699469464; Thu, 14 Sep 2023 06:51:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGK7INPPlpWH23+iLmgrvRbIbOe157ZE8DmeGxtMRrlh2im4vwq15gUMK1Q785CMuTKK3cW1Ha9IbpSxNndAO8= X-Received: by 2002:a2e:924d:0:b0:2bc:bf29:18d3 with SMTP id v13-20020a2e924d000000b002bcbf2918d3mr4921011ljg.31.1694699469086; Thu, 14 Sep 2023 06:51:09 -0700 (PDT) MIME-Version: 1.0 References: <20230616115316.3652155-1-leitao@debian.org> <20230616132954.GG4253@hirez.programming.kicks-ass.net> <20230914091234.GE16631@noisy.programming.kicks-ass.net> <20230914111845.GF16631@noisy.programming.kicks-ass.net> In-Reply-To: From: Jirka Hladky Date: Thu, 14 Sep 2023 15:50:57 +0200 Message-ID: Subject: Re: [PATCH] perf/x86/amd: Do not WARN on every IRQ To: Breno Leitao Cc: Sandipan Das , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Thomas Gleixner , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , leit@fb.com, dcostantino@meta.com, "open list:PERFORMANCE EVENTS SUBSYSTEM" , "open list:PERFORMANCE EVENTS SUBSYSTEM" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Thank you, all! I have confirmed that the latest microcode fixes the issue. =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D cat /proc/cpuinfo microcode : 0xaa00212 perf top runs fine, without any kernel warnings =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Jirka On Thu, Sep 14, 2023 at 2:22=E2=80=AFPM Breno Leitao wr= ote: > > On Thu, Sep 14, 2023 at 04:52:13PM +0530, Sandipan Das wrote: > > On 9/14/2023 4:48 PM, Peter Zijlstra wrote: > > > On Thu, Sep 14, 2023 at 02:30:43AM -0700, Breno Leitao wrote: > > >> On Thu, Sep 14, 2023 at 11:12:34AM +0200, Peter Zijlstra wrote: > > >>> On Thu, Sep 14, 2023 at 02:25:40PM +0530, Sandipan Das wrote: > > >> > > >>>> I agree with using WARN_ON_ONCE() to make this less intrusive. > > >>> > > >>> Could you send a patch that AMD is happy with? > > >> > > >> Why the current patch is not good enough? > > > > > > Sandipan, can you answer this? I don't tihnk I'm qualified to speak f= or > > > the AMD pmu and certainly I don't have insight into their design futu= re. > > > > Hi Breno, > > > > Functionally, the patch looks good to me and I will be reusing it > > without any change to the authorship. However, as Peter suggested, I > > wanted to add a message to prompt users to update the microcode and > > also call out the required patch levels in the commit message since > > different Zen 4 variants and steppings use different microcode. > > > > Here's what I plan to send. > > Awesome. Thanks for addressing it. > --=20 -Jirka