From: yunhui cui <cuiyunhui@bytedance.com>
To: Doug Anderson <dianders@chromium.org>
Cc: paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, alex@ghiti.fr, atish.patra@linux.dev,
anup@brainfault.org, will@kernel.org, mark.rutland@arm.com,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org, catalin.marinas@arm.com,
masahiroy@kernel.org, suzuki.poulose@arm.com, maz@kernel.org,
zhanjie9@hisilicon.com, yangyicong@hisilicon.com,
mingo@kernel.org, lihuafei1@huawei.com,
akpm@linux-foundation.org, jpoimboe@kernel.org, rppt@kernel.org,
kees@kernel.org, thomas.weissschuh@linutronix.de
Subject: Re: [External] Re: [PATCH 1/2] watchdog: refactor watchdog_hld functionality
Date: Mon, 1 Sep 2025 13:57:20 +0800 [thread overview]
Message-ID: <CAEEQ3wmBvevbkP8XmwR0_q_1QWQsie5g0UUxTFm6ovS1m41pEQ@mail.gmail.com> (raw)
In-Reply-To: <CAD=FV=WiZ5=4Ck3G2gme=ey6uYQhi-3Wo32DpLj9P53wxGCojw@mail.gmail.com>
Hi Doug,
On Sat, Aug 30, 2025 at 5:34 AM Doug Anderson <dianders@chromium.org> wrote:
>
> Hi,
>
> On Wed, Aug 27, 2025 at 3:10 AM Yunhui Cui <cuiyunhui@bytedance.com> wrote:
> >
> > Move watchdog_hld.c to kernel/, and rename arm_pmu_irq_is_nmi()
> > to arch_pmu_irq_is_nmi() for cross-arch reusability.
> >
> > Signed-off-by: Yunhui Cui <cuiyunhui@bytedance.com>
> > ---
> > arch/arm64/kernel/Makefile | 1 -
> > drivers/perf/arm_pmu.c | 2 +-
> > include/linux/nmi.h | 1 +
> > include/linux/perf/arm_pmu.h | 2 --
> > kernel/Makefile | 2 +-
> > {arch/arm64/kernel => kernel}/watchdog_hld.c | 8 ++++++--
> > 6 files changed, 9 insertions(+), 7 deletions(-)
> > rename {arch/arm64/kernel => kernel}/watchdog_hld.c (97%)
>
> I'm not a huge fan of the perf hardlockup detector and IMO we should
> maybe just delete it. Thus spreading it to support a new architecture
> isn't my favorite thing to do. Can't you use the buddy hardlockup
> detector?
Why is there a plan to remove CONFIG_HARDLOCKUP_DETECTOR_PERF? Could
you explain the specific reasons? Is the community's future plan to
favor CONFIG_HARDLOCKUP_DETECTOR_BUDDY?
>
> That being said, I did a quick look at your patch. I'm pretty sure you
> can't just move the arm64 "watchdog_hld.c" to be generic. Won't
> hw_nmi_get_sample_period() conflict with everyone else's (x86 and
> powerpc)?
>
> -Doug
>
Thanks,
Yunhui
next prev parent reply other threads:[~2025-09-01 5:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-27 10:09 [PATCH 0/2] Add HARDLOCKUP_DETECTOR_PERF for riscv Yunhui Cui
2025-08-27 10:09 ` [PATCH 1/2] watchdog: refactor watchdog_hld functionality Yunhui Cui
2025-08-29 21:33 ` Doug Anderson
2025-09-01 5:57 ` yunhui cui [this message]
2025-09-02 17:03 ` [External] " Doug Anderson
2025-09-03 11:56 ` yunhui cui
2025-09-05 23:57 ` Doug Anderson
2025-08-27 10:09 ` [PATCH 2/2] riscv: add HARDLOCKUP_DETECTOR_PERF support Yunhui Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEEQ3wmBvevbkP8XmwR0_q_1QWQsie5g0UUxTFm6ovS1m41pEQ@mail.gmail.com \
--to=cuiyunhui@bytedance.com \
--cc=akpm@linux-foundation.org \
--cc=alex@ghiti.fr \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@linux.dev \
--cc=catalin.marinas@arm.com \
--cc=dianders@chromium.org \
--cc=jpoimboe@kernel.org \
--cc=kees@kernel.org \
--cc=lihuafei1@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=masahiroy@kernel.org \
--cc=maz@kernel.org \
--cc=mingo@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=rppt@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=thomas.weissschuh@linutronix.de \
--cc=will@kernel.org \
--cc=yangyicong@hisilicon.com \
--cc=zhanjie9@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).