From: Y Song <ys114321@gmail.com>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
netdev <netdev@vger.kernel.org>, Wang Nan <wangnan0@huawei.com>,
Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
Martin KaFai Lau <kafai@fb.com>, bpf <bpf@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-snps-arc@lists.infradead.org,
linux-perf-users@vger.kernel.org, arnaldo.melo@gmail.com
Subject: Re: [PATCH v2] tools/bpf: fix perf build error with uClibc (seen on ARC)
Date: Thu, 2 May 2019 13:19:27 -0700 [thread overview]
Message-ID: <CAH3MdRWkiFSRA+PRo53_Syx9OBmyj2U_ebap-9iBR8L7xW9UVw@mail.gmail.com> (raw)
In-Reply-To: <1556812610-27957-1-git-send-email-vgupta@synopsys.com>
On Thu, May 2, 2019 at 8:57 AM Vineet Gupta <Vineet.Gupta1@synopsys.com> wrote:
>
> When build perf for ARC recently, there was a build failure due to lack
> of __NR_bpf.
>
> | Auto-detecting system features:
> |
> | ... get_cpuid: [ OFF ]
> | ... bpf: [ on ]
> |
> | # error __NR_bpf not defined. libbpf does not support your arch.
> ^~~~~
> | bpf.c: In function 'sys_bpf':
> | bpf.c:66:17: error: '__NR_bpf' undeclared (first use in this function)
> | return syscall(__NR_bpf, cmd, attr, size);
> | ^~~~~~~~
> | sys_bpf
>
> Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
Acked-by: Yonghong Song <yhs@fb.com>
> ---
> v1 -> v2
> - Only add syscall nr for ARC, as asm-generic won't work with arm/sh [Y Song]
> ---
> tools/lib/bpf/bpf.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/lib/bpf/bpf.c b/tools/lib/bpf/bpf.c
> index 9cd015574e83..d82edadf7589 100644
> --- a/tools/lib/bpf/bpf.c
> +++ b/tools/lib/bpf/bpf.c
> @@ -46,6 +46,8 @@
> # define __NR_bpf 349
> # elif defined(__s390__)
> # define __NR_bpf 351
> +# elif defined(__arc__)
> +# define __NR_bpf 280
> # else
> # error __NR_bpf not defined. libbpf does not support your arch.
> # endif
> --
> 2.7.4
>
next prev parent reply other threads:[~2019-05-02 20:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 22:53 [PATCH] tools/bpf: fix perf build error with uClibc (seen on ARC) Vineet Gupta
2019-05-02 6:31 ` Y Song
2019-05-02 15:56 ` [PATCH v2] " Vineet Gupta
2019-05-02 20:19 ` Y Song [this message]
2019-05-05 7:05 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH3MdRWkiFSRA+PRo53_Syx9OBmyj2U_ebap-9iBR8L7xW9UVw@mail.gmail.com \
--to=ys114321@gmail.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=arnaldo.melo@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kafai@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=wangnan0@huawei.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).