From: Guo Ren <guoren@kernel.org>
To: Conor Dooley <conor@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
cp0613@linux.alibaba.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, pjw@kernel.org, palmer@dabbelt.com,
aou@eecs.berkeley.edu, peterz@infradead.org, mingo@redhat.com,
acme@kernel.org, namhyung@kernel.org, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
irogers@google.com, adrian.hunter@intel.com,
james.clark@linaro.org, devicetree@vger.kernel.org,
linux-perf-users@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: vendor-prefixes: Add prefix for XuanTie
Date: Fri, 21 Nov 2025 21:01:41 +0800 [thread overview]
Message-ID: <CAJF2gTRUmUHrTsOBM82kNq2cSYmeYr9NC_ORacUnqHAefFSaWw@mail.gmail.com> (raw)
In-Reply-To: <20251121-shortlist-coroner-b29e19293b40@spud>
On Fri, Nov 21, 2025 at 8:31 PM Conor Dooley <conor@kernel.org> wrote:
>
> On Fri, Nov 21, 2025 at 10:01:07AM +0100, Krzysztof Kozlowski wrote:
> > On Fri, Nov 21, 2025 at 02:34:36PM +0800, cp0613@linux.alibaba.com wrote:
> > > From: Chen Pei <cp0613@linux.alibaba.com>
> > >
> > > Add new vendor strings to dt bindings for RISC-V vendor XuanTie.
> > >
> > > Signed-off-by: Chen Pei <cp0613@linux.alibaba.com>
> > > ---
> > > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > > index f1d1882009ba..5d28b2da94cd 100644
> > > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > > @@ -1829,6 +1829,8 @@ patternProperties:
> > > description: Xilinx
> > > "^xnano,.*":
> > > description: Xnano
> > > + "^xuantie,.*":
> > > + description: C-SKY Microsystems Co., Ltd. (XuanTie)
> >
> > We do not create new prefixes for existing entries. You have already
> > csky, alibaba and thead and probably many more. Choose some appropriate.
We could leave the one C-SKY vendor entry, how about:
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -347,8 +347,8 @@ patternProperties:
description: Creative Technology Ltd
"^crystalfontz,.*":
description: Crystalfontz America, Inc.
- "^csky,.*":
- description: Hangzhou C-SKY Microsystems Co., Ltd
+ "^xuantie,.*":
+ description: C-SKY Microsystems Co., Ltd. (XuanTie)
"^csot,.*":
description: Guangzhou China Star Optoelectronics Technology Co., Ltd
"^csq,.*":
The arch/csky is the architecture name, which means "xuantie,csky".
The c810 is the CPU product name, which means "xuantie,c810" of the
"xuantie,csky" architecture.
The c930 is the CPU product name, which means "xuantie,c930".
>
> When the vendor literally says "C-SKY", it's hard to buy why csky
> shouldn't be used here. Xuantie is described as being a brand, where at
> least t-head was a company. This seems akin to having
> "snapdragon,msm8660" instead of "qcom,msm8660", for example.
Yes, XuanTie is not only a brand, but also the abbreviation of C-SKY
Microsystems Co., Ltd.
Just like:
"^100ask,.*":
description: Baiwen.com (100ask).
"^linksys,.*":
description: Belkin International, Inc. (Linksys)
>
> >
> > Your commit msg should also explain anything unusual here, like above.
> >
> > Best regards,
> > Krzysztof
> >
--
Best Regards
Guo Ren
next prev parent reply other threads:[~2025-11-21 13:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 6:34 [PATCH v2 0/4] perf vendor events riscv: Add XuanTie C930 JSON files cp0613
2025-11-21 6:34 ` [PATCH v2 1/4] dt-bindings: vendor-prefixes: Add prefix for XuanTie cp0613
2025-11-21 8:22 ` Guo Ren
2025-11-21 9:01 ` Krzysztof Kozlowski
2025-11-21 12:30 ` Conor Dooley
2025-11-21 13:01 ` Guo Ren [this message]
2025-11-21 17:22 ` Krzysztof Kozlowski
2025-11-21 6:34 ` [PATCH v2 2/4] dt-bindings: riscv: Add XuanTie C930 CPU compatible cp0613
2025-11-21 8:23 ` Guo Ren
2025-11-21 9:01 ` Krzysztof Kozlowski
2025-11-21 6:34 ` [PATCH v2 3/4] perf vendor events riscv: Add XuanTie C930 JSON file cp0613
2025-11-21 6:34 ` [PATCH v2 4/4] perf vendor events riscv: Add XuanTie C930 metrics cp0613
2025-11-21 9:02 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJF2gTRUmUHrTsOBM82kNq2cSYmeYr9NC_ORacUnqHAefFSaWw@mail.gmail.com \
--to=guoren@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=cp0613@linux.alibaba.com \
--cc=devicetree@vger.kernel.org \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=palmer@dabbelt.com \
--cc=peterz@infradead.org \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).