From: Masahiro Yamada <masahiroy@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-perf-users@vger.kernel.org, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH] treewide: remove meaningless assignments in Makefiles
Date: Fri, 23 Feb 2024 11:25:05 +0900 [thread overview]
Message-ID: <CAK7LNASch8P49gNagJ3OhMDqFNuzxcRRKatet2iedWFi76qoog@mail.gmail.com> (raw)
In-Reply-To: <CAM9d7cjQ0wbPu9NWcg_Rj66jcJ=6HoNMcTnfR4wvjaJ47FDVQA@mail.gmail.com>
On Fri, Feb 23, 2024 at 2:08 AM Namhyung Kim <namhyung@kernel.org> wrote:
>
> Hello,
>
> On Wed, Feb 21, 2024 at 5:42 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
> >
> > In Makefiles, $(error ), $(warning ), and $(info ) expand to the empty
> > string, as explained in the GNU Make manual [1]:
> > "The result of the expansion of this function is the empty string."
> >
> > Therefore, they are no-op except for logging purposes.
> >
> > $(shell ...) expands to the output of the command. It expands to the
> > empty string when the command does not print anything to stdout.
> > Hence, $(shell mkdir ...) is no-op except for creating the directory.
> >
> > Remove meaningless assignments.
> >
> > [1]: https://www.gnu.org/software/make/manual/make.html#Make-Control-Functions
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> > ---
> >
> > This is a treewide cleanup, but in practice, this is touching mostly
> > perf Makefiles. I am sending this to perf subsystem.
>
> How do you want to route this? I can take it to perf tree if you're ok.
Yes, that is my expectation because it will reduce the risk
of merge conflicts.
I only included the perf maintainers and ML to To:,
and anything else in CC:
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2024-02-23 2:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 13:42 [PATCH] treewide: remove meaningless assignments in Makefiles Masahiro Yamada
2024-02-21 14:39 ` Ian Rogers
2024-02-21 17:08 ` Arnaldo Carvalho de Melo
2024-02-22 17:08 ` Namhyung Kim
2024-02-23 2:25 ` Masahiro Yamada [this message]
2024-02-26 16:20 ` Namhyung Kim
2024-03-15 10:49 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNASch8P49gNagJ3OhMDqFNuzxcRRKatet2iedWFi76qoog@mail.gmail.com \
--to=masahiroy@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).