From: Namhyung Kim <namhyung@kernel.org>
To: German Gomez <german.gomez@arm.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
linux-perf-users <linux-perf-users@vger.kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Leo Yan <leo.yan@linaro.org>, Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, John Garry <john.garry@huawei.com>,
Will Deacon <will@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/4] perf arm-spe: Save context ID in record
Date: Wed, 10 Nov 2021 23:25:28 -0800 [thread overview]
Message-ID: <CAM9d7cgB_kemcZLL2FK6pHOEx_TkJ72YNFW03OR_Zyhn0yrmPg@mail.gmail.com> (raw)
In-Reply-To: <20211109115020.31623-4-german.gomez@arm.com>
Hello,
On Tue, Nov 9, 2021 at 3:50 AM German Gomez <german.gomez@arm.com> wrote:
>
> This patch is to save context ID in record, this will be used to set TID
> for samples.
>
> Signed-off-by: German Gomez <german.gomez@arm.com>
> Reviewed-by: Leo Yan <leo.yan@linaro.org>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
> ---
> tools/perf/util/arm-spe-decoder/arm-spe-decoder.c | 2 ++
> tools/perf/util/arm-spe-decoder/arm-spe-decoder.h | 1 +
> 2 files changed, 3 insertions(+)
>
> diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c b/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
> index 32fe41835..3fc528c92 100644
> --- a/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
> +++ b/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
> @@ -151,6 +151,7 @@ static int arm_spe_read_record(struct arm_spe_decoder *decoder)
> u64 payload, ip;
>
> memset(&decoder->record, 0x0, sizeof(decoder->record));
> + decoder->record.context_id = (u64)-1;
>
> while (1) {
> err = arm_spe_get_next_packet(decoder);
> @@ -180,6 +181,7 @@ static int arm_spe_read_record(struct arm_spe_decoder *decoder)
> case ARM_SPE_COUNTER:
> break;
> case ARM_SPE_CONTEXT:
> + decoder->record.context_id = payload;
> break;
> case ARM_SPE_OP_TYPE:
> if (idx == SPE_OP_PKT_HDR_CLASS_LD_ST_ATOMIC) {
> diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-decoder.h b/tools/perf/util/arm-spe-decoder/arm-spe-decoder.h
> index 59bdb7309..46a8556a9 100644
> --- a/tools/perf/util/arm-spe-decoder/arm-spe-decoder.h
> +++ b/tools/perf/util/arm-spe-decoder/arm-spe-decoder.h
> @@ -38,6 +38,7 @@ struct arm_spe_record {
> u64 timestamp;
> u64 virt_addr;
> u64 phys_addr;
> + u64 context_id;
> };
>
> struct arm_spe_insn;
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-11-11 7:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 11:50 [PATCH v2 0/4] perf arm-spe: Track pid/tid for Arm SPE samples German Gomez
2021-11-09 11:50 ` [PATCH v2 1/4] perf arm-spe: Track task context switch for cpu-mode events German Gomez
2021-11-09 11:50 ` [PATCH v2 2/4] perf arm-spe: Update --switch-events docs in perf-record German Gomez
2021-11-11 7:18 ` Leo Yan
2021-11-11 7:29 ` Namhyung Kim
2021-11-09 11:50 ` [PATCH v2 3/4] perf arm-spe: Save context ID in record German Gomez
2021-11-11 7:25 ` Namhyung Kim [this message]
2021-11-09 11:50 ` [PATCH v2 4/4] perf arm-spe: Support hardware-based PID tracing German Gomez
2021-11-11 7:28 ` Namhyung Kim
2021-11-11 7:41 ` Leo Yan
2021-11-11 7:59 ` Namhyung Kim
2021-11-11 8:30 ` Leo Yan
2021-11-11 12:23 ` German Gomez
2021-11-11 12:42 ` Leo Yan
2021-11-11 13:10 ` German Gomez
2021-11-11 7:27 ` [PATCH v2 0/4] perf arm-spe: Track pid/tid for Arm SPE samples Leo Yan
2021-11-11 13:26 ` Leo Yan
2021-11-11 14:49 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM9d7cgB_kemcZLL2FK6pHOEx_TkJ72YNFW03OR_Zyhn0yrmPg@mail.gmail.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=german.gomez@arm.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).