From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17462171D4 for ; Thu, 21 Sep 2023 18:52:14 +0000 (UTC) Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BFDCD255C; Thu, 21 Sep 2023 11:51:53 -0700 (PDT) Received: by mail-io1-f50.google.com with SMTP id ca18e2360f4ac-7926a450a0aso52351139f.3; Thu, 21 Sep 2023 11:51:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695322312; x=1695927112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rchX4DRYXaRpeH35NMA7XmzyCNvbFmAvUCyV3Dy7kro=; b=EAgSLHMY7ebbySOPs8wzAA61oBqb5X4bmrWyHpzVmUmmVn5AG+tKYlgv+mpXc8wJGO BdhWpjoK40OgljnZgJcVelVy2LXidJ07h8gJtDChTEkP/0XGX41lUD1AOfWpswR6jNb4 y8eqHdTxijY5rnSIqoLyfbzFSevF5Jg35Z8rNZnYyWe83jYZmZsrreUv407gq3AyVCQC z9xMbDornIUS3bZLWj86x543ZI1QJlIhmJEtdGUNuj/ZtsZHgLQcw69IzTzPOZrXZuvV xWsGLx2yFXVR6ayt3qJ0ppsqqjqYfZnpqVndtwNRNfjfNHbJ2Fxm5/LBwidSzfrjRRyK w+iQ== X-Gm-Message-State: AOJu0YxEvQfVBKdvGrgzMHUiCXYMw5md/SAyaR1HHC5uaki92eoVnfeE 4OoWCTaw24QiKh9SfPWZ8Qw3kX1Rkf4Fqse/08I= X-Google-Smtp-Source: AGHT+IGi2TUCiRCAaXRQw0xByOB3K1/tKIxEqPzBI1Y8i69hqsRmky+0j8LAafFwfOTSt3roH60z+9v0nyqUTtI0FnY= X-Received: by 2002:a6b:f404:0:b0:792:881d:c6ab with SMTP id i4-20020a6bf404000000b00792881dc6abmr7125847iog.18.1695322311775; Thu, 21 Sep 2023 11:51:51 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20230919080929.3807123-1-xu.yang_2@nxp.com> In-Reply-To: From: Namhyung Kim Date: Thu, 21 Sep 2023 11:51:40 -0700 Message-ID: Subject: Re: [EXT] Re: [PATCH] perf jevents: fix no member named 'entries' issue To: Xu Yang Cc: Ian Rogers , "peterz@infradead.org" , "mingo@redhat.com" , "acme@kernel.org" , "mark.rutland@arm.com" , "alexander.shishkin@linux.intel.com" , "jolsa@kernel.org" , "adrian.hunter@intel.com" , "linux-perf-users@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Tue, Sep 19, 2023 at 9:16=E2=80=AFPM Namhyung Kim = wrote: > > Hello, > > On Tue, Sep 19, 2023 at 7:07=E2=80=AFPM Xu Yang wrote= : > > > > Hi Lan, > > > > > On Tue, Sep 19, 2023 at 1:04=E2=80=AFAM Xu Yang w= rote: > > > > > > > > The struct "pmu_events_table" has been changed after commit > > > > 2e255b4f9f41 (perf jevents: Group events by PMU, 2023-08-23). > > > > So there doesn't exist 'entries' in pmu_events_table anymore. > > > > This will align the members with that commit. Othewise, below > > > > errors will be printed when run jevent.py: > > > > > > > > pmu-events/pmu-events.c:5485:26: error: =E2=80=98struct pmu_metrics= _table=E2=80=99 has no member named =E2=80=98entries=E2=80=99 > > > > 5485 | .entries =3D pmu_metrics__freescale= _imx8dxl_sys, > > > > > > > > Signed-off-by: Xu Yang > > > > > > Reviewed-by: Ian Rogers > > > > > > Thanks Xu! I wasn't able to repeat the failure but the fix looks good > > > to me. Is the failure caused by adding new imx8dxl metrics? I'd like > > > > Yes. > > > > > to make sure we have testing coverage so this doesn't happen again. > > > I'm trying: > > > $ make -C tools/perf O=3D/tmp/perf JEVENTS_ARCH=3Dall > > > Could you confirm that this make command was broken without your fix > > > plus the metric changes you've done? > > > > Below steps will repeat the failure. > > > > $ cd tools/ > > $ rm perf/pmu-events/arch/arm64/freescale/imx8mm/sys/ddrc.json > > $ make clean > > $ make JEVENTS_ARCH=3Dall perf > > > > pmu-events/pmu-events.c:76586:26: error: =E2=80=98struct pmu_metrics_ta= ble=E2=80=99 has no member named =E2=80=98entries=E2=80=99 > > 76586 | .entries =3D pmu_metrics__freescale_imx= 8mm_sys, > > | ^~~~~~~ > > pmu-events/pmu-events.c:76587:26: error: =E2=80=98struct pmu_metrics_ta= ble=E2=80=99 has no member named =E2=80=98length=E2=80=99 > > 76587 | .length =3D ARRAY_SIZE(pmu_metrics__fre= escale_imx8mm_sys) > > | ^~~~~~ > > > > If only metric table exists, then this error may occur. > > I can reproduce the error and confirm it fixed. > > Tested-by: Namhyung Kim Applied to perf-tools-next, thanks!