From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ian Rogers <irogers@google.com>, Jiri Olsa <jolsa@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 3/8] perf test: Use a test program in perf record tests
Date: Mon, 24 Oct 2022 21:18:29 -0700 [thread overview]
Message-ID: <CAM9d7chs_fJymdAR65rw8HM0JQaVAKAPJmsuTKCe75i-zLJSYg@mail.gmail.com> (raw)
In-Reply-To: <Y1Z3/t4RtnB8r03t@kernel.org>
On Mon, Oct 24, 2022 at 4:33 AM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> Em Thu, Oct 20, 2022 at 04:52:14PM -0700, Ian Rogers escreveu:
> > On Thu, Oct 20, 2022 at 10:26 AM Namhyung Kim <namhyung@kernel.org> wrote:
>
> > > If the system has cc it could build a test program with two threads
> > > and then use it for more detailed testing. Also it accepts an option
> > > to run a thread forever to ensure multi-thread runs.
> > >
> > > If cc is not found, it falls back to use the default value 'true'.
> > >
> > > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> >
> > Acked-by: Ian Rogers <irogers@google.com>
> >
> > I wonder if these utilities should just be built into perf to avoid
> > the cc dependency. Perhaps we can have a hidden option built into perf
> > test.
>
> Agreed, not depending on a compiler makes 'perf test' usable in more
> systems, particularly production ones where we may want to check if perf
> is passing all tests applicable to that system.
Good idea.
I think we can add an option (like -w/--workload) to run the specified
workload rather than executing the tests. Like below (assuming we
have a workload called 'noploop'). Thoughts?
$ perf stat -- perf test -w noploop
Thanks,
Namhyung
next prev parent reply other threads:[~2022-10-25 4:18 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 17:26 [PATCHSET 0/8] perf test: Improve perf record tests (v2) Namhyung Kim
2022-10-20 17:26 ` [PATCH 1/8] perf test: Do not use instructions:u explicitly Namhyung Kim
2022-10-20 23:47 ` Ian Rogers
2022-10-20 17:26 ` [PATCH 2/8] perf test: Fix shellcheck issues in the record test Namhyung Kim
2022-10-20 23:48 ` Ian Rogers
2022-10-21 8:45 ` Adrian Hunter
2022-10-20 17:26 ` [PATCH 3/8] perf test: Use a test program in perf record tests Namhyung Kim
2022-10-20 23:52 ` Ian Rogers
2022-10-24 11:33 ` Arnaldo Carvalho de Melo
2022-10-24 14:00 ` Adrian Hunter
2022-10-24 16:00 ` Arnaldo Carvalho de Melo
2022-10-25 4:12 ` Namhyung Kim
2022-10-25 13:10 ` Arnaldo Carvalho de Melo
2022-10-25 13:17 ` Adrian Hunter
2022-10-25 4:18 ` Namhyung Kim [this message]
2022-10-21 8:45 ` Adrian Hunter
2022-10-20 17:26 ` [PATCH 4/8] perf test: Wait for a new thread when testing --per-thread record Namhyung Kim
2022-10-20 23:57 ` Ian Rogers
2022-10-21 8:45 ` Adrian Hunter
2022-10-20 17:26 ` [PATCH 5/8] perf test: Add system-wide mode in perf record tests Namhyung Kim
2022-10-21 0:00 ` Ian Rogers
2022-10-26 14:11 ` Arnaldo Carvalho de Melo
2022-10-20 17:26 ` [PATCH 6/8] perf test: Add target workload test " Namhyung Kim
2022-10-21 0:01 ` Ian Rogers
2022-10-21 8:45 ` Adrian Hunter
2022-10-20 17:26 ` [PATCH 7/8] perf test: Test record with --threads option Namhyung Kim
2022-10-21 0:02 ` Ian Rogers
2022-10-21 8:45 ` Adrian Hunter
2022-10-20 17:26 ` [PATCH 8/8] perf test: Do not set TEST_SKIP for record subtests Namhyung Kim
2022-10-21 0:05 ` Ian Rogers
2022-10-24 11:34 ` Arnaldo Carvalho de Melo
2022-10-26 14:15 ` [PATCHSET 0/8] perf test: Improve perf record tests (v2) Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM9d7chs_fJymdAR65rw8HM0JQaVAKAPJmsuTKCe75i-zLJSYg@mail.gmail.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).