From: Namhyung Kim <namhyung@kernel.org>
To: Yang Jihong <yangjihong1@huawei.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
linux-perf-users <linux-perf-users@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf lock: Remove redundant word 'contention' in help message
Date: Wed, 7 Sep 2022 23:59:27 -0700 [thread overview]
Message-ID: <CAM9d7ciPd4vf3v1rdOD43vR-bh0pjj1LCcrMVTLfH6Fcxx_Dsw@mail.gmail.com> (raw)
In-Reply-To: <20220908014854.151203-1-yangjihong1@huawei.com>
Hello,
On Wed, Sep 7, 2022 at 6:52 PM Yang Jihong <yangjihong1@huawei.com> wrote:
>
> Before:
> # perf lock -h
>
> Usage: perf lock [<options>] {record|report|script|info|contention|contention}
>
> -D, --dump-raw-trace dump raw trace in ASCII
> -f, --force don't complain, do it
> -i, --input <file> input file name
> -v, --verbose be more verbose (show symbol address, etc)
> --kallsyms <file>
> kallsyms pathname
> --vmlinux <file> vmlinux pathname
>
> After:
> # perf lock -h
>
> Usage: perf lock [<options>] {record|report|script|info|contention}
>
> -D, --dump-raw-trace dump raw trace in ASCII
> -f, --force don't complain, do it
> -i, --input <file> input file name
> -v, --verbose be more verbose (show symbol address, etc)
> --kallsyms <file>
> kallsyms pathname
> --vmlinux <file> vmlinux pathname
>
> Fixes: 528b9cab3b81 ("perf lock: Add 'contention' subcommand")
> Signed-off-by: Yang Jihong <yangjihong1@huawei.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks for the fix!
Namhyung
> ---
> tools/perf/builtin-lock.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c
> index dd11d3471baf..ea40ae52cd2c 100644
> --- a/tools/perf/builtin-lock.c
> +++ b/tools/perf/builtin-lock.c
> @@ -1874,8 +1874,7 @@ int cmd_lock(int argc, const char **argv)
> NULL
> };
> const char *const lock_subcommands[] = { "record", "report", "script",
> - "info", "contention",
> - "contention", NULL };
> + "info", "contention", NULL };
> const char *lock_usage[] = {
> NULL,
> NULL
> --
> 2.30.GIT
>
next prev parent reply other threads:[~2022-09-08 6:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 1:48 [PATCH] perf lock: Remove redundant word 'contention' in help message Yang Jihong
2022-09-08 6:59 ` Namhyung Kim [this message]
2022-09-08 18:24 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM9d7ciPd4vf3v1rdOD43vR-bh0pjj1LCcrMVTLfH6Fcxx_Dsw@mail.gmail.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yangjihong1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).